From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8398AA04C0; Tue, 29 Sep 2020 09:40:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B79191D6BF; Tue, 29 Sep 2020 09:40:41 +0200 (CEST) Received: from mail-il1-f195.google.com (mail-il1-f195.google.com [209.85.166.195]) by dpdk.org (Postfix) with ESMTP id 45C011D619 for ; Tue, 29 Sep 2020 09:40:39 +0200 (CEST) Received: by mail-il1-f195.google.com with SMTP id e5so991224ils.10 for ; Tue, 29 Sep 2020 00:40:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=HqsctXrXqzRMe8XIXt70juOv7ZZ4MOF92BRaprprK+Q=; b=Kl1X2bTsASM2iRQ7yBr6pPr1jIRaGOgnxQqdWTOvggmwbSl0ffIH7OI7ABBEYJBR4g w5XDyg2ps4Tm4I14WdxEoOjs3TiN9cYZSvU58jskfAAzEsLzT3sPRC/r5wTl74DfzGJW Dt3RYb9hsEfQcjFitl2oxr3fqMSHpoCdG+IQUSy+mhh5+5qpAVYAkKCzjo79noIKkdzR OOI0OLW/+PXNJ+LHCwlELvlAOWMMZHgpQlD6Bj/zyAArvsoYGVCneZEFn4YrbEPhV3wf gEUByOO+dPRcxaRSbzgKSWFlSFfkACkYeO/WyWl3oUHZWzgPO88zW5ykug3Uy5Dlvu/F hOig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=HqsctXrXqzRMe8XIXt70juOv7ZZ4MOF92BRaprprK+Q=; b=SUs7vft8aCp7ZO5I17t6KGwBpDtPJWJIpHy6rVci4Q5H1FQsDV0s8VT+5fE5f1ohlc kwhl/u5Od6feSlwFcuj5hIgGJVMdvcraGI1MZcs0GUIUSKDTBYcCkOhOWF8QsEr3Spuc EP3lYmfopnn93WMCO9uaWCHo+DeVKbQM1qMfZCP26wDBv6hi5l0J5oneLoBpKogku5/q uA6LT3d0wYHaHXZo2cCYUCRv18zkSlwMog2SFrExi+K1m3ezbhVknpid+vuYjv1LfAcA ojpySXmyyC11wH51xFgFSEX6lPKwcu7Pz4jjJ4b6GyZffVmcFD9C4PICPkgIOsrjTkWK K/VQ== X-Gm-Message-State: AOAM530t2QX65TtJxaCxg1k6Z27AuGOgtWqHV34jlOHHZYIQUBctKFni 2iAVFDnCXo6d9ec5KyYR9lowIABn3muPh7mffIw= X-Google-Smtp-Source: ABdhPJxWjDmQGUM8hw3J4n4EJKXiN0vDW8kZ36EukbSE0/LoxSFDeoZHUJxmrTtlzgbqaj10RexMYifFtJITTx1sXgI= X-Received: by 2002:a05:6e02:e01:: with SMTP id a1mr1990635ilk.162.1601365238617; Tue, 29 Sep 2020 00:40:38 -0700 (PDT) MIME-Version: 1.0 References: <20200925115508.4179-1-manishc@marvell.com> <20200925115508.4179-2-manishc@marvell.com> In-Reply-To: From: Jerin Jacob Date: Tue, 29 Sep 2020 13:10:22 +0530 Message-ID: To: Ferruh Yigit Cc: David Marchand , Manish Chopra , Gaetan Rivet , dpdk-dev , Igor Russkikh , Rasesh Mody , GR-Everest-DPDK-Dev , Rosen Xu , Tianfei zhang , Heinrich Kuhn , Qiming Yang , Qi Zhang , Thomas Monjalon Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v6 1/6] drivers: add generic API to find PCI extended cap X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Sep 28, 2020 at 4:03 PM Ferruh Yigit wrote= : > > On 9/28/2020 9:59 AM, David Marchand wrote: > > On Sun, Sep 27, 2020 at 2:21 PM Jerin Jacob wro= te: > >> > >> On Fri, Sep 25, 2020 at 5:26 PM Manish Chopra wr= ote: > >>> > >>> By adding generic API, this patch removes individual > >>> functions/defines implemented by drivers to find extended > >>> PCI capabilities. > >>> > >>> Signed-off-by: Manish Chopra > >>> Signed-off-by: Igor Russkikh > >>> Reviewed-by: Gaetan Rivet > >> > >> Reviewed-by: Jerin Jacob > >> > >> @Thomas Monjalon @David Marchand @Ferruh Yigit > >> > >> Othe patches in the qede series is depending on this patch, Let me > >> know, how we are planning to pull this patch? Is through main or > >> dpdk-next-net or dpdk-next-net-mrvl? > > > > Just two small comments, that can be fixed by whoever applies it. > > > > - The title does not reflect that we are adding an API to the pci bus. > > My suggestion is: "bus/pci: query PCI extended capabilities" > > > > - There is an unneeded empty line added to lib/librte_pci/rte_pci.h: > > diff --git a/lib/librte_pci/rte_pci.h b/lib/librte_pci/rte_pci.h > > index 1d89651ec8..f89c7dbbea 100644 > > --- a/lib/librte_pci/rte_pci.h > > +++ b/lib/librte_pci/rte_pci.h > > @@ -22,7 +22,6 @@ extern "C" { > > #include > > #include > > > > - > > /* > > * Conventional PCI and PCI-X Mode 1 devices have 256 bytes of > > * configuration space. PCI-X Mode 2 and PCIe devices have 4096 byte= s of > > > > > > The patch is reviewed by Ga=C3=ABtan. > > Either through next-net or next-net-mrvl is fine to me. > > > > I'll leave the decision to Ferruh. > > > > > > Since other patches in the set requires Jerin's review, > @Jerin can you get the patchset to dpdk-next-net-mrvl? Yes. Merged the series after addressing @David Marchand's comments. Series applied to dpdk-next-net-mrvl/master. Thanks.