From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1CA68A04DD; Wed, 28 Oct 2020 09:52:59 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A2A91BE49; Wed, 28 Oct 2020 09:52:56 +0100 (CET) Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by dpdk.org (Postfix) with ESMTP id ECDAEBE3F for ; Wed, 28 Oct 2020 09:52:54 +0100 (CET) Received: by mail-io1-f65.google.com with SMTP id k21so4510283ioa.9 for ; Wed, 28 Oct 2020 01:52:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dTKEvrjPSi09InO5LG3gLAFKEY5qjllSVmAn6yj4Gj4=; b=MQCVjG1iEXQfKWDbQm3NO6SNFxPjv8dYLu4R6B6+zR0pxVLY0BeWmBWjQZxeSKfU9W rPjkWIB0PFy4IbhvE1qDFwr4Cj0ix1Yyi++7VJNrb+k70k0yxVsFoPufP+HvCuHKC3nK pV7W2GLbkZg0llm75+0cdfDpb2FuvblwzVwF+mld/MYJ3Z/AqJwDj8PVMkc3s/xyjGGE pKzdYT61MN4bOkF8kMmL7DyjKRLBlDxi0iM6h7KZDKFxjnOa6cTEnqDIGeAXXYcyGFDf 6G+Yt12uxEfzX+FzaizZx9omXKjHFWxgx8Oi7btcUEqfKYRFLUlwMzwCsJDEQShfJKo4 80yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dTKEvrjPSi09InO5LG3gLAFKEY5qjllSVmAn6yj4Gj4=; b=R6gyjSMXxbcRRLtKyurnXva76xIXRpZj/DBvem8AVBWGW2FRRneeLR51X2QXE8El2y mzdHQzWGwYpo6Hh/O/C8Tyw8Xhmv39ETwa3qGGQiMfeXfOiPp4TNYmCEHB9bqY87nsMj j79pExxlcag0XuW3Wi5D3m+VYLvVDabbtpdwoqdHpVqsJgzal0vbNMCHVApJ0qKduwEa 2jJo8EOaA/7HznktVxTsoV1UhdtBGsKh8Bk2gL1j7xexyGuatxdo4Kdeag8PjLmP/P6g 59TBS5JuesIQDfliKwgNQkggydNvZS4sm/h6nqWWsGgI6Z0d6+CsUvIrbB/+ngHIw5my 9Xvg== X-Gm-Message-State: AOAM533AveFCkrUcWA4RPxQUCek3okrw635Ik16K51+/MJjInem8ovs3 pBrlvcf6LLrjxDHpqiEgIrYAJrtCeiDpruXr7Kk= X-Google-Smtp-Source: ABdhPJyKhgw/oePN5JPHi5Z1HTdQerQ8c3pQoiH9YSQCEg2EgSP+S9CmNW+mt8qDtVh3/fot9NhIEXlT/pJCAhu2b2s= X-Received: by 2002:a02:7:: with SMTP id 7mr5756613jaa.112.1603875173327; Wed, 28 Oct 2020 01:52:53 -0700 (PDT) MIME-Version: 1.0 References: <20201023080058.13335-1-david.marchand@redhat.com> In-Reply-To: From: Jerin Jacob Date: Wed, 28 Oct 2020 14:22:37 +0530 Message-ID: To: David Marchand Cc: Jerin Jacob Kollanukkaran , Sunil Kumar Kori , dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 0/3] Rework CTF event description storage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 28, 2020 at 1:13 AM David Marchand wrote: > > On Fri, Oct 23, 2020 at 10:01 AM David Marchand > wrote: > > > > Following recent increase of an internal array that was limiting CTF event > > descriptions, I had a second look at the code. > > All of this is slow path, so I see no reason in keeping this limitation > > and we can go with dynamic allocations. > > > > While at it, I tweaked the metadata file output. > > > > I consider this -rc2 material. > > Comments? > Thanks. The Generated metadata has issues. Please check Reproducer: echo "trace_autotest" | ./build/app/test/dpdk-test -c 0x3 --trace=.* --no-huge --trace=.* [main][dpdk.org] $ babeltrace /home/jerin/dpdk-traces/rte-2020-10-28-PM-02-02-37/ [error] at line 1303: invalid character '0x11' [error] at line 1303: token "": syntax error, unexpected ERROR [error] Error creating AST [warning] Unable to open trace metadata for path "/home/jerin/dpdk-traces/rte-2020-10-28-PM-02-02-37". [warning] [Context] Cannot open_trace of format ctf at path /home/jerin/dpdk-traces/rte-2020-10-28-PM-02-02-37. [warning] [Context] cannot open trace "/home/jerin/dpdk-traces/rte-2020-10-28-PM-02-02-37" from /home/jerin/dpdk-traces/rte-2020-10-28-PM-02-02-37/ for reading. [error] Cannot open any trace for reading. [error] opening trace "/home/jerin/dpdk-traces/rte-2020-10-28-PM-02-02-37/" for reading. [error] none of the specified trace paths could be opened. > > -- > David Marchand >