From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F2022A053B; Thu, 6 Feb 2020 15:48:47 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 43AF31C11D; Thu, 6 Feb 2020 15:48:47 +0100 (CET) Received: from mail-il1-f196.google.com (mail-il1-f196.google.com [209.85.166.196]) by dpdk.org (Postfix) with ESMTP id 1B37E1C0DA for ; Thu, 6 Feb 2020 15:48:45 +0100 (CET) Received: by mail-il1-f196.google.com with SMTP id s18so5308660iln.0 for ; Thu, 06 Feb 2020 06:48:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IZkttY7BOKHcphghQYu5LAomKzYKtm0Dm4arzP9W4as=; b=ubY3jIrlSY9189zadr3LMrFGUxtBoJ7zZXL+bZU3hWwQAbnfSAFnEDnHHdttjJ+Zxc fOFiQ1FCtTTxnxFqbQX9dqRy7+w7cEtYMAoaxvmnhVTE7VqiFaZfHNHBOLjD7qmjVgrS LNDB5AOjIggVTrnW/FP/Qgbq2uIUjC37OEp3sl8A8+6yG51HNj0TgTSVMfMinH5+z5jH pjGoAwJ/MNCO0973YKIKnGJNAyfkNVK/Dutoc0MBABKZoLAk7f/plKJC1fUsY9ZyNP/B 2Ek//H9DxA4+w+d441ntQHFAvZ2W+O1NPT2gFM0k2RL4NistrFWJd8CSXkZSYATAV4XO 01xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IZkttY7BOKHcphghQYu5LAomKzYKtm0Dm4arzP9W4as=; b=YHVoxQuYUiz1wjfTA9rE6cOJenUtWQRAoe1nBjBlAVm5yAoHqHxIml8DR3s/SRApLO qsd69YOh/CAc5tXdEDutfkJXlmSEoCIS6ILv/sjXjK4hZtWxDdzkFePpPcsh1v8b8Kte eIRSUwiMFoU+cV0HCmiWnpluWOegOpERCaqfBel+LnQsAKLfocZ2Antgid2tMf/dQaId HYr3y7HLHjK0B1OhzAb4cGR2nDj0o76e1EumJ8wEht8N8j3aY91lJzH+x0IwP7oPrwO3 n+hyLJiCPdvUxD0IG1EGChdzvXWnZYj84DsU4odpp9d6ENA0OR4b29ta/6WNKWu8aqyT Ljpw== X-Gm-Message-State: APjAAAX56/67mP1tbX0zSDahZv9ZJ0N3gIOvD5TN3ljajL1bt7q6ZlWB hESqvHaya7+/yxS6MwSumVnxp6UL3p0efSp8MSY= X-Google-Smtp-Source: APXvYqx+MqRQJAZnsMWO9eKZyb1fgoL78GcFHiB75n9VW3jRvJy/C4eXPqsJzl8uTCfziq42WpGvzZ73lBccVDOiMNg= X-Received: by 2002:a92:1906:: with SMTP id 6mr4413777ilz.130.1581000524343; Thu, 06 Feb 2020 06:48:44 -0800 (PST) MIME-Version: 1.0 References: <20200206142749.GA777@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: From: Jerin Jacob Date: Thu, 6 Feb 2020 20:18:27 +0530 Message-ID: To: Thierry Herbelot Cc: Bruce Richardson , "dev@dpdk.org" , Anoob Joseph , Akhil Goyal Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] drivers/octeontx2: compilation fails without RTE_LIBRTE_SECURITY X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Feb 6, 2020 at 8:06 PM Thierry Herbelot wrote: > > On 2/6/20 3:27 PM, Bruce Richardson wrote: > > On Thu, Feb 06, 2020 at 02:39:28PM +0100, Thierry Herbelot wrote: > >> Hello, > >> > >> When RTE_LIBRTE_SECURITY is disabled, compilation fails for octeontx2 (on an > >> Intel machine): > >> > >> git clone git://dpdk.org/dpdk > >> cd dpdk > >> make config T=x86_64-native-linux-gcc > >> cd build > >> vi .config > >> => disable RTE_LIBRTE_IPSEC and RTE_LIBRTE_SECURITY > >> make > >> ... > >> == Build drivers/net/octeontx2 > >> CC otx2_rx.o > >> In file included from .../dpdk/drivers/net/octeontx2/otx2_ethdev_sec.h:10, > >> from .../dpdk/drivers/net/octeontx2/otx2_rx.h:11, > >> from .../dpdk/drivers/net/octeontx2/otx2_ethdev.h:24, > >> from .../dpdk/drivers/net/octeontx2/otx2_rx.c:7: > >> .../dpdk/drivers/crypto/octeontx2/otx2_ipsec_fp.h:9:10: fatal error: > >> rte_security.h: No such file or directory > >> #include > >> ^~~~~~~~~~~~~~~~ > >> compilation terminated. > >> > >> This seems cause by f44e7163775537 ('net/octeontx2: add security session > >> operations'). > >> > > Disabling parts of the build, particularly libraries, is always likely to > > cause other build failures. I'm not sure we should, or even need to, > > support the disabling of arbitrary libs in DPDK. > > Hello, > > On the other hand, there is no reason delivering unused code in a DPDK > application: an application should be free to select its needed 'modules'. Just to understand the use case, What would be the downside of compiling unwanted code? In meson, it takes only jiffies to compile code and If we use, -no-whole-archive then the generated binary will not be bloated, Considering the case where "make" build system will be deprecated soon and, for meson, I don't think, we are planning to take the route of disabling the "core libraries". Could you share the real-world use for this? My only concern is we can not make tons of #define in the driver code. So, eventually, we end up disabling the driver. > > Thanks > > Thierry > > > > > /Bruce > > >