From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D52A1A04BC; Thu, 8 Oct 2020 11:12:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 880F11BBD7; Thu, 8 Oct 2020 11:12:28 +0200 (CEST) Received: from mail-il1-f196.google.com (mail-il1-f196.google.com [209.85.166.196]) by dpdk.org (Postfix) with ESMTP id D60011BB86 for ; Thu, 8 Oct 2020 11:12:26 +0200 (CEST) Received: by mail-il1-f196.google.com with SMTP id c5so5000498ilr.9 for ; Thu, 08 Oct 2020 02:12:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5Zz07S6q9y3LlBMHxoHpO4Sb1puhEYir51N4EpiN4vM=; b=URpDBjC8LjPtB9vXqs2G9+zKsXHLef3kyTZcXc0B4D/SVDmpar23H9Q0qkSJqMHsl2 hggVMDAWESK4gL2qzewUjoeDZgMEpONimEcNFPFZlM7ff3APzLXDfE6D2qHsPEkvCQRK k4FoZJ/ucZ7oRA8M5jcqEXa+B9vrM0nOW4rT90K+bqQiqN/S/VMsK/fKsuAykIVt43E1 aECxW3c1rD0NXZKpRQVM0dXABiXaADKqcl8d3wYmOMtTqP1elh4QNElcZZWwYJEHn/Jo C4vdW6WneUWrhKZLRODvf3kzj08IigqhC3HhY8c6ZSxyw+UlVuJjn3v3Uyh+qaD67yef SJzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5Zz07S6q9y3LlBMHxoHpO4Sb1puhEYir51N4EpiN4vM=; b=GgeDHx5hdokxfzPUneIRshzbUNum3pBYx8lCctmamlsxWVBEms4xIj9CNbAL6DCWv0 ngL2XWoeAXcxxuIxH9yrmU2PllnnXC/bzN68n6XZq5eMTiet4GLnez9MzTG2AoalGnBj OMSjzzqZmSUqVr7vj1oye0jNLsDsgaDsdeKNXZCLYbNPIC8a4cNU3IQG3wAqbWx8AiBl v9Fxvgvo0vht6HMyaVPD/c2SONQ/bJid+9HGt/p4R4WH7DHl8/L9ptHX2KEKlJYLyqZQ Qcmu9tX+x/DW5BY8T7nCsv7sjw3N2D60NVtzJ6dFLNqwfI1WPX14YzyVLROgFoOiqVyt Mikg== X-Gm-Message-State: AOAM530AkL6SMtCxAAdffwUg0XuzZtsXMFAtBwYtImYbuh1qlSuCbLp1 arNflbrpO0KfUk2S/v69th2bIFByQHI/9AzQznw= X-Google-Smtp-Source: ABdhPJxS50Jo8XMX0wxlC40FwNbO2Yb2+3RkzU2WaQH30/Qb4tgoKiQp4jbGVW1+h+RBTeHsz5JkrBVZmJ/y5X/YSsM= X-Received: by 2002:a92:770e:: with SMTP id s14mr6138367ilc.130.1602148345121; Thu, 08 Oct 2020 02:12:25 -0700 (PDT) MIME-Version: 1.0 References: <20200908091534.24305-1-adwivedi@marvell.com> <20200908091534.24305-2-adwivedi@marvell.com> In-Reply-To: <20200908091534.24305-2-adwivedi@marvell.com> From: Jerin Jacob Date: Thu, 8 Oct 2020 14:42:09 +0530 Message-ID: To: Ankur Dwivedi Cc: dpdk-dev , "Gujjar, Abhinandan S" , Jerin Jacob , Anoob Joseph Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/3] test/event_crypto_adapter: return error with unsupported mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Sep 8, 2020 at 2:48 PM Ankur Dwivedi wrote: > > The capability of a event device should be checked before creating > a event crypto adapter in a particular mode. The test case returns > error if the mode is not supported. > > Signed-off-by: Ankur Dwivedi Hi Ankur, Please fix git-log.sh error[1] the following in this series and send the version. Headline too long: test/event_crypto_adapter: return error with unsupported mode Wrong tag: acked-by: abhinandan.gujjar@intel.com acked-by: abhinandan.gujjar@intel.com acked-by: abhinandan.gujjar@intel.com Missing 'Fixes' tag: test/event_crypto_adapter: fix function arguments [1] ./devtools/check-git-log.sh -n 3 ./devtools/checkpatches.sh -n 3 > --- > app/test/test_event_crypto_adapter.c | 30 ++++++++++++++++++---------- > 1 file changed, 20 insertions(+), 10 deletions(-) > > diff --git a/app/test/test_event_crypto_adapter.c b/app/test/test_event_crypto_adapter.c > index 8d42462d8..930c2a9bc 100644 > --- a/app/test/test_event_crypto_adapter.c > +++ b/app/test/test_event_crypto_adapter.c > @@ -750,15 +750,23 @@ configure_event_crypto_adapter(enum rte_event_crypto_adapter_mode mode) > uint32_t cap; > int ret; > > + ret = rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID, &cap); > + TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n"); > + > + if ((mode == RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD) && > + !(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD)) > + return -ENOTSUP; > + > + if ((mode == RTE_EVENT_CRYPTO_ADAPTER_OP_NEW) && > + !(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW)) > + return -ENOTSUP; > + > /* Create adapter with default port creation callback */ > ret = rte_event_crypto_adapter_create(TEST_ADAPTER_ID, > - TEST_CDEV_ID, > + evdev, > &conf, mode); > TEST_ASSERT_SUCCESS(ret, "Failed to create event crypto adapter\n"); > > - ret = rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, evdev, &cap); > - TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n"); > - > if (cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_QP_EV_BIND) { > ret = rte_event_crypto_adapter_queue_pair_add(TEST_ADAPTER_ID, > TEST_CDEV_ID, TEST_CDEV_QP_ID, &response_info); > @@ -813,6 +821,8 @@ test_crypto_adapter_conf(enum rte_event_crypto_adapter_mode mode) > TEST_ASSERT(ret >= 0, "Failed to link queue %d " > "port=%u\n", qid, > params.crypto_event_port_id); > + } else { > + return ret; > } > crypto_adapter_setup_done = 1; > } > @@ -845,24 +855,24 @@ static int > test_crypto_adapter_conf_op_forward_mode(void) > { > enum rte_event_crypto_adapter_mode mode; > + int ret; > > mode = RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD; > - TEST_ASSERT_SUCCESS(test_crypto_adapter_conf(mode), > - "Failed to config crypto adapter"); > + ret = test_crypto_adapter_conf(mode); > > - return TEST_SUCCESS; > + return ret; > } > > static int > test_crypto_adapter_conf_op_new_mode(void) > { > enum rte_event_crypto_adapter_mode mode; > + int ret; > > mode = RTE_EVENT_CRYPTO_ADAPTER_OP_NEW; > - TEST_ASSERT_SUCCESS(test_crypto_adapter_conf(mode), > - "Failed to config crypto adapter"); > + ret = test_crypto_adapter_conf(mode); > > - return TEST_SUCCESS; > + return ret; > } > > > -- > 2.28.0 >