From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 25133A0567; Tue, 9 Mar 2021 13:58:06 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9DAC722A359; Tue, 9 Mar 2021 13:58:05 +0100 (CET) Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) by mails.dpdk.org (Postfix) with ESMTP id 4B52122A32F for ; Tue, 9 Mar 2021 13:58:04 +0100 (CET) Received: by mail-io1-f45.google.com with SMTP id u8so13712864ior.13 for ; Tue, 09 Mar 2021 04:58:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=APijtQ7ev+FmnJB9Oqu7Z9HyBNfKUT86BJA+4yEbqh4=; b=vQDvtO5jdg5iJt1rhCDMXMaaCHD8mq94OypK6C9xCHSoHFsNE4wSZ8yYncKCLKQ9jr Unqd5UDrMoqGuU3mNmTkN2m7qFvfKILdieQrCtYmUdcbEst8uNKxZBEb/xdB0+xZ6szP YV/Aoz3IjX9i/uX8ceP/p13PbJj5h813tpHqYPwwkDugYAtfdZRb6ju5QaXbn3ZBDWXZ sLMbhPrkXJkhubBJJp6jOeMHbkmH4OQTtggDldlzOchOk1ZPTXYyTdmFUiYrhCkBeMxp Vr8G3HfxMhDWn/6ZhO6pVS2jM4gIUx8nN+XN/dz+DkuknaLZb5nrJ3Gpiz4Kw7kVEYEP 53bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=APijtQ7ev+FmnJB9Oqu7Z9HyBNfKUT86BJA+4yEbqh4=; b=hiTf0zeyN/AlMZ+gK6Xc+jh6824RoBiKhQIT56T+QR6zXbZ3Wg9nLI48v0eAEG+3BT m2a9CExXkgObblM68H7O87tSJlxA/RkyRQ0KbKa07Pps58gOIxrZFmwkW6/u6zCM1dtT pEpLJXBV0sNRarYZzSv7ZAlNMEkKXaaC5dWZWJB9IDIDd/6MYKElgqDHo4M6zAbmtir/ CIZjGpeaB8rG4Ad9v4VOzIdWgBfae80CBzUfcI5IwsNhw74U0vGIrN8Jd1P72uFJFDvM rktSFgcmmBI0P+IW3IgPAy/oBR5Tj0iE713+CXWimqXYMlCY3sjvC3+3MqIJXEfDuBdH ZJMA== X-Gm-Message-State: AOAM531q+Q+G//s2sT0NjI4HjVG7oYvR3sYcynETs3AoGN/JuP/sz77d rusJ+KssYQL3Bj+AAGcq6Edml97oSKA5joWX9hw= X-Google-Smtp-Source: ABdhPJwr/t+Jp5OySJkXoVLyneRyy6r4fMDX5X7jC7HEovZ1xdzipoXq676E2Z8gTSP1VmpoZOtshtAgLBw4EKJ0jLo= X-Received: by 2002:a05:6602:722:: with SMTP id g2mr22628572iox.1.1615294683604; Tue, 09 Mar 2021 04:58:03 -0800 (PST) MIME-Version: 1.0 References: <1610717170-31279-1-git-send-email-juraj.linkes@pantheon.tech> <1612361037-12746-1-git-send-email-juraj.linkes@pantheon.tech> <1612361037-12746-2-git-send-email-juraj.linkes@pantheon.tech> <57b0f0b0b8bb40fda8c87f7eb7ec759b@pantheon.tech> <20210309105654.GA1127@bricha3-MOBL.ger.corp.intel.com> <53b09c78d39e434aad8bfb510efcf994@pantheon.tech> In-Reply-To: <53b09c78d39e434aad8bfb510efcf994@pantheon.tech> From: Jerin Jacob Date: Tue, 9 Mar 2021 18:27:47 +0530 Message-ID: To: =?UTF-8?Q?Juraj_Linke=C5=A1?= Cc: Bruce Richardson , "Ruifeng.Wang@arm.com" , "Honnappa.Nagarahalli@arm.com" , "Phil.Yang@arm.com" , "vcchunga@amazon.com" , "Dharmik.Thakkar@arm.com" , "hemant.agrawal@nxp.com" , "ajit.khaparde@broadcom.com" , "ferruh.yigit@intel.com" , "aboyer@pensando.io" , "lironh@marvell.com" , "dev@dpdk.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v16 1/3] build: disable/enable drivers in Arm builds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Mar 9, 2021 at 5:19 PM Juraj Linke=C5=A1 wrote: > > > > > -----Original Message----- > > From: Bruce Richardson > > Sent: Tuesday, March 9, 2021 11:57 AM > > To: Juraj Linke=C5=A1 > > Cc: Ruifeng.Wang@arm.com; Honnappa.Nagarahalli@arm.com; > > Phil.Yang@arm.com; vcchunga@amazon.com; Dharmik.Thakkar@arm.com; > > jerinjacobk@gmail.com; hemant.agrawal@nxp.com; > > ajit.khaparde@broadcom.com; ferruh.yigit@intel.com; aboyer@pensando.io; > > lironh@marvell.com; dev@dpdk.org > > Subject: Re: [PATCH v16 1/3] build: disable/enable drivers in Arm build= s > > > > On Tue, Mar 09, 2021 at 08:58:39AM +0000, Juraj Linke=C5=A1 wrote: > > > Honnappa, Thomas, Bruce, Jerin, you've comments in the past. Do you h= ave > > any further input? > > > > > > I think we just need to agree on the allowlist/blocklist mechanism. T= he current > > commit allows specifying either an allowlist or a blocklist, but not bo= th. > > However, it would possible to implement specifying both - first we'll a= llow > > what's in allowlist and then we'll remove from that set what's in block= list. > > Thoughts? > > > > > > > If we have both, I think limiting to only one is by far the sanest opti= on. > > I'm not fully convinced by the need to have both, since the blocklist a= llows > > wildcarding and exception cases. For example "net/[!i]*" will blocklist= all net > > drivers except those starting with an "i". Admittedly, for usability pu= rposes > > having an allowlist might work better. > > > > If we only want to build a handful of drivers then the list could be very= long (which was the original reason behind having an allowlist), such as h= ere: > https://gerrit.fd.io/r/gitweb?p=3Dvpp.git;a=3Dblob;f=3Dbuild/external/pac= kages/dpdk.mk;h=3Dc35ac84c27b19411a0cfdf9a3524fdf36024762c;hb=3DHEAD > > An allowlist could also help with maintenance - users won't need to add n= ew drivers to their blocklists (if that's what users need, like in the case= of VPP). +1 for allowlist. > > > One final thought, if we add a driver allowlist for cross files, should= we also add > > one as a top-level meson option also for consistency? > > > > This definitely makese sense. I was thinking about this and wasn't sure w= hether I should put it into this commit or a separate one. The commit evolv= ed a bit and now that it's just an implementation of an allow/blocklist it = makes sense to include a meson option in it I think - I'll put it into the = next version. > > > /Bruce >