From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 66C81A00C5; Wed, 14 Sep 2022 15:03:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0B4464021D; Wed, 14 Sep 2022 15:03:14 +0200 (CEST) Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) by mails.dpdk.org (Postfix) with ESMTP id EC41640156 for ; Wed, 14 Sep 2022 15:03:12 +0200 (CEST) Received: by mail-qt1-f180.google.com with SMTP id f26so8534499qto.11 for ; Wed, 14 Sep 2022 06:03:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date; bh=H+FT3t/MZQ2Xhns6bM8+Ir24bxDApL6t3z4ertZmlqM=; b=gjWHJyDHCYCbZwFZKdFDGm7tJDYSbh5pn71lpbxs4yV/D19J7Uo1MAzKENHUKAvRtb UGD+ToJlpHRjLd+NyOdE6Bb+wfT/Nz9OlPND49H2heq4AdmYXWG68DA6H7HM/U6XAG2u cc4wg12VSqBaInyzKn4uBYm3p5SEFgToUFoic0Tpvp0tiNxYZVK3/l8vHC9vkj3HPJRT fE4wWOwGsEVJbfzLOmIGTlkGglamryNPE//0UpBrNKQE7Fq9264iio5tE65GO1rSfx3G Ck26bgFfAbHfsOjqbrpgtQpVCycWqfcTwFXif/+6qWn4+L+Sxd7MrbNTtEjoJEEqA5cq E3xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=H+FT3t/MZQ2Xhns6bM8+Ir24bxDApL6t3z4ertZmlqM=; b=xzsxWr0IzFEQYq+5F9JtWEOCu0femL9JBiF7mB1319DTWPmykUpF2/OfTDHgPnbm4E +BNPcNZ/qmMEjS0gGpyn2zTTtxKEfKJoZXbk4EbFmbMJIjryyxp8UIGUIpK4cQFQc3OK O9JkDH33wGzPJb90doyEATjiPH6rdNaIF1Bm0YkSIjXvskPHf19zz08hb2rXJ7vTqSWU HCAdKB7eUQAKpSG3H8X8LrKcpifa/EMO8G6JpHoV6nR7UbR5K53OVnlJGPUt/+JFi+Dv lqHfwbEi3nyTHt3HoClIPsmZihwU6a6pXqamBYIy2uQDhsn5Igrcguw379aqL26u63sZ KaHQ== X-Gm-Message-State: ACgBeo2F6KQ1oGHATKhpMzx4wQpBeSmnuwHJ4IEUqtoRVBXjjsand4Kn 5BPLdCh4If4CJcDDtrTo9A15JW8gyIqkMmrStC4= X-Google-Smtp-Source: AA6agR7LVeZvl+RiA8WmpRjocnUBxd1mSIk0qwY1eT0AZ1NPtS2A238P5NKjpnJoQ4oIDypydqVzEtQTQ1rxTUSYZ14= X-Received: by 2002:ac8:4e88:0:b0:35c:bd98:9810 with SMTP id 8-20020ac84e88000000b0035cbd989810mr1320675qtp.410.1663160592158; Wed, 14 Sep 2022 06:03:12 -0700 (PDT) MIME-Version: 1.0 References: <20220816154932.10168-1-pbhagavatula@marvell.com> <353e3a65-271b-e1bb-6b10-7608aaefa716@lysator.liu.se> <1d04373d-dc1c-997a-1baa-23d59eb173b8@ericsson.com> In-Reply-To: From: Jerin Jacob Date: Wed, 14 Sep 2022 18:32:46 +0530 Message-ID: Subject: Re: [EXT] Re: [PATCH 1/3] eventdev: add element offset to event vector To: Pavan Nikhilesh Bhagavatula Cc: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , Jerin Jacob Kollanukkaran , Jay Jayatheerthan , "dev@dpdk.org" , "erik.g.carrillo@intel.com" , "abhinandan.gujjar@intel.com" , "timothy.mcdaniel@intel.com" , Shijith Thotton , "hemant.agrawal@nxp.com" , "nipun.gupta@nxp.com" , "harry.van.haaren@intel.com" , "liangma@liangbit.com" , "peter.mccarthy@intel.com" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > >>> struct rte_event_vector { > > >>> uint16_t nb_elem; > > >>> - /**< Number of elements in this event vector. */ > > >>> - uint16_t rsvd : 15; > > >>> + /**< Total number of elements in this event vector. */ > > >> > > >> I'm not sure "total" adds anything here. Didn't the old nb_elem also > > >> include the total number of elements? > > >> > > > > > > Yes, I added it to clarify that it includes slots that don=E2=80=99t = have valid elements. > > > I will update the comment to convey that it includes elements before > > offset. > > > > > > > The issue is that it doesn't clarify anything. Change the name, or > > change the semantics to fit the name, instead of explaining a poor name > > in a comment. > > > > Names are always subjective and will confuse someone or the other. > But we can do our best to communicate the semantics, how about > total_(elements|slots|lanes) and valid_(element|slot|lane)_offset. > > I will send the next version once we agree upon the naming. In order to make forward progress, @Mattias R=C3=B6nnblom Do you have specific name suggestions for the next version? If not, I suggest to pick total_elements