From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1033641B9E; Wed, 1 Feb 2023 12:16:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AFB0642D70; Wed, 1 Feb 2023 12:16:21 +0100 (CET) Received: from mail-vs1-f53.google.com (mail-vs1-f53.google.com [209.85.217.53]) by mails.dpdk.org (Postfix) with ESMTP id 1CE5F42D55 for ; Wed, 1 Feb 2023 12:16:19 +0100 (CET) Received: by mail-vs1-f53.google.com with SMTP id a24so17164422vsl.2 for ; Wed, 01 Feb 2023 03:16:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=pSSqAy755R3MU15tdeZBnsw1aUFnKpZfJe1TP/JzBGA=; b=jEZjUJpcBabpUR6CanCKWqXdTQ6XD2fr278glf08135L053Pn4stUs/7Jeg2Zci6kV VGL4Eh2tvEhQUaPMaTCHGt1o1zUF467E2ToWhlv39huoRLvAaVdK/bOaTASTw5QFuKA9 sgkvE3FrlYFCG0AFdXw3/ZuIFqewNGxOG0G6AofOjXU5paVWGL61Osh23Iz643mRM8vd 7DuTR8wE7ySb39I+sCYZra2kHLviTF+smSeeXYKMhZtSKDtmTdq1wqACZSng7qZOtEKa /UZ8AdVTH1MsUB0IS2zSDEj+75MZ6pAhLqu5qEuZghBd5IcRsidzrV7o7MoZHcicLe+d b5XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pSSqAy755R3MU15tdeZBnsw1aUFnKpZfJe1TP/JzBGA=; b=Ju3ms8mm+ZvPvRCONRyK5PgBCTCgp1rl2pWKufFkf45jaXWjGtYGFmM8UY2l1vBCQL H8VdA6wuQoLwNMMVZpwsLmfot9pjLAA5p2iGNQr04LIktPUfeA9LTQTrWq9hZ1ZrIMFf 1CikBZDiwjnGkGKblpTZfHPVKLWzUOzvHmTZFW2zupUa86f4Cd2cu9o1nYE5CUGiNKUv GK58ShTAiNT6KRGPd8KE5plM0MTQ4yUGJiufOBudtUrmvyxrNJaHaY4h7TvfGqaqryed oQDgQl/IfnObZco1DrWe/1hYMHD9kDu06kXKB3SF+VBcUCXiSvnb31Xz9WjMvlj5CHfT 35iw== X-Gm-Message-State: AO0yUKU3/CG7ZQgoR3BcXNQJ7eC0Z+W1vls06wLjiHrrQdGZp8cVvf2Q ATSYf/Yiji+iG7vv0AaygL2iYPET1JEXaA/iQoc= X-Google-Smtp-Source: AK7set9dH3gLSXxmcI+N8IGJdH7dbsrlgLqQPmQdfscC5yGy8S9G+9YLs3nHE/OVJKw2iPX5hIV3rFcbjief36p+UyY= X-Received: by 2002:a67:fb81:0:b0:3f1:b35:72d2 with SMTP id n1-20020a67fb81000000b003f10b3572d2mr339236vsr.73.1675250178411; Wed, 01 Feb 2023 03:16:18 -0800 (PST) MIME-Version: 1.0 References: <20221220200250.2413443-1-hpothula@marvell.com> <98a80c20-a5e4-deea-f7dc-c6aa5d52800b@oktetlabs.ru> <2490780.4XsnlVU6TS@thomas> In-Reply-To: <2490780.4XsnlVU6TS@thomas> From: Jerin Jacob Date: Wed, 1 Feb 2023 16:45:51 +0530 Message-ID: Subject: Re: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation To: Thomas Monjalon Cc: Andrew Rybchenko , Ferruh Yigit , Ori Kam , Ivan Malov , Nithin Kumar Dabilpuram , Aman Singh , Yuying Zhang , "dev@dpdk.org" , Hanumanth Reddy Pothula , Slava Ovsiienko , Jerin Jacob Kollanukkaran , "david.marchand@redhat.com" Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Feb 1, 2023 at 4:35 PM Thomas Monjalon wrote: > > 01/02/2023 11:58, Andrew Rybchenko: > > On 2/1/23 13:48, Jerin Jacob wrote: > > > On Wed, Feb 1, 2023 at 2:59 PM Andrew Rybchenko > > > wrote: > > >> Frankly speaking I don't understand why default value is so > > >> important if we have a way to change it. Reasons should be > > >> really strong to change existing defaults. > > > > > > The only reason is, typically testpmd will be used performance > > > benchmarking as an industry standard. It is difficult to tell/educate > > > the QA or customers > > > that, "BTW if you need to get better performance add more flag to > > > testpmd command line". > > I disagree. > When you do performance benchmark, you tune settings accordingly. IMO, We tune the system resources like queue depth not the disabling features for raw performance. queue depth etc people know to tune so it is obvious. What is not obvious is, testpmd only negotiated some features by default.I am not using that feature, hence I need to explicitly disable it. > > > > To make that worst, only some PMD needs to give the additional > > > parameter to get better number. > > > And also, testpmd usage will be treated as application modeling. > > > > > > Since this feature only used on sfc and cnxk driver, What is the > > > situation with sfc driver? > > > Keeping it as negotiated and not use the feature, will impact the per > > > core performance of sfc or > > > is it just PCI bandwidth thing which really dont show any difference in testpmd? > > > > Yes, sfc could run faster if no Rx metadata are negotiated. So, > > it is better to negotiate nothing by default. But it is always > > painful to change defaults. You need to explain that now you > > need to negotiate Rx metadata to use mark, flag and tunnel offloads. > > Yes, it will be required on sfc and cnxk only. > > As an sfc maintainer I don't mind to change testpmd defaults. > > If we change testpmd defaults to "do nothing", > then we should disable MBUF_FAST_FREE as well. if you see MBUF_FAST_FREE, it does nothing. Actually, !MBUF_FAST_FREE is doing more work. > >