Re: [PATCH] common/cnxk: return on fail to init ROC Model

[Jerin Jacob <jerinjacobk@gmail.com>]

On Fri, Jun 10, 2022 at 1:44 PM Hanumanth Pothula <hpothula@marvell.com> wrote:
>
> Return with error on fail to initialize RoC Model.
>
> Signed-off-by: Hanumanth Pothula <hpothula@marvell.com>


Updated the git commit as follows and applied to
dpdk-next-net-mrvl/for-next-net. Thanks

    common/cnxk: handle ROC model init failure

    Return with error on fail to initialize ROC model.

    Fixes: 014a9e222bac ("common/cnxk: add model init and IO handling API")
    Cc: stable@dpdk.org

    Signed-off-by: Hanumanth Pothula <hpothula@marvell.com>


> ---
>  drivers/common/cnxk/roc_platform.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/common/cnxk/roc_platform.c b/drivers/common/cnxk/roc_platform.c
> index ebb6225f4d..443aa8d396 100644
> --- a/drivers/common/cnxk/roc_platform.c
> +++ b/drivers/common/cnxk/roc_platform.c
> @@ -37,7 +37,12 @@ roc_plt_init(void)
>                                 plt_err("Failed to reserve mem for roc_model");
>                                 return -ENOMEM;
>                         }
> -                       roc_model_init(mz->addr);
> +                       if (roc_model_init(mz->addr)) {
> +                               plt_err("Failed to init roc_model");
> +
> +                               rte_memzone_free(mz);
> +                               return -EINVAL;
> +                       }
>                 }
>         } else {
>                 if (mz == NULL) {
> --
> 2.25.1
>