From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0E486A00BE; Wed, 15 Jun 2022 20:00:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EB41A427EB; Wed, 15 Jun 2022 20:00:06 +0200 (CEST) Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) by mails.dpdk.org (Postfix) with ESMTP id 3A5D6410D0 for ; Wed, 15 Jun 2022 20:00:05 +0200 (CEST) Received: by mail-qk1-f178.google.com with SMTP id c144so9295728qkg.11 for ; Wed, 15 Jun 2022 11:00:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GnhdtkuDGZZOcwBObb8vHq49Kcq4J6jx36M9Tbf6EXQ=; b=FyXAi54C510dBuON0DxAXQkED/c5qZD5PRRiw1Bn9FCY64BSvXFNPmEXVnQTUukFai odZBLw6u8rvCVuDrFR6HoOCyCqzoHblg+MEU4QudOXFo3jYq3xKr7UMmlsM6kONNj7v5 w/qNwjIZRcz5NsomO6K4+LXAnfw7Pp6Srzyx8djbCILboeuSDHvGLaj95nWRx6b2B9AQ A50cZO9fkWklcZCGfU+p4lJBzir3dkHRNLQYLK0em+sgOIMWZCOVNO/JNUpzl4ktMgKd PkUYFPs8kPwD/ozJHGG90DMhcVQGDayY/xBsh1JUhQvhle4ehK/4Z8LYyGdQL6Nzq7mW BjMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GnhdtkuDGZZOcwBObb8vHq49Kcq4J6jx36M9Tbf6EXQ=; b=kyFZCym2bgtlJK19/DObwu8TWzDQOq3yd9JcGAY4B98f7giNXI0ZdPRgfqcwP0KCNr mIuVj38MMUsYnBzG591EB7DmOrj0GzA8Er4Ro8aMF3g6A0EikGw6nfryNiMt7tCvau5+ WWHL0Wwu17u7CYj1PZrg0B59C3SFJqcLrJ/JwGJeyy4+Kyt/+qQSiuOBcDbeoqfbjcd1 BCb2LchIFqYmi4jqnlSANpMmDtDHm3h81h4Go0wdKbx95iz4k8eiCyPJN+/ryzYPrLDM TvMGApJwtqjLlliICyGE06roaVmSpp9SI7wZrluY9UVxQJWH25AP7gj63RBM+Vb80QFb VFlQ== X-Gm-Message-State: AJIora/tKQmRDIOoqYJcXN80StNhRZLR/via1pv4kKPm0R/GV0MmuwSw X3R8aMdGzmNkRMfTRko2EamdHtHvTg0G3DSz14NUQ6P1/Vg= X-Google-Smtp-Source: AGRyM1vF0hyUFY5apkw+wcw06TKQvOgcO7OlOdJe8Y/E86Vxi8VKRmhuJH0+iPnv1EqxE2GtrZ7YaKyeWM9mwq3yNmE= X-Received: by 2002:a05:620a:424b:b0:6a7:8eda:bb29 with SMTP id w11-20020a05620a424b00b006a78edabb29mr740956qko.26.1655316003578; Wed, 15 Jun 2022 11:00:03 -0700 (PDT) MIME-Version: 1.0 References: <20220610081415.3855297-1-hpothula@marvell.com> In-Reply-To: <20220610081415.3855297-1-hpothula@marvell.com> From: Jerin Jacob Date: Wed, 15 Jun 2022 23:29:37 +0530 Message-ID: Subject: Re: [PATCH] common/cnxk: return on fail to init ROC Model To: Hanumanth Pothula Cc: Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , dpdk-dev , Jerin Jacob Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jun 10, 2022 at 1:44 PM Hanumanth Pothula wrote: > > Return with error on fail to initialize RoC Model. > > Signed-off-by: Hanumanth Pothula Updated the git commit as follows and applied to dpdk-next-net-mrvl/for-next-net. Thanks common/cnxk: handle ROC model init failure Return with error on fail to initialize ROC model. Fixes: 014a9e222bac ("common/cnxk: add model init and IO handling API") Cc: stable@dpdk.org Signed-off-by: Hanumanth Pothula > --- > drivers/common/cnxk/roc_platform.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/common/cnxk/roc_platform.c b/drivers/common/cnxk/roc_platform.c > index ebb6225f4d..443aa8d396 100644 > --- a/drivers/common/cnxk/roc_platform.c > +++ b/drivers/common/cnxk/roc_platform.c > @@ -37,7 +37,12 @@ roc_plt_init(void) > plt_err("Failed to reserve mem for roc_model"); > return -ENOMEM; > } > - roc_model_init(mz->addr); > + if (roc_model_init(mz->addr)) { > + plt_err("Failed to init roc_model"); > + > + rte_memzone_free(mz); > + return -EINVAL; > + } > } > } else { > if (mz == NULL) { > -- > 2.25.1 >