From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C9514A0566; Mon, 8 Mar 2021 20:02:30 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5BEF522A48F; Mon, 8 Mar 2021 20:02:30 +0100 (CET) Received: from mail-il1-f172.google.com (mail-il1-f172.google.com [209.85.166.172]) by mails.dpdk.org (Postfix) with ESMTP id D76E222A48D; Mon, 8 Mar 2021 20:02:29 +0100 (CET) Received: by mail-il1-f172.google.com with SMTP id k2so9835562ili.4; Mon, 08 Mar 2021 11:02:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UHVl99VUqWMAbucZRFMn5ON2yoXDvzDBOpaXDD/433I=; b=RAnqkOZiPu82/1ldNnVzelfjx5On1yMgBiwO28NsjSiEWFD0GjU8ErraBIuF5XMrXf vrdOa0NEYCFG9y6t9ZLBOx6lNxIRIdAq3YjwlamKnQVWfpPs8xIXwhk+T0p+Xc9XBePk 55lAnkt52H/cUV/fdnoUOMWiFC8K05CLk75P+xIFBgshJcMkMetekH1lPA6dVEf1KlFT 7D/4bDK6dwrerZmmK8oAYBISFgfxv2pbCgXQorO+klgnYvNOloPXfZaVZhEX45BG3EGl p4hBM5ASW+CvhF7716VHyS2BPAaAbpl2IUbHUqhLU7/FTFvyKlNixEc1LFHrEFzv3o0+ MPqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UHVl99VUqWMAbucZRFMn5ON2yoXDvzDBOpaXDD/433I=; b=Eyw6zwQQhDk8s68DtWlb89ksJx7ElKapXnqVac4fulfhR1GcQyFr9YMS3yXVSPKFKS NzkUhr4IfyLLNog77U6xRLJ438zezeaMivq1e6q36TA1RHjdVPhiSc8rKPfqTvzlBV5R +baZKiqaYeLzQfo37rD/LwGD7RXG01bozo+c/e/ZvqCriR7O4/NlsijgXSk5vLxUkpN2 o90PC9Wbe/2aeCQPAnFM5OfOFswrjbcay5p33bCKGVHfUGyhZQ6p8sZ53X29PEW3UHSc yu2kLFOuD533jN5UKmsGSdiyBNVJaXXBltJWJxy+51JYFzShMjMjvPItBA3A4u4SWTfq 6ZYw== X-Gm-Message-State: AOAM530uvqJculj62Wgz1YHILFpCAqQFy7MaeLHLFNHRTWyeP5V8qLaK 4fbzZSK9uJNfBN7pZaVoCDuSYCDRxVGmUHEmUCdv7vKrH94= X-Google-Smtp-Source: ABdhPJyqbU/lxNdpbJonZE3Vam+JDmGOP1NwdooIBGDh0IFV2aw9vAYyTl1r8HQS/S3PAiOT3a8hKEb0dGw6mlur7HY= X-Received: by 2002:a92:d18e:: with SMTP id z14mr22021044ilz.130.1615230149133; Mon, 08 Mar 2021 11:02:29 -0800 (PST) MIME-Version: 1.0 References: <20210221111637.31193-1-irusskikh@marvell.com> <20210221111637.31193-3-irusskikh@marvell.com> In-Reply-To: <20210221111637.31193-3-irusskikh@marvell.com> From: Jerin Jacob Date: Tue, 9 Mar 2021 00:32:12 +0530 Message-ID: To: Igor Russkikh , Shahed Shaikh Cc: dpdk-dev , Rasesh Mody , Devendra Singh Rawat , dpdk stable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 2/2] qede: make driver accept bigger rss tables X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, Feb 21, 2021 at 4:47 PM Igor Russkikh wrote: > > We found some dpdk applications blindly pass fixed side rss hash tables, > and do not check driver/device capabilities. > > Moreover, many other drivers do not do such a strong check as well. > > So here we fix it, making qede accept any size rss_key. For larger key > tables we just crop it with notice trace message. > > CC: stable@dpdk.org > Signed-off-by: Igor Russkikh HI @Rasesh Mody @Shahed Shaikh Could you review this series? > --- > drivers/net/qede/qede_ethdev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c > index ab5f5b106..7363d98f2 100644 > --- a/drivers/net/qede/qede_ethdev.c > +++ b/drivers/net/qede/qede_ethdev.c > @@ -2139,8 +2139,8 @@ int qede_rss_hash_update(struct rte_eth_dev *eth_dev, > /* RSS hash key */ > if (key) { > if (len > (ECORE_RSS_KEY_SIZE * sizeof(uint32_t))) { > - DP_ERR(edev, "RSS key length exceeds limit\n"); > - return -EINVAL; > + len = ECORE_RSS_KEY_SIZE * sizeof(uint32_t); > + DP_NOTICE(edev, false, "RSS key length exceeds limit\n"); > } > DP_INFO(edev, "Applying user supplied hash key\n"); > rss_params.update_rss_key = 1; > -- > 2.25.1 >