From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E21ADA054B; Thu, 16 Jul 2020 15:02:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CAF081D426; Thu, 16 Jul 2020 15:02:46 +0200 (CEST) Received: from mail-il1-f196.google.com (mail-il1-f196.google.com [209.85.166.196]) by dpdk.org (Postfix) with ESMTP id 247821D424 for ; Thu, 16 Jul 2020 15:02:46 +0200 (CEST) Received: by mail-il1-f196.google.com with SMTP id t18so4964617ilh.2 for ; Thu, 16 Jul 2020 06:02:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=7b8A4KUgRWE0IWqVsuhQVr0TwqUtq0yi9yhsITqFr1A=; b=C28Wj3dPyyR4iwcPnfqNbCKlq4gSpKXSG137klAGhjnWLkVpsdjuAS38XWthbbp+c2 Mp9699uBUTQYbKhhfCpGWFaX3KVlbx5YW/MJssMzRVl4iE/rHtlGZm74yoyp5CT3rji4 79eU8d5OJcXqPiQGRn6U54cebI3PzDQOeieubnvMpeqE+T/owMNj8ydUQkt/AuwNCsj7 uUu1vRiHJz+SOx3dY5zh9HzIkDb1+oQYCUB5Hu1VFfshOMAH161v2TGhTH8Z6QBEJjff TBNiTKurXtSxMPT988TF11KMQZDhalTSuTQT/pnJtNlvXHUdPH1xYA2kAM+2svDsRd77 ZLtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=7b8A4KUgRWE0IWqVsuhQVr0TwqUtq0yi9yhsITqFr1A=; b=tBPeFwSJL2aqw+OQw3tu/MhQFr0SUZ6XyangTrduEH+FtfaUXe7j3ewmYT4nUj/o9S EJTlAe1SGlu/FwPbuW7eEwpkPHm2nFGNybralgHR1pxclAGq0IpS9WWNqeYnymp/lZvt tvf8QjlPntXCK1LRkXsma3vxpWsF3jnVRqpZTZwvKU/Ec1e1Vry71trVGxYBngbkO2Qu d9JJNMOzNM8rYUQuIbg314iR0Z3iHrf6qRPyYeYzVykak+T71W7LMi2j4Pl39FGEWBIg 9qiXkSoJZcnvP9RPSIzJnXKayF1R1GMVC1nriCaipz1No/1lLEB0s+zan54uP84c57kL 0HJQ== X-Gm-Message-State: AOAM530SYVtYNO5izqs4zrMv6zd1T/TcrfMtpQnP/nnFIW7Uv0rBh5/f +YdfgQcSRmzFW3uqU4NF53cnih2BisGFu4j0fEI+yVhrFzU= X-Google-Smtp-Source: ABdhPJzeKzfS/cWs4+kfc8Dgxs3asVXX/9WtpfDLkviDGc1MZWPyEs3C/OMxrxUphbcv0qD6ep1I8Ab7NqKRUT5rUG0= X-Received: by 2002:a92:d206:: with SMTP id y6mr4507441ily.162.1594904565340; Thu, 16 Jul 2020 06:02:45 -0700 (PDT) MIME-Version: 1.0 References: <20200713151319.17547-2-manishc@marvell.com> <2902125.JAyrVFZy8S@thomas> <1914663.Rf5fFZbPsG@thomas> In-Reply-To: <1914663.Rf5fFZbPsG@thomas> From: Jerin Jacob Date: Thu, 16 Jul 2020 18:32:29 +0530 Message-ID: To: Thomas Monjalon Cc: =?UTF-8?Q?Ga=C3=ABtan_Rivet?= , Manish Chopra , Ferruh Yigit , Igor Russkikh , dpdk-dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2 1/7] lib/librte_pci: add rte_pci_regs.h X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 16, 2020 at 6:20 PM Thomas Monjalon wrote= : > > 16/07/2020 13:55, Jerin Jacob: > > On Thu, Jul 16, 2020 at 4:57 PM Thomas Monjalon w= rote: > > > > > > 16/07/2020 12:27, Jerin Jacob: > > > > On Thu, Jul 16, 2020 at 3:48 PM Ga=C3=ABtan Rivet = wrote: > > > > > > > > > > On 16/07/20 12:08 +0200, Ga=C3=ABtan Rivet wrote: > > > > > > Re-CCing dev@dpdk.org as it was removed from the reply. > > > > > > > > > > > > On 13/07/20 08:13 -0700, Manish Chopra wrote: > > > > > > > This is merely copy of latest linux/pci_regs.h in > > > > > > > order to avoid dependency of dpdk on user headers. > > > > > > > > > > > > > > > > > > > I guess this dependency is an issue on non-linux systems, when = you must > > > > > > use those defines in a generic implementation. Can you confirm = this is > > > > > > the motivation here? > > > > > > > > > > > > If so, I think it would be clearer to state "in order to avoid > > > > > > dependency of DPDK on linux headers". > > > > > > > > > > > > > > > > To add to it, if this is actually the motivation to add this head= er, I > > > > > don't think it is sufficient. > > > > > > > > > > You can restrict the function definition to the linux part of the > > > > > PCI bus driver instead, using stubs for other systems. > > > > > > > > > > > > Signed-off-by: Manish Chopra > > > > > > > Signed-off-by: Igor Russkikh > > > > > > > --- > > > > > > > drivers/bus/pci/linux/pci_uio.c | 2 +- > > > > > > > drivers/bus/pci/linux/pci_vfio.c | 2 +- > > > > > > > drivers/net/bnx2x/bnx2x.h | 2 +- > > > > > > > drivers/net/hns3/hns3_ethdev_vf.c | 2 +- > > > > > > > drivers/vdpa/ifc/base/ifcvf_osdep.h | 2 +- > > > > > > > lib/librte_pci/Makefile | 1 + > > > > > > > lib/librte_pci/meson.build | 2 +- > > > > > > > lib/librte_pci/rte_pci_regs.h | 1075 +++++++++++++++++= ++++++++++ > > > > > > > 8 files changed, 1082 insertions(+), 6 deletions(-) > > > > > > > create mode 100644 lib/librte_pci/rte_pci_regs.h > > > > > > > > > > > > > > > > > > > [...] > > > > > > > > > > > > > diff --git a/lib/librte_pci/rte_pci_regs.h b/lib/librte_pci/r= te_pci_regs.h > > > > > > > new file mode 100644 > > > > > > > index 000000000..1d11f4de5 > > > > > > > --- /dev/null > > > > > > > +++ b/lib/librte_pci/rte_pci_regs.h > > > > > > > @@ -0,0 +1,1075 @@ > > > > > > > +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note = */ > > > > > > > +/* > > > > > > > > > > > > This file is delivered alongside the PCI lib, targeting userspa= ce. > > > > > > This seems to be an exception to the license policy described i= n > > > > > > license/README. Code shared between kernel and userspace is exp= ected > > > > > > to be dual-licensed BSD-3 and GPL-2.0. > > > > > > > > > > > > As it is a copy of Linux user includes, re-licensing it as BSD-= 3 as well > > > > > > is not possible. > > > > > > > > > > > > So I think it might require a techboard + governing board excep= tion > > > > > > approval. Ferruh or Thomas, what do you think? > > > > > > > > I think, instead of importing GPL-2.0 file, We can add the constant= s > > > > as need by the DPDK > > > > as symbols start from RTE_PCI_*(It will fix up the namespace as wel= l). > > > > > > If symbols can be found in /usr/include/, don't add anything. > > > > Not by default on all the distros. It is part of pciutils library. > > Moreover, we need these symbols for Windows OS as well. > > IMO, We should add absolute minimum constants that needed for DPDK as R= TE_PCI_* > > I am for mandating the dependency instead of copying it. You mean _pciutils_ package as a mandatory dependency to DPDK. > > pciutils cannot be installed on Windows? > Why do you care about Windows? > I don't see any contribution for qede on Windows. You closely review the patch, it not about qede. The proposed file comes at lib/librte_pci/rte_pci_regs.h which is common to Windows. > >