From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF621A04B7; Sun, 4 Oct 2020 12:02:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AE5E61BD2B; Sun, 4 Oct 2020 12:02:26 +0200 (CEST) Received: from mail-io1-f68.google.com (mail-io1-f68.google.com [209.85.166.68]) by dpdk.org (Postfix) with ESMTP id 01B7A1BD2B; Sun, 4 Oct 2020 12:02:24 +0200 (CEST) Received: by mail-io1-f68.google.com with SMTP id u6so6172013iow.9; Sun, 04 Oct 2020 03:02:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=onB4dxuOgUJBWxt+MG5ztPYrK+BZtp1Eg+w6YkOGyI0=; b=VBkwh1njwW0c2DPJy2wDsMIbfJjGIHBojPDFE2WHULddsxhSbdFVb8eN2vN31Ej+wk p2Go4mh04dVQ9ebIrrPGak8hs2dTXED5vDiF9VfW5l0x/+DnQ9f+jWBEJIZCgVlFJTGr mWK68EPXbnobR61O0ROm4W80Ep3+GFtwgIMnskoUf37WkYFr0iEp1LjjFyrAJelQ8a5l 94SlWZuc/1QxF597MWWOFZzg2KzaMJqBZ0n0SOSU2L98GNxWWyaPwaYpcMYEbX/nnbUi 0e992fiBVhyBxPJafZPcxOVzI4gmkv6agf40I0lhaOXQ2FmEUWug+TIsRwwfnfPZZJSu PJBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=onB4dxuOgUJBWxt+MG5ztPYrK+BZtp1Eg+w6YkOGyI0=; b=KdfKU54nQExarwiaPvX8dC3MmV13eIWDjxsv2HqGnMnhXDvBhdvBnVr5F2DZ8AUvnQ L+rLxubHdNYkc3IRUZTWI6yh2l7CwgX4yGAov3M0HSPzXy3gh0vAth+jIb5KbDyQfja8 ys/r5YCrSkACnhJGkYfwW9Zie2CX8+9rt/00W/CattpkhNL1tE8CT1MToh/y7dsV1Td5 3+BCl9ctCAyDdj1ZHw8s0HohNpQRLWWgcXWBiNLA5L4iN7TVbZfXif7pcZlg97Jt8EUS MgEEx6KlCAvwAdpEeslkYZzreu0aLO6iFm5QweC4F3iF9CT7t36NpZoUGOWtmRwiLQx4 sHQA== X-Gm-Message-State: AOAM530nAaD4/5KrQZOIgmj2yPcgd1Ug1rnHOmCruNZ7bsOImbGAi+hS 7RHrMiurYxBjWIt6JewIPydOYDg6b7G1CYVbDJs= X-Google-Smtp-Source: ABdhPJzql+H7pN0nFVqunrqHjPUSE8ZNLP5jzicHyuyGGAItIG705QIcJ2o9bE6wgr4fs45va/fFFcQWdfQyNSPBvzA= X-Received: by 2002:a05:6638:16c5:: with SMTP id g5mr8929676jat.112.1601805743190; Sun, 04 Oct 2020 03:02:23 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jerin Jacob Date: Sun, 4 Oct 2020 15:32:05 +0530 Message-ID: To: "Rao, Nikhil" Cc: wangyunjian , "dev@dpdk.org" , "jerry.lilijun@huawei.com" , "xudingke@huawei.com" , "stable@dpdk.org" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] eventdev: fix return value of null not checked X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Aug 6, 2020 at 9:10 PM Rao, Nikhil wrote: > > > > -----Original Message----- > > From: wangyunjian > > Sent: Monday, July 27, 2020 7:33 PM > > To: dev@dpdk.org; Rao, Nikhil > > Cc: jerry.lilijun@huawei.com; xudingke@huawei.com; Yunjian Wang > > ; stable@dpdk.org > > Subject: [dpdk-dev] [PATCH] eventdev: fix return value of null not checked > > > > From: Yunjian Wang > > > > The function rte_zmalloc() could return NULL, the return value need to be > > checked. > > > > Fixes: a3bbf2e09756 ("eventdev: add eth Tx adapter implementation") > > Cc: stable@dpdk.org > > > > Signed-off-by: Yunjian Wang > > --- > > lib/librte_eventdev/rte_event_eth_tx_adapter.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/lib/librte_eventdev/rte_event_eth_tx_adapter.c > > b/lib/librte_eventdev/rte_event_eth_tx_adapter.c > > index bb21dc407..86287b4e6 100644 > > --- a/lib/librte_eventdev/rte_event_eth_tx_adapter.c > > +++ b/lib/librte_eventdev/rte_event_eth_tx_adapter.c > > @@ -734,6 +734,8 @@ txa_service_queue_add(uint8_t id, > > > > qdone = rte_zmalloc(txa->mem_name, > > nb_queues * sizeof(*qdone), 0); > > + if (qdone == NULL) > > + return -ENOMEM; > > Reviewed-by: Nikhil Rao Applied to dpdk-next-eventdev/for-main. Thanks. > > > j = 0; > > for (i = 0; i < nb_queues; i++) { > > if (txa_service_is_queue_added(txa, eth_dev, i)) > > -- > > 2.23.0 > > >