From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 812EAA3160 for ; Fri, 11 Oct 2019 10:02:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 467BC1E99F; Fri, 11 Oct 2019 10:02:33 +0200 (CEST) Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by dpdk.org (Postfix) with ESMTP id F07D71E985 for ; Fri, 11 Oct 2019 10:02:31 +0200 (CEST) Received: by mail-io1-f65.google.com with SMTP id q10so19719521iop.2 for ; Fri, 11 Oct 2019 01:02:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=E4LCVHCjJSVH5ZtPaEz54C8Anuyr+3HVuZzYbsdOcxE=; b=XVPPlRrLwEc9NeEpNc1EUT+tzhedevKtJOwwIi6lINLU1VDQ/Mhy0M/6RCl0saY+Wn DqjGddEIsui6hgw4Ij0s6rw3Dil3wW/c6TsftgeVLwf2DqOY/Tg/P02ex1I4D1erMbRP qIIpsabA8VwbvlY4ueRTYH3ESujY7Zn2cIwprIyZSEQOOD6fZtM2qYVBxaNTE3qpAsP0 7G9vFDWh53L6v4b1rw44pruWGoPcoEwFjT1SMCdMHtv2i2EI73e3N/n8zOXzOMCzlbg8 hu8u1HwAofqMYlQWmF9Vrsbh9g/puytu38rs5YWgK3gNOShNfwiX27Rhb+ZVFqkfE4lo bITA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=E4LCVHCjJSVH5ZtPaEz54C8Anuyr+3HVuZzYbsdOcxE=; b=H0vGUGZQ3yJHrP/REOhWqfSEv1FkM2TlDhAHa/AvX3qlRL0gFKhESlD0RIkHRX+Qc7 kEWjeOVnSAZnb0L/AEbqKCs3QdF8ilgt326wL0ZKFVwIL8exRlPKY6mNos2n4XiBRwgI UJT/nuGPhrTdry7egrGnukF5O7PoIzyt1xRx82ChttDY0Kkbdzt9AkYdvOOqRQUuY7fH hwcCmyXJvD6LpIDdjNNubmg8bE76HAEY7KkkVJLk2QTdhmssI8LccbJ/eEQqSjVNSuOR GVq3OOe8ZlmGD0x44lD62mcx/gxNRosGQPlsMouhrY+fgydo9QDvgeKaETLnloMKkEQO FOBA== X-Gm-Message-State: APjAAAWHbXc6LjfjkFEI8mD0b9wlcxK0Q7nzI3eCHBH9qHVnxi+SlOVL 8rSN4gAdOgUa+monx/AMdzBrU7gB+yOAQUuHWHtr4KT8lj2gFA== X-Google-Smtp-Source: APXvYqxBFDDO1N0hf1GjwySvPYBd3AjBGBmXv2P6UlNN7CSKw1JDQcrercn3uxsDlPBKFoAvBdvtumhzyJk2rwxWJ6w= X-Received: by 2002:a02:ca06:: with SMTP id i6mr15979438jak.112.1570780951052; Fri, 11 Oct 2019 01:02:31 -0700 (PDT) MIME-Version: 1.0 References: <20191008090024.1250-1-pbhagavatula@marvell.com> In-Reply-To: <20191008090024.1250-1-pbhagavatula@marvell.com> From: Jerin Jacob Date: Fri, 11 Oct 2019 13:32:19 +0530 Message-ID: To: Pavan Nikhilesh Cc: arybchenko@solarflare.com, Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , dpdk-dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] net/octeontx2: add set supported types op X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 8, 2019 at 2:30 PM wrote: > > From: Pavan Nikhilesh > > Add support to set supported ptypes for octeontx2. > > Signed-off-by: Pavan Nikhilesh > --- > This patch depends on the following series > http://patches.dpdk.org/project/dpdk/list/?series=6715 > > drivers/net/octeontx2/otx2_ethdev.c | 1 + > drivers/net/octeontx2/otx2_ethdev.h | 2 ++ > drivers/net/octeontx2/otx2_ethdev_devargs.c | 21 --------------------- > drivers/net/octeontx2/otx2_lookup.c | 15 +++++++++++++++ Remove following from doc/guides/nics/octeontx2.rst as well. - ``HW offload ptype parsing disable`` (default ``0``) Packet type parsing is HW offloaded by default and this feature may be toggled using ``ptype_disable`` ``devargs`` parameter. > 4 files changed, 18 insertions(+), 21 deletions(-) > > diff --git a/drivers/net/octeontx2/otx2_ethdev.c b/drivers/net/octeontx2/otx2_ethdev.c > index b84128fef..5ee0e382d 100644 > --- a/drivers/net/octeontx2/otx2_ethdev.c > +++ b/drivers/net/octeontx2/otx2_ethdev.c > @@ -1619,6 +1619,7 @@ static const struct eth_dev_ops otx2_eth_dev_ops = { > .dev_set_link_up = otx2_nix_dev_set_link_up, > .dev_set_link_down = otx2_nix_dev_set_link_down, > .dev_supported_ptypes_get = otx2_nix_supported_ptypes_get, > + .dev_supported_ptypes_set = otx2_nix_supported_ptypes_set, > .dev_reset = otx2_nix_dev_reset, > .stats_get = otx2_nix_dev_stats_get, > .stats_reset = otx2_nix_dev_stats_reset, > +int > +otx2_nix_supported_ptypes_set(struct rte_eth_dev *eth_dev, uint32_t ptype_mask) > +{ > + struct otx2_eth_dev *dev = otx2_eth_pmd_priv(eth_dev); > + > + if (!ptype_mask) > + dev->rx_offload_flags &= ~NIX_RX_OFFLOAD_PTYPE_F; > + else > + dev->rx_offload_flags |= NIX_RX_OFFLOAD_PTYPE_F; Prefer to have positive logic. if (ptype_mask) dev->rx_offload_flags |= NIX_RX_OFFLOAD_PTYPE_F; else dev->rx_offload_flags &= ~NIX_RX_OFFLOAD_PTYPE_F; > + > + otx2_eth_set_rx_function(eth_dev); > + > + return 0; > +} > + > /* > * +------------------ +------------------ + > * | | IL4 | IL3| IL2 | TU | L4 | L3 | L2 | > -- > 2.17.1 >