From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93882A04F0; Thu, 19 Dec 2019 11:35:04 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 964791BDFD; Thu, 19 Dec 2019 11:35:03 +0100 (CET) Received: from mail-io1-f68.google.com (mail-io1-f68.google.com [209.85.166.68]) by dpdk.org (Postfix) with ESMTP id 09EAA1252 for ; Thu, 19 Dec 2019 11:35:00 +0100 (CET) Received: by mail-io1-f68.google.com with SMTP id v18so5240494iol.2 for ; Thu, 19 Dec 2019 02:35:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yGDv4MjarjwEhKRIQw8NSpZT8n9YViJP+jZonfVAQe8=; b=Hsml58paBthmhIbL1oZ5bVLt801mv7Opo5m75uHRMN8oaBbo6cfsC7uVSRsSR+re1p MlmzR4y1HbOTcxPWcS9mAoq0V/gbTANtCs3wiDTRanv+iozjm2h0VaLXhbfg3wnxxECQ 01qLuQKA84DGMOJv9KnKKHZohH5T0IulRPV9AfA7SOuA55XgJltEJ4bUGQpX2BB1ggZt bho06okLIlZPdTr9Edp0YuAEEEd5cSwQChZ6vdyYIbVk7Eq/n0agXTf7f/MovhGiFpKn ukmPvaANaTeZKIuIUYr0lE+YQBEm+UsgAM1YjNvJ24OXaGWCTYQsPXUJ35mu6li5qrYD d7qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yGDv4MjarjwEhKRIQw8NSpZT8n9YViJP+jZonfVAQe8=; b=LnC06e90f0HTvX03QIoTYItZIMOnrda6LTgoSgh1fLzrowOojCqXC8j1z3GZ5Ry3Kz 6OWVvfvhgU+fFiAW+40gm/8v1gyXkMoYQgb98H+PktslO5lWZA1dzQaCjLgi1G6RyQmY iWnr+Gosji6aVrnD1xwEKzKAVmZmEtfuk9ikmaPl1116KQLceIqrFpbi222ZgMMSAfi4 i8gNvWRzJM+84yG7Him/fM+jId05u+ZwNMqBGYdC198O2xqf1/ZHS1eEuO6NFF4hqQub kCNDYlpQnIExopn3w7vYrp05XrPCDB/luWMA7TmrWMpTQfKEKJPdR9S8k7ygumajHuiP q7fA== X-Gm-Message-State: APjAAAXuE7stGfngFb1AAeIF4+/skszk9wHsfGZKDhcZrBZt1MaD4TlM 24dWXm1/aG4nDiovrXbM1qoN1R2T66gBx+shiSo= X-Google-Smtp-Source: APXvYqwGZMhPNu4B99XR2sJ2Mvnz7geVJMxeGESseJ/HPJjbQMdSezDPi7bQhvKWNJtNKixEdhCtpQu775iM8GAyClw= X-Received: by 2002:a02:b00c:: with SMTP id p12mr6505366jah.112.1576751700172; Thu, 19 Dec 2019 02:35:00 -0800 (PST) MIME-Version: 1.0 References: <20191208113413.2179329-1-jerinj@marvell.com> <2530549.bTtaOq4tWD@xps> In-Reply-To: <2530549.bTtaOq4tWD@xps> From: Jerin Jacob Date: Thu, 19 Dec 2019 16:04:43 +0530 Message-ID: To: Thomas Monjalon Cc: Jerin Jacob , dpdk-dev , David Marchand , Adrien Mazarguil Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/3] eal: introduce structure marker typedefs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Dec 11, 2019 at 4:16 AM Thomas Monjalon wrote: > > 08/12/2019 12:34, jerinj@marvell.com: > > From: Jerin Jacob > > > > Introduce EAL typedef for structure 1B, 2B, 4B, 8B alignment marking and > > a generic marker for a point in a structure. > > > > Signed-off-by: Jerin Jacob > > --- > > lib/librte_eal/common/include/rte_common.h | 12 ++++++++++++ > > Good idea, thanks. > > > +/** Generic marker for a point in a structure. */ > > I think "a point" may be replaced with "any place" or something else? Will fix it v2. > > > +__extension__ typedef void *RTE_MARKER[0]; > > Why do we need an extension? > If it is part of C11, we should use RTE_STD_C11 instead. Will fix it v2. > If it is another reason, we could create another meaningful EAL macro. > > >