From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A336D425EC; Wed, 20 Sep 2023 11:32:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5F701402DB; Wed, 20 Sep 2023 11:32:32 +0200 (CEST) Received: from mail-vk1-f180.google.com (mail-vk1-f180.google.com [209.85.221.180]) by mails.dpdk.org (Postfix) with ESMTP id D33554027B; Wed, 20 Sep 2023 11:32:31 +0200 (CEST) Received: by mail-vk1-f180.google.com with SMTP id 71dfb90a1353d-490cd6db592so2762094e0c.1; Wed, 20 Sep 2023 02:32:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695202351; x=1695807151; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=avXqwO9h4Hhe4yn/LgI9VP4ezPq75h3bNQ+3iLlu2+Y=; b=epm+80MzdsQpj77DTK2BX4HRlu5wEqu/JzSE7PwqaaOIS9ij+a89H2XQcYiS/y2V+H QnMTm6+DtksFv9CkQbtfdVKwTXj68poHXsYJGhsnQecwQfGXCfeIaq9BJrN5xDN11KIr leiKa+jy9E9sVbc4vG0kY01aoJlnd//P0catbD24hExSD6KcOhCqpBpws5ZpRabr2XV2 uzEZGKZzrBS8+aotosNDrM+JQ1AClamvtGds5WCjeVaG55xMXeGqotk+oq55Ytcb1rj5 Z3OD+S05PEwEIe9X1102hE3HuAgHFPtCDasTL22JcbAgOBf4xDOppr/pLZja/fJd4cl1 r6qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695202351; x=1695807151; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=avXqwO9h4Hhe4yn/LgI9VP4ezPq75h3bNQ+3iLlu2+Y=; b=qHTLkXeKJwf3WdUr/kHckCH+mxf3uqJ/qek7+3NSUf1eB/UgQ+aWAhyMleFINlXwV/ OaPxUiarZ3ahPf948yna45IVfd3CXBDYFBfpXco/06YzJpLa3+VnqIVLb/a/uu9wGGuu aG3dSb0z77Jthy9kYF/XYfmiKUJV2EymiKQEyP+ClwFEXWHo86h4VK9g27s9kxbuliPx 2MuJhNSr+H21wqDaymOItKAt3/yL5pyBAYrIP8NbDbTTVdwb7cbmL2RdBpwaxajTlH4L z/fFCMaR1Bo0J3ZLiefXFIVVyJOIR3waOnjXmFgEiPRykU/E8ME7kS6F1yM5iL8ncgtg z2qA== X-Gm-Message-State: AOJu0Yw6D0buwmPxi3DnV/iMLe3VvT0qaln/cAqyWiQyX3YYiHhPj/kU sZBXqGnDHVxMIZ+BB/HQsuS9vBth2fQ/X9jujNY= X-Google-Smtp-Source: AGHT+IFL9YYoxx9QZm2K66HIPruWilO70cRMRVPZV6kfbcpYpysPBt82NTM+8h+doA5/lcL3mv9K9LgYY2HLtMFHMG8= X-Received: by 2002:a1f:c6c5:0:b0:495:cac2:2532 with SMTP id w188-20020a1fc6c5000000b00495cac22532mr2065682vkf.8.1695202351009; Wed, 20 Sep 2023 02:32:31 -0700 (PDT) MIME-Version: 1.0 References: <20230616074041.159675-2-mattias.ronnblom@ericsson.com> <20230904130313.327809-1-mattias.ronnblom@ericsson.com> <20230904130313.327809-2-mattias.ronnblom@ericsson.com> In-Reply-To: From: Jerin Jacob Date: Wed, 20 Sep 2023 15:02:04 +0530 Message-ID: Subject: Re: [PATCH v3 1/3] lib: introduce dispatcher library To: "Naga Harish K, S V" Cc: "mattias.ronnblom" , "dev@dpdk.org" , Jerin Jacob , "techboard@dpdk.org" , "Van Haaren, Harry" , "hofors@lysator.liu.se" , "Nilsson, Peter" , Heng Wang , Pavan Nikhilesh , "Gujjar, Abhinandan S" , "Carrillo, Erik G" , Shijith Thotton , Hemant Agrawal , Sachin Saxena , Liang Ma , "Mccarthy, Peter" , "Yan, Zhirun" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Sep 18, 2023 at 5:26=E2=80=AFAM Naga Harish K, S V wrote: > > > > > -----Original Message----- > > From: Mattias R=C3=B6nnblom > > Sent: Monday, September 4, 2023 6:33 PM > > To: dev@dpdk.org > > Cc: Jerin Jacob ; techboard@dpdk.org; Van Haaren, > > Harry ; hofors@lysator.liu.se; Nilsson, Pet= er > > ; Heng Wang ; > > Naga Harish K, S V ; Pavan Nikhilesh > > ; Gujjar, Abhinandan S > > ; Carrillo, Erik G ; > > Shijith Thotton ; Hemant Agrawal > > ; Sachin Saxena ; > > Liang Ma ; Mccarthy, Peter > > ; Yan, Zhirun ; > > mattias.ronnblom > > Subject: [PATCH v3 1/3] lib: introduce dispatcher library > > > > The purpose of the dispatcher library is to help reduce coupling in an > > Eventdev-based DPDK application. > > > > In addition, the dispatcher also provides a convenient and flexible way= for the > > application to use service cores for application-level processing. > > > > Signed-off-by: Mattias R=C3=B6nnblom > > Tested-by: Peter Nilsson > > Reviewed-by: Heng Wang > > > > -- > > > > PATCH v3: > > o To underline its optional character and since it does not provide > > hardware abstraction, the event dispatcher is now a separate > > library. > > o Change name from rte_event_dispatcher -> rte_dispatcher, to make it > > shorter and to avoid the rte_event_* namespace. > > > > Rte_dispatcher is basically dispatching events but it feels like the name= does not convey that. > Also, it is like any other adapter service that can reside within the eve= ntdev directory. > > I can see some discussion in previous threads related to the placement of= the dispatcher library. > > It is an optional eventdev application service, not enforcing this progra= mming model to the application. > The documentation may need to be updated and mention that this is optiona= l. > > If any hardware comes up with the dispatcher feature, then this library m= ay need to be moved inside eventdev library later. I would like to follow YAGNI principle in eventdev library. Even if a HW comes(I assume not), the interface should not look like that. None of the HW will be comparing a bunch of function pointers and call the callback. So interface will look different for HW enablement. We need to model the API based on HW for device libraries and SW libraries based on CPU modeling dynamics. Also, There is no need to tie up this library/framework only event ]dev, other than using rte_event_dequeue() to pull packet it has no eventdev significance. The library scope if just pull the packet from a source and compare with in N number of matches and call respective process callback. The dispatcher source can rte_ethdev_rx_burst or ring.