From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B9477A0C43; Wed, 12 May 2021 10:44:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A00B24003F; Wed, 12 May 2021 10:44:26 +0200 (CEST) Received: from mail-il1-f172.google.com (mail-il1-f172.google.com [209.85.166.172]) by mails.dpdk.org (Postfix) with ESMTP id F13824003E for ; Wed, 12 May 2021 10:44:24 +0200 (CEST) Received: by mail-il1-f172.google.com with SMTP id w13so7388003ilv.11 for ; Wed, 12 May 2021 01:44:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=KZgSsUkiuj7TUdZWqP+43vshIU+UE4kW5foGi5lcB6s=; b=TxKIntwDgeznjbIKDX0SCDsPrBnYTXaXtyejWuGVvHg6zZD8UYCmE3TIsPAqvFM1Dn qljSTdBXVyb1AQ5sE6uHBmFSoEYWF1OjM7pM/N8f4arEIY/ub2hOy7ZKooXYhuNfRCJF WnXBKeM4DhKWd+0+9e6zzZUB5Ed4sHeUFt/keabe6jd5X57htLShwMkj1A8l7fXqAZVm iCNrNnFfmXpoDi5h3YYUtw3aMFdunMWAcb0iLOoi8irUz25NlA4HsX8V7Xvi3phQ1xtV V/X8jE5gKWw09/I35046cfSDqdm27uX6BZfNqEeUjSoZa+wxzavn07fc5RArDiYYJ8uc n2jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=KZgSsUkiuj7TUdZWqP+43vshIU+UE4kW5foGi5lcB6s=; b=WENAbf71NIiil7m60uTAYZfNCxafTANMVJgtajJH+F85CR0J5L19TJdlGz8s/aFwPi nSpCzVQO8nSaesHKtae0tzVyw4AaUiNCG3AQqQ/9q/tD68Ar8Ibk/gyq1f6SkWQRgRnn Rvu3JweXIO9/KNbJqBxJIZyFeurLA9pU2O25aQ1ZhnW6vlwbpgKOCgyjiZucezJCTX6r 2GQRV4Zo+K3Z7tzi6avToRGM8rD3H8gRpq/1oQrLVYfXYhjg8/jiftf5CQlLeWVfgiGA 7jUYOsB10yW4Q0aHVPHZJcKIfxnMQ0BJCVD9OCuz0nr48Hrs6zXbrRfmNcAS5wgJlHDy BqEw== X-Gm-Message-State: AOAM5332fUXIAYfSuxHU5nYxKskQl+66qHgxsltJ+thoBozC7PsKhbfg bya9RnltF4DR8Dn8rPZ15tagzxj5fUxOtcm04Og= X-Google-Smtp-Source: ABdhPJyDGh3vw5Mx77+WY5vaJy3SYRpwsy77Ba8O1IjJ88QoX7mdNXYgkDk1sRSSGEgRAKXXAtasrnWZqtyLPk8VtLc= X-Received: by 2002:a92:c26a:: with SMTP id h10mr29779587ild.294.1620809064249; Wed, 12 May 2021 01:44:24 -0700 (PDT) MIME-Version: 1.0 References: <1620808126-18876-1-git-send-email-fengchengwen@huawei.com> <1620808126-18876-2-git-send-email-fengchengwen@huawei.com> In-Reply-To: <1620808126-18876-2-git-send-email-fengchengwen@huawei.com> From: Jerin Jacob Date: Wed, 12 May 2021 14:14:08 +0530 Message-ID: To: Chengwen Feng , =?UTF-8?Q?Juraj_Linke=C5=A1?= Cc: Thomas Monjalon , Ferruh Yigit , dpdk-dev , Jerin Jacob , "Ruifeng Wang (Arm Technology China)" , Jan Viktorin , "Richardson, Bruce" , Honnappa Nagarahalli Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 1/2] config/arm: add non-SVE march for soc kunpeng930 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, May 12, 2021 at 2:01 PM Chengwen Feng wro= te: > > Currently, the soc_kunpeng930 declares '-march=3Darmv8.2-a+crypto+sve', > but some compiler doesn't recognize the march because it doesn't > support sve. Agree with the problem statement. + @Juraj Linke=C5=A1 > > This patch adds '-march=3Darmv8.2-a+crypto' before > '-march=3Darmv8.2-a+crypto+sve' so that: > 1. If compiler doesn't support '-march=3Darmv8.2-a+crypto+sve', then it > will fallback supports 'armv8.2-a+crypto'. > 2. If compiler supports '-march=3Darmv8.2-a+crypto+sve', then it will > compile SVE-related code. > > Fixes: 7cf32a22b240 ("config/arm: add Hisilicon kunpeng") > > Signed-off-by: Chengwen Feng > --- > config/arm/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/config/arm/meson.build b/config/arm/meson.build > index 3f34ec9..fe6c29b 100644 > --- a/config/arm/meson.build > +++ b/config/arm/meson.build > @@ -158,7 +158,7 @@ implementer_hisilicon =3D { > ] > }, > '0xd02': { > - 'machine_args': ['-march=3Darmv8.2-a+crypto+sve'], > + 'machine_args': ['-march=3Darmv8.2-a+crypto', '-march=3Darmv= 8.2-a+crypto+sve'], I think, this problem not specific to Kunpeng. I think, in order to have a generic solution, I think, we need to express something like [[armv8.2-a], [crypto], [sve]] or so in the code and any infra code can generate a working combination to avoid duplicating the combination manually in code and have some generic solution for all the platforms. i.e patch 1: Enable the infrastructure for auto probe based on compiler support= . patch 2: Fix existing machines including the Kunpeng. > 'flags': [ > ['RTE_MACHINE', '"Kunpeng 930"'], > ['RTE_ARM_FEATURE_ATOMICS', true], > -- > 2.8.1 >