From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5B1F9A0A0A; Fri, 22 Jan 2021 10:07:58 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 432F7140DF7; Fri, 22 Jan 2021 10:07:58 +0100 (CET) Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) by mails.dpdk.org (Postfix) with ESMTP id 612D9140DD3 for <dev@dpdk.org>; Fri, 22 Jan 2021 10:07:56 +0100 (CET) Received: by mail-io1-f54.google.com with SMTP id z22so9631506ioh.9 for <dev@dpdk.org>; Fri, 22 Jan 2021 01:07:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=/OZ9FFPTQLFut455c0oFDQuesZEXPyLNOKzDmIIN/eQ=; b=krvjzjNakv3DJ+K5F9tuZrlRxed1GmbfQZkri5LwJMcn5JJ5x/2+CwCxBXhyVG3Bso 2vkayFDWa05/qYkmnuc0RPBK6F+36UJoWCMCshHzaBPBnpCNrT/3SJG571oiNAjTWTkj JYrUylq5m9QFxAzUt5DXJRgc3r4cMYx5C/K8wyU8WtV+TuBqfywGPtG+eZGK3qWXwwHT zjGUaJdIwrMD2wgb2DTGTxLESjXenL9MD8vA0UY+c7mKVug6Uv5nkEp6lzofIQ51KxXt iWQRrHLtWzrnv5ogAMkw0Os5mOVIgfsIyiveTlGjwH+jRQ4flsBAd0M5DaXALzb7B4l7 pjhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=/OZ9FFPTQLFut455c0oFDQuesZEXPyLNOKzDmIIN/eQ=; b=acTMj0FSZflzddMVK4ruyw/kfEkvUg8uDfpRrf44gAtOjnXpRyafcEugKji4OXxeHT z661z/PoMz1fEWJDgq1anj1NyTyn997lrh9V9Ycl/mPWpsA8W9NKo9LT12y6xkR0eGOb MgiXydOZMa11DsQPNn1MBwWR3Y3KYJIivC5oKRb0lXYJGJcdZdm6+wUb5Q8R/F2hial7 t0GMA8fdex0ah4+XWp4QxSosYmkjklCwFemS0Zejm/xlpexfEh2LCn8cxMVyJbLYhfgh 29eUqeKnK/Km5NuUXKZMZHcbMG3Jf9SptvjAUKkhHByuES8KlqDkXRS+THr3MAVC2eSl tZjw== X-Gm-Message-State: AOAM531MI+0SCUon6vwybnnktTUmMYaCDckgUBowNQGlgQH7YvHFgFCo uu6PKS3qSaiJ85NXVquitUmTLNPL6oR9f/Xzku0= X-Google-Smtp-Source: ABdhPJwzTLdAdRxJ7/a2yWdkObkix6vamd1vku7DGAKcUTG3DjFF7jCiOHVZ1HYfYAX2guaYwh3SdDSATnCS7Q+59/c= X-Received: by 2002:a92:1508:: with SMTP id v8mr584076ilk.162.1611306475802; Fri, 22 Jan 2021 01:07:55 -0800 (PST) MIME-Version: 1.0 References: <1608724059-8562-1-git-send-email-juraj.linkes@pantheon.tech> <DBAPR08MB5814E779855E522ACCD27ADD98A20@DBAPR08MB5814.eurprd08.prod.outlook.com> <d8fea4d94d1346a1ac8017e5cd5cb5b6@pantheon.tech> <2025364.IVKG2jy1nW@thomas> In-Reply-To: <2025364.IVKG2jy1nW@thomas> From: Jerin Jacob <jerinjacobk@gmail.com> Date: Fri, 22 Jan 2021 14:37:39 +0530 Message-ID: <CALBAE1NQcB=9Yh5vTfYMVac8MWu3aWe9t=Eb=vi-aE51krW_dA@mail.gmail.com> To: Thomas Monjalon <thomas@monjalon.net> Cc: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>, =?UTF-8?Q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech>, "bruce.richardson@intel.com" <bruce.richardson@intel.com>, Ruifeng Wang <Ruifeng.Wang@arm.com>, Phil Yang <Phil.Yang@arm.com>, "vcchunga@amazon.com" <vcchunga@amazon.com>, Dharmik Thakkar <Dharmik.Thakkar@arm.com>, "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>, "Ajit Khaparde (ajit.khaparde@broadcom.com)" <ajit.khaparde@broadcom.com>, "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>, "aboyer@pensando.io" <aboyer@pensando.io>, "dev@dpdk.org" <dev@dpdk.org>, "lironh@marvell.com" <lironh@marvell.com>, "allain.legacy@windriver.com" <allain.legacy@windriver.com>, nd <nd@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v15 09/12] build: disable drivers in Arm builds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Fri, Jan 22, 2021 at 2:28 PM Thomas Monjalon <thomas@monjalon.net> wrote= : > > 22/01/2021 09:39, Juraj Linke=C5=A1: > > > > > > disabled drivers, similarly how the command line option works a= nd > > > > > > remove unneeded driver options ported from the old makefile > > > > > > system, since they don't work in the current Meson build system= . > > > > > > Add support for removing drivers for cross builds so that we ca= n > > > > > > disable them in cross files. > > > > > > > > > > Why disabling them? > > > > > If a driver is not supported it should disable itseld in its meso= n file. > > > > > > > > > > > > > This is helpful when building for an SoC where we don't want to bui= ld > > > > to build a driver, but the build machine actually supports the driv= er. > > > > I believe in this case the meson build system would find the > > > > dependencies and designate the driver to be build, but we don't wan= t to build > > > the driver for that SoC. > > > > > > > > There may be other reasons as well - Honnappa or others from the Ar= m > > > > community may shed more light on this. > > > IMO, the assumption should be everything compiles on all the platform= s. Hence, > > > the disables should be applied to the platforms where the drivers do = not > > > compile. > > If a driver does not compile, it can disable itself. > No need for a configuration. > > > Would it be okay to leave the disabled as they're in this commit and le= ave the updates to the plaform owners? Thomas, what do you think? > > I think this patch should not disable drivers but just add the infra to d= o it. IMO, If the SOC has "fixed" set of dpdk devices, probably better to have positive logic to enable only those in config file. I think, that will be portable and useful. IMO, We can have infrastructure code enable only specific drivers and config owners can later enable the required set. > >