From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 76882A04DB; Thu, 15 Oct 2020 16:26:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 327181E4EC; Thu, 15 Oct 2020 16:26:28 +0200 (CEST) Received: from mail-il1-f194.google.com (mail-il1-f194.google.com [209.85.166.194]) by dpdk.org (Postfix) with ESMTP id D33B11E4EA for ; Thu, 15 Oct 2020 16:26:25 +0200 (CEST) Received: by mail-il1-f194.google.com with SMTP id p9so4384894ilr.1 for ; Thu, 15 Oct 2020 07:26:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eQTwr8n2z6zUfO3QGV+JlsbYJTj72SEtVTX/AEupgS4=; b=RneMehyQiciifpDrTPWPcXfjCofR7g7uZ1f5e16dvtd/Js3a9Iy+Mh2SPH6nlSh/qU WSyjswprO4005uPPC9D2tOx5XFwcMO6Krl8yPRtbiN3z3RaeS8lxP4Ro+f0jShqM8kLt SJ58+AKm3QKH3U1Axj1bPnrgqqz+/mjErG6XL3/2xYqIrvLXEtZxNZ+eem7eBTQNvI6D CZUeJqjHXcBkqTfsiGQqceJL+MdFMIt6nzyv57P9fnLMZZzaqhgRiyWXBBy4MnWkk8JA tlpl+U00ja3mCmKgmwpIJsne8nYVwEMHPl6UzD4S02l39Gjj2zQOym4YgRv8e+fADsUi pbZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eQTwr8n2z6zUfO3QGV+JlsbYJTj72SEtVTX/AEupgS4=; b=tCp/CobO/JWeQvWYYwlH9aXnYmU7WtqWV+cG9DYK4kZpqTd8luW745hCi5eYyPlX+I l6REx1v7fB0e60gWk2lr7KkBItfe+YMtu/URwpPOSItn6hke6ePbnWRiXtEiEjES7RW8 I5pJ9arc2SpVUfTUb2fH890YzRpqYdPWVHWAXm/88K0tJkqmmVUra5CED5SPKiZZXaq0 zDiYLsA6Q3ZV+cRYWFmtuKo5H+fDra12agQj89VO82SiIVDU0Y9j4k69kEsIq5WAnKEy EKLeqKeDh+0+7IaBGqsTTTe7xiNbWENZh+fk5GnKCcmLLHHE7nh0kEVSveSQyXPS70dl VYDA== X-Gm-Message-State: AOAM533ZuG5Usby12kV2qN8wGQxtXekmb8OszFZB+mTZB0db0mzAhmkS y/uYgmMzhZRhP/5hIxAJ9FAhx3OMpAwXMTr7z8U= X-Google-Smtp-Source: ABdhPJzmvPxzQvl0BRA1suXPtoXmZXBYejAzKeJEBqK6vzc4dfEu45xJlVYp0lwp9L08d3wm6plUT3OPUN9qkTVCQVY= X-Received: by 2002:a05:6e02:11b4:: with SMTP id 20mr3380510ilj.271.1602771983986; Thu, 15 Oct 2020 07:26:23 -0700 (PDT) MIME-Version: 1.0 References: <1599843507-19970-2-git-send-email-timothy.mcdaniel@intel.com> <1602711375-10685-1-git-send-email-timothy.mcdaniel@intel.com> In-Reply-To: <1602711375-10685-1-git-send-email-timothy.mcdaniel@intel.com> From: Jerin Jacob Date: Thu, 15 Oct 2020 19:56:07 +0530 Message-ID: To: Timothy McDaniel Cc: dpdk-dev , Erik Gabriel Carrillo , Gage Eads , "Van Haaren, Harry" , Hemant Agrawal Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 0/2] Eventdev ABI changes for DLB/DLB2 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Oct 15, 2020 at 3:04 AM Timothy McDaniel wrote: > > This series implements the eventdev ABI changes required by > the DLB and DLB2 PMDs. This ABI change was announced in the > 20.08 release notes [1]. This patch was initially part of > the V1 DLB PMD patchset. Hi @McDaniel, Timothy , Following things missing in this patch set before it needs to merge: - Update doc/guides/rel_notes/release_20_11.rst for "API Changes" and/or "ABI Changes" section - Update doc/guides/rel_notes/deprecation.rst to remove the this patch specific depreciation note - Merge patch 1 and 2 to a single patch it has a compilation error if we build patch1 alone - Update the git commit to give more data on the combined patch. - rebase the patch to http://browse.dpdk.org/next/dpdk-next-eventdev/, it still git-am apply issues. After fixing the above, I will merge this RC1. Please send ASAP. > > The DLB hardware does not conform exactly to the eventdev interface. > 1) It has a limit on the number of queues that may be linked to a port. > 2) Some ports are further restricted to a maximum of 1 linked queue. > 3) It does not (currently) have the ability to carry the flow_id as part > of the event (QE) payload. > > Due to the above, we would like to propose the following enhancements. > > 1) Add new fields to the rte_event_dev_info struct. These fields allow > the device to advertise its capabilities so that applications can take > the appropriate actions based on those capabilities. > > 2) Add a new field to the rte_event_dev_config struct. This field allows > the application to specify how many of its ports are limited to a single > link, or will be used in single link mode. > > 3) Replace the dedicated implicit_release_disabled field with a bit field > of explicit port capabilities. The implicit_release_disable functionality > is assigned to one bit, and a port-is-single-link-only attribute is > assigned to another, with the remaining bits available for future > assignment. > > Note that it was requested that we split this app/test > changes out from the eventdev ABI patch. As a result, > neither of these patches will build without the other > also being applied. > > Major changes since V1: > Reworded commit message, as requested > Fixed errors reported by clang > > Testing showed no performance impact due to the flow_id template code > added to test app. > > [1] http://mails.dpdk.org/archives/dev/2020-August/177261.html > > > Timothy McDaniel (2): > eventdev: eventdev: express DLB/DLB2 PMD constraints > eventdev: update app and examples for new eventdev ABI > > > > Timothy McDaniel (2): > eventdev: eventdev: express DLB/DLB2 PMD constraints > eventdev: update app and examples for new eventdev ABI > > app/test-eventdev/evt_common.h | 11 ++++ > app/test-eventdev/test_order_atq.c | 28 ++++++--- > app/test-eventdev/test_order_common.c | 1 + > app/test-eventdev/test_order_queue.c | 29 +++++++--- > app/test/test_eventdev.c | 4 +- > drivers/event/dpaa/dpaa_eventdev.c | 3 +- > drivers/event/dpaa2/dpaa2_eventdev.c | 5 +- > drivers/event/dsw/dsw_evdev.c | 3 +- > drivers/event/octeontx/ssovf_evdev.c | 5 +- > drivers/event/octeontx2/otx2_evdev.c | 3 +- > drivers/event/opdl/opdl_evdev.c | 3 +- > drivers/event/skeleton/skeleton_eventdev.c | 5 +- > drivers/event/sw/sw_evdev.c | 8 ++- > drivers/event/sw/sw_evdev_selftest.c | 6 +- > .../eventdev_pipeline/pipeline_worker_generic.c | 6 +- > examples/eventdev_pipeline/pipeline_worker_tx.c | 1 + > examples/l2fwd-event/l2fwd_event_generic.c | 7 ++- > examples/l2fwd-event/l2fwd_event_internal_port.c | 6 +- > examples/l3fwd/l3fwd_event_generic.c | 7 ++- > examples/l3fwd/l3fwd_event_internal_port.c | 6 +- > lib/librte_eventdev/rte_event_eth_tx_adapter.c | 2 +- > lib/librte_eventdev/rte_eventdev.c | 66 +++++++++++++++++++--- > lib/librte_eventdev/rte_eventdev.h | 51 ++++++++++++++--- > lib/librte_eventdev/rte_eventdev_pmd_pci.h | 1 - > lib/librte_eventdev/rte_eventdev_trace.h | 7 ++- > lib/librte_eventdev/rte_eventdev_version.map | 4 +- > 26 files changed, 214 insertions(+), 64 deletions(-) > > -- > 2.6.4 >