From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91CB2A04B3; Tue, 28 Jan 2020 17:56:08 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6CD721D56D; Tue, 28 Jan 2020 17:56:08 +0100 (CET) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by dpdk.org (Postfix) with ESMTP id 20B761D564 for ; Tue, 28 Jan 2020 17:56:07 +0100 (CET) Received: by mail-io1-f67.google.com with SMTP id i11so15044367ioi.12 for ; Tue, 28 Jan 2020 08:56:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cvjijed4RzU/wZciDCgx2jpLF2spPaM2ar0nIDeb3s8=; b=UKc076LzVc8tV0M6bJ/deWcQazjVBM7/iqWkc63lHs64ndbjNpAqWxY7zAsDuFmVJj 0JzFOmjrcRzPPMKVV0nRD7iv8Qvj5keOKNGl+dEcj+9XRo3e4LiXaWYZlAr7usG4ARKb SvliKVoVM5/q7yMSkGtEiJBMZI4D5toStqXLMGRBv1qPD/CpOnHJ5N4vVXB2KQyZeVdR TmknbJkVcKjxMj57AQdtADWymbXFKe89cmQglo4F2VYfiWG5P3stqGc0TiOzzTbwvX2k vn6Dz+YSslcq/GnPvFpt22fcDqZC04Bd9M58tCaly0UOVk1vsGkroaDGyF1nSfthuPT0 Xvsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cvjijed4RzU/wZciDCgx2jpLF2spPaM2ar0nIDeb3s8=; b=E+/AAglYBWMRlxW4YKTNWqTOoDyQ2fMyOs2VIGYnstxtOts6MMZ7oTtw7ysvl6P8RV EYRAVdDXMdtmZiP60anBVG7V+MBviHSmg9p09g5Zzb94JdQs+t2Tn4diC2pXWjIkVkgX d2pz0gaPYfZ+VgiywFA0t0Ebv517Ace5dQwrrIqoPVoycZtbZI6FkRH8lDYBWKRpWCdG 22F04Hk7bsDvRLoCcwiU1SO2P46HfzUGxjRV4BMWTIYRn2T1VPN44ERlhz8nizZd+hq0 +pfUwHdxjpyBqR/c7Y3dP/dXFNBlTEOqRBgKDT/OUzrWit69vJ+ET7uJwUBJWDOodXIQ 8hUQ== X-Gm-Message-State: APjAAAXXSPmko0WdkCo0qmlXhOweDOOoOALvh/FWzm1Qt/26usHPEInu W4ivPjURixYcPL3aTXNZCV0GS7VmyDSYrqeWi/8= X-Google-Smtp-Source: APXvYqyGAupx/EdLnxnN6tc+TjUtkuFmLzOSgzCgcUrGjwIJ1T0q1j9fFxKz9dJhV/z2HVNnAPYQXSNHCxPV65oFcfw= X-Received: by 2002:a6b:c742:: with SMTP id x63mr17805982iof.162.1580230566266; Tue, 28 Jan 2020 08:56:06 -0800 (PST) MIME-Version: 1.0 References: <20200124153755.13939-1-bruce.richardson@intel.com> <20200124153755.13939-2-bruce.richardson@intel.com> In-Reply-To: <20200124153755.13939-2-bruce.richardson@intel.com> From: Jerin Jacob Date: Tue, 28 Jan 2020 22:25:50 +0530 Message-ID: To: Bruce Richardson Cc: dpdk-dev , Jerin Jacob Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/2] net/octeontx2: check compiler flag before use X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jan 24, 2020 at 9:10 PM Bruce Richardson wrote: > > Rather than assuming all compilers support the -flax-vector-extensions > flag, we should test this before using it, thereby potentially avoiding > warnings. > > Cc: jerinj@marvell.com > > Signed-off-by: Bruce Richardson Acked-by: Jerin Jacob > --- > drivers/net/octeontx2/meson.build | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/net/octeontx2/meson.build b/drivers/net/octeontx2/meson.build > index fad3076a3..bde19678f 100644 > --- a/drivers/net/octeontx2/meson.build > +++ b/drivers/net/octeontx2/meson.build > @@ -26,9 +26,7 @@ sources = files('otx2_rx.c', > > deps += ['bus_pci', 'common_octeontx2', 'mempool_octeontx2'] > > -cflags += ['-flax-vector-conversions'] > - > -extra_flags = [] > +extra_flags = ['-flax-vector-conversions'] > # This integrated controller runs only on a arm64 machine, remove 32bit warnings > if not dpdk_conf.get('RTE_ARCH_64') > extra_flags += ['-Wno-int-to-pointer-cast', '-Wno-pointer-to-int-cast'] > -- > 2.20.1 >