From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 89676A2F67 for ; Sat, 5 Oct 2019 18:23:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6D8D41C2E1; Sat, 5 Oct 2019 18:23:31 +0200 (CEST) Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by dpdk.org (Postfix) with ESMTP id 68D861C2DD for ; Sat, 5 Oct 2019 18:23:29 +0200 (CEST) Received: by mail-io1-f65.google.com with SMTP id b136so20068937iof.3 for ; Sat, 05 Oct 2019 09:23:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vPg2Fi7Bznay123p7A8uXBr3GlaPZBU1DpPNU5KWyIo=; b=SKGQ2umK7zWOFpu+Wb4FBQWh/6vNteGjT7E404EPflC0LKCu/Y2x3S0zYgYb4P6K5W abPhJGjYt6TrrqUqpU5mK40sXLmRDMH+1zK/qePJttDBUDpYXgjsq6uiIvOcZ0pmgBug YShjT0PuAlmlthmyDRpxIrrYmvRyj2bzUS45E1CHWchpQOB7dTxssstfii+mJPsd97/f 13AvUU47D74GS3E2yNwK5bMA0aiiAueLBDpDd3LlhrDJBx4g9SmKOwAqThHyEFTKX/mY VYCG9Z4TTDXQ7XUOkGD+RuR65d3h/oQhs05NOUTu0I6MYLL7921f4hSMfoijzBM/BNOf ycJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vPg2Fi7Bznay123p7A8uXBr3GlaPZBU1DpPNU5KWyIo=; b=sX/I5enVk24tXMHI3wKJhVblNlDQhGLz3e54zUtRZexBqGCbL0isG9hWFEOnS4SrjB Qrux4GZYEvZIMDTMY0x8/9EOmhJY1VE7mIFBW5tLXP8CYkCBXdVp9AGfQqQB9RoJJc2k UnZYKwDgRCIp7qTEmh12Bj5wbsgkKqJyHSNkge0RGJyqVMfK9VrCHJzEAbDcppPpFRao nGBtKR1mu3TQ830GgQE31Zxe/uu5BlYJBpQNAFE5WMw7ae5eoY2QDUKUP5XedupfQghw dMNjPnO6FzUs2AeKjIZfqXC0h4o3HdCnNVwk/Mz1wsSaXYTiIoTAfxW5m5F+zFp7iJ5b zXeQ== X-Gm-Message-State: APjAAAUuR7bkD/B4B/TILLNjD1Pe6b2yrUjXL5mrN7o903AsxTU5qcjA Lb5A2qQ4k9cpIpdxAwEFaNa0wqLrl64bkuxviDM= X-Google-Smtp-Source: APXvYqyvjA1ZQTbZADxWAN03o+mgufhh2ywyy3g4E5d8JpwCnxlBQQ6GdGfc0YhhaxsSrE2T7+JpzLxr1ase11Mo0b0= X-Received: by 2002:a6b:6c15:: with SMTP id a21mr4429167ioh.60.1570292608444; Sat, 05 Oct 2019 09:23:28 -0700 (PDT) MIME-Version: 1.0 References: <20191001064641.28404-1-nipun.gupta@nxp.com> <20191004104748.13803-1-nipun.gupta@nxp.com> In-Reply-To: <20191004104748.13803-1-nipun.gupta@nxp.com> From: Jerin Jacob Date: Sat, 5 Oct 2019 21:53:17 +0530 Message-ID: To: Nipun Gupta Cc: dpdk-dev , Jerin Jacob , aconole@redhat.com, Pavan Nikhilesh , Sunil Kumar Kori , Hemant Agrawal , "Richardson, Bruce" , Marko Kovacevic , Ori Kam , Radu Nicolau , Tomasz Kantecki , "Van Haaren, Harry" , "Rao, Nikhil" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3] eventdev: flag to identify same destined packets enqueue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 4, 2019 at 4:33 PM Nipun Gupta wrote: > > This patch introduces a `flag` in the Eth TX adapter enqueue API. > Some drivers may support burst functionality only with the packets > having same destination device and queue. > > The flag `RTE_EVENT_ETH_TX_ADAPTER_ENQUEUE_SAME_DEST` can be used > to indicate this so the underlying driver, for drivers to utilize > burst functionality appropriately. > > Signed-off-by: Nipun Gupta > --- > > Changes in v3: > - remove flag from internal txa_enqueue_same_dest internal API > - ABI version update in makefile, meson and rel_notes > - Few comments update > > Changes in v2: > - have separate internal API in tx adapter for sending burst packets to > same eth dev, queue pair on the basis of the passed flag > - fix compilation of examples/eventdev_pipeline/ > event.queue_id = qid; /* event queue linked to adapter port */ > diff --git a/doc/guides/rel_notes/release_19_11.rst b/doc/guides/rel_notes/release_19_11.rst > index 27cfbd9e3..e589e020e 100644 > --- a/doc/guides/rel_notes/release_19_11.rst > +++ b/doc/guides/rel_notes/release_19_11.rst > @@ -146,7 +146,7 @@ The libraries prepended with a plus sign were incremented in this version. > librte_eal.so.11 > librte_efd.so.1 > librte_ethdev.so.12 > - librte_eventdev.so.7 > + librte_eventdev.so.8 > librte_flow_classify.so.1 > librte_gro.so.1 > librte_gso.so.1 Forgot to update "API Changes" section in doc/guides/rel_notes/release_19_11.rst > +static uint16_t > +rte_event_tx_adapter_enqueue_same_dest(__rte_unused void *port, > + __rte_unused struct rte_event ev[], > + __rte_unused uint16_t nb_events) > +{ > + rte_errno = ENOTSUP; > + return 0; > +} > + > struct rte_eventdev * > rte_event_pmd_allocate(const char *name, int socket_id) > { > @@ -1351,6 +1360,8 @@ rte_event_pmd_allocate(const char *name, int socket_id) > eventdev = &rte_eventdevs[dev_id]; > > eventdev->txa_enqueue = rte_event_tx_adapter_enqueue; > + eventdev->txa_enqueue_same_dest = > + rte_event_tx_adapter_enqueue_same_dest; We may not need to add new rte_event_tx_adapter_enqueue_same_dest function as it is same as rte_event_tx_adapter_enqueue() and can simply assign txa_enqueue_same_dest as rte_event_tx_adapter_enqueue. No strong opinion on this. With the above changes: Acked-by: Jerin Jacob I wait for a week for any review comments, If none, I will merge your next revision.