From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BF13542FB8; Wed, 2 Aug 2023 18:17:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A468440DDB; Wed, 2 Aug 2023 18:17:57 +0200 (CEST) Received: from mail-vk1-f182.google.com (mail-vk1-f182.google.com [209.85.221.182]) by mails.dpdk.org (Postfix) with ESMTP id 654A04021D for ; Wed, 2 Aug 2023 18:17:56 +0200 (CEST) Received: by mail-vk1-f182.google.com with SMTP id 71dfb90a1353d-47ec8c9d7a0so2814149e0c.3 for ; Wed, 02 Aug 2023 09:17:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690993076; x=1691597876; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=I33nMr3WhJG5ALjI+sHHG/HJi6zwe9f+Mpd6II3b0lA=; b=MHrdlkAIDQArH43swiHzgbXGTfr5xkQ7IfHcTLVzEOZA4jQKQGHE079s6oRqzoxFcC iya8Ii8GAbLB/Ojeq/ggUkVexCQWyeyWDjMhuYR9WdC63WBPZhT75Ebel1B7VBSnFAxG PPW9xXgmwJVlmFMFVvbDhZXhJFxx0mOAJnfv1kFy/m76mva0lPC9mCG9ObL+RR5IKNH0 MRs4YBIF/7TFSFusnRjdmo+IDT8hQTyj5xbAtBILpjwNNFT2fWkkQAln+QQTInmwcIOC i91S0Hr4vqw+G8/WMLW23Z4mV7+qhxeKAEMtE1WLMTI7JN5HoLLiL7CdQowJTgJAn/O8 27AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690993076; x=1691597876; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I33nMr3WhJG5ALjI+sHHG/HJi6zwe9f+Mpd6II3b0lA=; b=cvxrMJPJyb+VFLX8jMe5h20JJHwopGZYNnH16EkwibTw9be0VMpI18cskumOM9yr7A 773aPJN0pUXZv0gVTtIOR5oFUPYxAce2m30WvWBK54efkg8uL9XxwslpwsiroISzmrgX CEW98M7HbE+Xvo2NO5kfGWjQEG9WfSWAyzrFA5G47yw0sK6MK4v+xJTzofmJJtMcWunR SQvMeqd9oVFnsD6s1w7emkOOTV/C+3Cbe1vLUL+J0Ppe1n+SF1t2rCPFNMKsi/ceXspr 9XFJkKny0E0Gyfo7EjGCeAUrVdqFET83sdP4+NPwMe9pmfHMjjvRdoz+S53dZHlsIStT opLw== X-Gm-Message-State: ABy/qLaWBBavqomu4f+evh1nZXH25dryaSe2FP+D4q4MY+VJk46cgSPT 60bknN8ZGrZa5MzRfW55GoztdPwoLG8XkxY4aIY= X-Google-Smtp-Source: APBJJlEtq6iT9NJKTmAK61a27XU+IicPXnf++6vJKikEZxA1KRIEhxLZZpuwGfG9aPSgurWlvlpwHaeV6rX5svJIVag= X-Received: by 2002:a1f:c192:0:b0:483:9adf:af19 with SMTP id r140-20020a1fc192000000b004839adfaf19mr5264208vkf.2.1690993075716; Wed, 02 Aug 2023 09:17:55 -0700 (PDT) MIME-Version: 1.0 References: <20230801054457.1184208-1-ganapati.kundapura@intel.com> In-Reply-To: <20230801054457.1184208-1-ganapati.kundapura@intel.com> From: Jerin Jacob Date: Wed, 2 Aug 2023 21:47:29 +0530 Message-ID: Subject: Re: [PATCH v1] eventdev/crypto: flush ops when circ buffer is full To: Ganapati Kundapura Cc: jerinj@marvell.com, jay.jayatheerthan@intel.com, s.v.naga.harish.k@intel.com, abhinandan.gujjar@intel.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Aug 1, 2023 at 11:15=E2=80=AFAM Ganapati Kundapura wrote: > > crypto ops from the circ buffer are not getting flushed > to crypto dev when crypto dev becomes busy and circ buffer > gets full. > > This patch flushes ops from circ buffer when circ buffer is full > instead of returning without flushing. Since it is bug, Please add Fixes: tag , Also change description accordingl= y. > Signed-off-by: Ganapati Kundapura > > diff --git a/lib/eventdev/rte_event_crypto_adapter.c b/lib/eventdev/rte_e= vent_crypto_adapter.c > index 52a28e5..1b435c9 100644 > --- a/lib/eventdev/rte_event_crypto_adapter.c > +++ b/lib/eventdev/rte_event_crypto_adapter.c > @@ -248,9 +248,18 @@ eca_circular_buffer_flush_to_cdev(struct crypto_ops_= circular_buffer *bufp, > n =3D *tailp - *headp; > else if (*tailp < *headp) > n =3D bufp->size - *headp; > - else { > - *nb_ops_flushed =3D 0; > - return 0; /* buffer empty */ > + else { /* head =3D=3D tail case */ > + /* when head =3D=3D tail, > + * circ buff is either full(tail pointer roll over) or em= pty > + */ > + if (bufp->count !=3D 0) { > + /* circ buffer is full */ > + n =3D bufp->count; > + } else { > + /* circ buffer is empty */ > + *nb_ops_flushed =3D 0; > + return 0; /* buffer empty */ > + } > } > > *nb_ops_flushed =3D rte_cryptodev_enqueue_burst(cdev_id, qp_id, > -- > 2.6.4 >