From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id D3D24A0A0A;
Thu, 3 Jun 2021 10:41:34 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 7A481410E1;
Thu, 3 Jun 2021 10:41:34 +0200 (CEST)
Received: from mail-il1-f170.google.com (mail-il1-f170.google.com
[209.85.166.170])
by mails.dpdk.org (Postfix) with ESMTP id D69EA40689
for <dev@dpdk.org>; Thu, 3 Jun 2021 10:41:32 +0200 (CEST)
Received: by mail-il1-f170.google.com with SMTP id b5so4771831ilc.12
for <dev@dpdk.org>; Thu, 03 Jun 2021 01:41:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=mime-version:references:in-reply-to:from:date:message-id:subject:to
:cc; bh=4GTHuMjXdEOsSjVlX1oWqWoqsueU7e/1KFMIEAsNy70=;
b=bXzpgiXwzJgM0y0lWcSXRz8qnXQBi9Fa6M3Jcil5NR0IN49KY+lCmhjK7j7o6DEWLf
ocSaMVpzkfhbe6ro/zmzTD0h1NiJbPIxbihQOGuYBzbiHjxWxeGocXmbWW53D5myTbVL
IUD/EKOIMyNF3W5FPJW48DDA9lao5EUCileyrwIwgAiktGFzldPvC+h0GhJgh3eS+v7p
JO6L0O67sJAWaCQhPKrNSTJIOrZJSBf++snyt8V0QDVBBc7TELtwwuIx455kW3I1V1Sl
0q1lz7xguof0PNPV9DuFf43ZmCKtFNd/HS05h/hvMB95zJHF4QMdGA6Ajy1Mnv2RJKc2
t++g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=4GTHuMjXdEOsSjVlX1oWqWoqsueU7e/1KFMIEAsNy70=;
b=kvuOvqA1r1xPet25hTXM3knbtF0kFM9PM8/T8jMi8qoZQbE3JeOaj3XJEHI+FplRDe
3+IliCblZvjlkX7grt5+D76UEkQRbyfvn20CpsPGDOT9+Z3o4T8NSz8geVooejNrieUf
Uidcfb1iKdk1xP8p9p1XcU8YTiwlnl9okQOELUSoM5evUNI1M8zOT4hTWsEa4LFKy+rt
8ppGc+cjan0YjbNgn9uMzqiQ7fIdPFY2JGLXzhOoB4dnWU4wdUFvUgJjgpDPSUHrZE/O
RoAqyHujJ3yhFmF5Y46PmvY6FpkOhkleeRk0swR8Ui9Y2BbT/pY5JcGBhWx9oUikNbkn
CPDA==
X-Gm-Message-State: AOAM533mIccE9ZgC25KAMfrDUBgAOr4b35vegK5+ykxm59ixog4mhdth
c1J7ZYhVXMcA6ZMt0aYRY6A0s2yAYBnNIOX3uXY=
X-Google-Smtp-Source: ABdhPJwMZr2W+94e48eo1Znv/XglRqZpM3kKUyYyvxzv4PqcqxiVuYkgdMiNaArpGnn++aw08C7jIB5eiQia1o+xeYM=
X-Received: by 2002:a92:1310:: with SMTP id 16mr2510746ilt.60.1622709692213;
Thu, 03 Jun 2021 01:41:32 -0700 (PDT)
MIME-Version: 1.0
References: <20210602203531.2288645-1-thomas@monjalon.net>
<CALBAE1N9B+Z63+XCbbFRa+HZu1rinXkcwMVsWh19UkREvr8XXA@mail.gmail.com>
<2066767.2bDh9DmJd4@thomas>
In-Reply-To: <2066767.2bDh9DmJd4@thomas>
From: Jerin Jacob <jerinjacobk@gmail.com>
Date: Thu, 3 Jun 2021 14:11:16 +0530
Message-ID: <CALBAE1NYMXEZN3BUsXrupEADJEXkGDmyPK3kCd5xjozXqSEdpw@mail.gmail.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dpdk-dev <dev@dpdk.org>, Elena Agostini <eagostini@nvidia.com>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH] gpudev: introduce memory API
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Thu, Jun 3, 2021 at 1:58 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 03/06/2021 09:47, Jerin Jacob:
> > On Thu, Jun 3, 2021 at 2:05 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> > > --- a/doc/api/doxy-api-index.md
> > > +++ b/doc/api/doxy-api-index.md
> > > @@ -21,6 +21,7 @@ The public API headers are grouped by topics:
> > > [compressdev] (@ref rte_compressdev.h),
> > > [compress] (@ref rte_comp.h),
> > > [regexdev] (@ref rte_regexdev.h),
> > > + [gpudev] (@ref rte_gpudev.h),
> >
> > Since this device does not have a queue etc? Shouldn't make it a
> > library like mempool with vendor-defined ops?
> > Any specific reason for making it a device? The reason why I am asking
> > this is, as other DPDK devices as symmetry in queue(s), configure,
> > start, stop operation etc.
> >
> >
> > > +
> > > +struct rte_gpu_dev {
> > > + /* Backing device. */
> > > + struct rte_device *device;
> >
> > See above?
>
> There is a PCI device probed.
> I don't understand why it would not be represented as a device.
All other DPDK device has symmetry in structures like queue and
symmetry in operation like it has configure, start, stop etc.
This one seems more like mempool to me all we want set of
vendor-defined ops. So any justification on
make it a device ? why not like mempool library?
(driver/mempool/octeontx2 Mempool HW is also PCI device, but
we don't take device path for mempool. So I would like to understand
any technical reason for making it a device).
>
>