From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 97C46A04AF; Mon, 4 May 2020 08:12:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 24E8D1D409; Mon, 4 May 2020 08:12:45 +0200 (CEST) Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by dpdk.org (Postfix) with ESMTP id 734491BE81 for ; Mon, 4 May 2020 08:12:43 +0200 (CEST) Received: by mail-io1-f66.google.com with SMTP id y26so11113178ioj.2 for ; Sun, 03 May 2020 23:12:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iQgUY8tf4xp/4kOBrITOeY8zizxRXawOAof+/HuEtVI=; b=VHfRuVdlXa4j6VGC9myT7WcLolXRndZl34t5PS6j3zwwPi/4hXYwt+MzIlljoryi3C Wb9e3FEH9I9tDsNWDy8mPZ8BLv1lB6N4L2sKNcYWZpstt57wVZcsR68i+FYSEThQhv6G sihlStZ/XUJpL/x3AGdE6umU8e69JmY/ifAecmaT2UJWSlxhZMQxE5UVw7WEbEclWpld a1xmI7kYvd9e4hqotZjozlgkxpnwUgtVaS7qJFNv4BxESfd1UeZk8QL236fZsWGrqJQ+ 90HDjCMfg2mP2xkp+2gmpask6UbcZnNpk/gpAVD0RCScYAVG9xITvOH7GqOm4FC3t5aM WZ9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iQgUY8tf4xp/4kOBrITOeY8zizxRXawOAof+/HuEtVI=; b=VRAG7/FN6z+WP0kUJcc+q/mdQSpmexmeLTQu777ZoPYIhBG2lYZdeOvJKSaf7sbGxa EMiY9C9yQcYVwqqmpoaNU4g76kfbD99VczhMEh+wEd3/2lKv1PvdIhlvRN3v1wKMCTaw mMBRQed5pb71DL0zuukZIXTINGgXqar0mlKY1MEBdLnDzwBiNmN+FaLHYcnmzXXY4+7k UHHBDuvtXer4AC6c2pwI7DKF3clFpqEkNOxNSL2wsZcqBMEsQNtJLSPzem35tdh8btV0 /goysSDaNFBoLEaEAL0f96cS6K36jISZFEr4a/8k6c3V7StVM+4jie8MrXaakAI9N9pF c/3Q== X-Gm-Message-State: AGi0PuZHtdcyXJNTsOH4z+3VaXu/OmDwRp4dUVfR2SQNxwOP0+VLx1Ff DhzVwDm7uxWrBGXG3FP/JNPUI6S1lcNNRExs0Kc= X-Google-Smtp-Source: APiQypKkZed9GkMiy20l5f3tcvJDFdEUo8mfn4XP0DCkHT6PXKkXlQPqO2CmNq5fKV6aJ3c6EZCpOuc2AUevF0gAvT8= X-Received: by 2002:a05:6638:2a2:: with SMTP id d2mr13967014jaq.104.1588572762487; Sun, 03 May 2020 23:12:42 -0700 (PDT) MIME-Version: 1.0 References: <20200503203135.6493-1-david.marchand@redhat.com> <20200503203135.6493-4-david.marchand@redhat.com> In-Reply-To: <20200503203135.6493-4-david.marchand@redhat.com> From: Jerin Jacob Date: Mon, 4 May 2020 11:42:26 +0530 Message-ID: To: David Marchand Cc: dpdk-dev , Thomas Monjalon , Jerin Jacob , Sunil Kumar Kori , John McNamara , Marko Kovacevic , Declan Doherty , Ferruh Yigit , Andrew Rybchenko , Olivier Matz Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 3/8] trace: simplify trace point headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, May 4, 2020 at 2:02 AM David Marchand wrote: > > Invert the current trace point headers logic by making > rte_trace_point_register.h include rte_trace_point.h. > > There is no more need for a RTE_TRACE_POINT_REGISTER_SELECT special macro > since including rte_trace_point_register.h itself means we want to > register trace points. > > The unexplained "provider" notion is removed from the documentation and > rte_trace_point_provider.h is merged into rte_trace_point.h. > > Signed-off-by: David Marchand > > @@ -271,13 +258,128 @@ __rte_experimental > int __rte_trace_point_register(rte_trace_point_t *trace, const char *name, > void (*register_fn)(void)); > > -#ifdef RTE_TRACE_POINT_REGISTER_SELECT > -#include > +#ifndef __DOXYGEN__ > + > +#ifndef _RTE_TRACE_POINT_REGISTER_H_ > +#ifdef ALLOW_EXPERIMENTAL_API > + > +#include > +#include > +#include > +#include > +#include I think, we can move this header file to the beginning of the file. > > -#ifndef __DOXYGEN__ > +#define __rte_trace_point_emit_header_generic(t) RTE_SET_USED(t) > +#define __rte_trace_point_emit_header_fp(t) RTE_SET_USED(t) > +#define __rte_trace_point_emit(in, type) RTE_SET_USED(in) > +#define rte_trace_point_emit_string(in) RTE_SET_USED(in) > + > +#endif /* ALLOW_EXPERIMENTAL_API */ > +#endif Please add / *_RTE_TRACE_POINT_REGISTER_H_ */ for this endif Please fix the below checkpatch warnings. 1) WARNING:LONG_LINE: line over 80 characters #449: FILE: lib/librte_eal/include/rte_trace_point_register.h:9: +#error for tracepoint registration, include this file first before 2) WARNING:LONG_LINE: line over 80 characters #237: FILE: lib/librte_eal/include/rte_trace_point.h:337: + (__RTE_TRACE_EVENT_HEADER_ID_SHIFT - __RTE_TRACE_FIELD_ID_SHIFT)); With the above change, Acked-by: Jerin Jacob