From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 26147A32A4 for ; Fri, 25 Oct 2019 15:39:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B6C341C1F8; Fri, 25 Oct 2019 15:39:21 +0200 (CEST) Received: from mail-il1-f196.google.com (mail-il1-f196.google.com [209.85.166.196]) by dpdk.org (Postfix) with ESMTP id 1BA511C1F5 for ; Fri, 25 Oct 2019 15:39:21 +0200 (CEST) Received: by mail-il1-f196.google.com with SMTP id t5so1847095ilh.10 for ; Fri, 25 Oct 2019 06:39:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Li2yxMkYw0R44941TUCeLPWQ14E0QY16c6FdLLerDP0=; b=D/15Se/uGwrQXqIIQavuSB5iMaod+WkyZY6FtNBXDGtyU69eSh2TUh47vsuDQzNm8X u9Uuz+H3oVaJBW7USjRz9m2mCDcqQb/6UZUMFxM+N/G+wqi6ElBL8VDt9t9mcWmkW9ps hexPIT4xUxEavOMfScfOSvK9FBb2gT2C7siuUb/Rj2he175xBzk0c0I0CS5ZmvjdEcaM M6ErBmn8HPG9ELbDbkuYrF6+3Hg4TwxKuyqTB6InyXL6OVFICvOcj3owXEvgOMpedVnb m5CpZtmQvk0NTDLHofbvtqQpdS3JflbBMoiyaGCEJzNf2VkPl+mJn0PDOf+B9FFXC3+8 KslQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Li2yxMkYw0R44941TUCeLPWQ14E0QY16c6FdLLerDP0=; b=SCCzzZXnAXGw3+UeLiV9FM244eIWxxn7iPZLMY5ukXvxqEGOo3/yMaE24+raDzC+CA 0jtSiBYYx6XUeI7cd80OIbeIXyYG36PjZzrNXm71vJhoE0dQ4l8ppfAuXWaWeErRjfiy 0a6zU92lUnh8eePYKDUyXKc5ihD+e/OL1RC1QN9Fa0KkFjNXIAlE2qN2dyCV62DOzMhT xk35skDTTKRrSI2+SaK3VrSa8pt2BtB1E4+XC/9pMK8L5+6xSX02iNHBVgvqG6ZTbEIs 5+STxZZAv3c5HffpyEI5tyjcC5/SrUlf1XwjwGARJwvop3LbvWsmV/374OTue7wVWlx6 O5Bg== X-Gm-Message-State: APjAAAXYyb2VG6SxME5iPU6vZwjvQMqE3Ns6Y8ZTNzYol9LfCzNqtEjO RXsj0+5JxcAjiiPjSXJLhYpEqwxhS4kzrtQDupA= X-Google-Smtp-Source: APXvYqyWGd5IISOl6DK28d29b9ZA9DBiwBJrRw0sAZB2+S0JdhtW0s21LK1H72BvkrOOjkRh/LEsZIxrORJ5/69FuDc= X-Received: by 2002:a92:d78f:: with SMTP id d15mr1956782iln.294.1572010760201; Fri, 25 Oct 2019 06:39:20 -0700 (PDT) MIME-Version: 1.0 References: <20191025125118.47189-1-ferruh.yigit@intel.com> <20191025125118.47189-2-ferruh.yigit@intel.com> <5258375.BrpvpaGT02@xps> In-Reply-To: <5258375.BrpvpaGT02@xps> From: Jerin Jacob Date: Fri, 25 Oct 2019 19:09:04 +0530 Message-ID: To: Thomas Monjalon Cc: Ferruh Yigit , John McNamara , Marko Kovacevic , dpdk-dev , Andrew Rybchenko , Adrien Mazarguil , Ajit Khaparde , Jerin Jacob , Ori Kam Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 2/2] doc: remove flow API from the feature list X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 25, 2019 at 6:56 PM Thomas Monjalon wrote: > > 25/10/2019 14:51, Ferruh Yigit: > > "Flow API" is a method/API to implement various filtering features, on > > its own it doesn't give much context on what features are provided. And > > it is not really a feature, so doesn't fit into feature table. > > > > Also since other filtering related APIs, 'filter_ctrl', has been > > deprecated, flow API is the only supported way in the DPDK to implement > > filtering options, if related filter options announced by PMDs, listing > > "Flow API" as implemented is redundant information. > > I fully agree with this explanation. > rte_flow is the only supported API for flow offloads. > That's why we must remove the legacy API. > > > Signed-off-by: Ferruh Yigit > > --- > > --- a/doc/guides/nics/features/default.ini > > +++ b/doc/guides/nics/features/default.ini > > -Flow API = > > Acked-by: Thomas Monjalon # Need to remove "Flow API" from doc/guides/nics/features.rst # Need to remove refference of "Flow API" from "doc/guides/nics/*" as well. Not specific to this patch, Probably we need to add a new matrix to enumerate PATTERN and ACTIONS supported by each PMD as a rte_flow feature matrix. That some else can take it up if everyone agrees the semantics.