DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerinjacobk@gmail.com>
To: Michael Pfeiffer <michael.pfeiffer@tu-ilmenau.de>,
	 "Richardson, Bruce" <bruce.richardson@intel.com>
Cc: Jan Viktorin <viktorin@rehivetech.com>,
	Ruifeng Wang <ruifeng.wang@arm.com>,
	Jerin Jacob <jerinj@marvell.com>, dpdk-dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal: add include for rte_byteorder on ARM
Date: Sun, 6 Jun 2021 23:26:37 +0530
Message-ID: <CALBAE1N_XJqwA1ypCZ6bMq1edGjLefGc41SM4yUwyDoufWgcSw@mail.gmail.com> (raw)
In-Reply-To: <20210604114752.412856-1-michael.pfeiffer@tu-ilmenau.de>

On Fri, Jun 4, 2021 at 5:18 PM Michael Pfeiffer
<michael.pfeiffer@tu-ilmenau.de> wrote:
>
> Including rte_byteorder.h may fail for ARM builds with 'Platform must
> be built with RTE_FORCE_INTRINSICS' if rte_config.h is not included
> before. Include rte_config.h from rte_byteorder.h to solve the issue.
>
> Signed-off-by: Michael Pfeiffer <michael.pfeiffer@tu-ilmenau.de>

Since -include rte_config.h added by meson, This issue is not coming
with in tree build.
IMO, Fix is correct.

Please send v2 with
- Add Fixes: tag and Cc: stable@dpdk.org so that i can be backported
to stable tree.
- Fix following checkformat.sh warning

Wrong headline format:
        eal: add include for rte_byteorder on ARM
Wrong headline case:
                        "eal: add include for rte_byteorder on ARM": ARM --> Arm

- Subject could be "eal: arm: fix out of tree build" or so.

With above change:

Acked-by: Jerin Jacob <jerinj@marvell.com>



> ---
>  lib/eal/arm/include/rte_byteorder.h | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/lib/eal/arm/include/rte_byteorder.h b/lib/eal/arm/include/rte_byteorder.h
> index df2f1d87ba..1f90db9943 100644
> --- a/lib/eal/arm/include/rte_byteorder.h
> +++ b/lib/eal/arm/include/rte_byteorder.h
> @@ -5,18 +5,19 @@
>  #ifndef _RTE_BYTEORDER_ARM_H_
>  #define _RTE_BYTEORDER_ARM_H_
>
> -#ifndef RTE_FORCE_INTRINSICS
> -#  error Platform must be built with RTE_FORCE_INTRINSICS
> -#endif
> -
>  #ifdef __cplusplus
>  extern "C" {
>  #endif
>
>  #include <stdint.h>
>  #include <rte_common.h>
> +#include <rte_config.h>
>  #include "generic/rte_byteorder.h"
>
> +#ifndef RTE_FORCE_INTRINSICS
> +#  error Platform must be built with RTE_FORCE_INTRINSICS
> +#endif
> +
>  /* fix missing __builtin_bswap16 for gcc older then 4.8 */
>  #if !(__GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 8))
>
> --
> 2.31.1
>

  reply	other threads:[~2021-06-06 17:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-04 11:47 Michael Pfeiffer
2021-06-06 17:56 ` Jerin Jacob [this message]
2021-06-07  6:53   ` [dpdk-dev] [PATCH v3] eal: arm: fix out of tree build Michael Pfeiffer
2021-06-08  9:56     ` Ruifeng Wang
2021-06-08 10:29       ` [dpdk-dev] [PATCH v4] " Michael Pfeiffer
2021-06-09  7:27         ` Ruifeng Wang
2021-06-09 10:17           ` [dpdk-dev] [PATCH v5] " Michael Pfeiffer
2021-06-09 10:22             ` Ruifeng Wang
2021-06-09 11:43             ` Jerin Jacob
2021-06-11  9:54             ` [dpdk-dev] [dpdk-stable] " David Marchand
2021-06-11  9:59               ` Bruce Richardson
2021-06-11 10:27                 ` Michael Pfeiffer
2021-06-11 10:44                   ` Ruifeng Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALBAE1N_XJqwA1ypCZ6bMq1edGjLefGc41SM4yUwyDoufWgcSw@mail.gmail.com \
    --to=jerinjacobk@gmail.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=michael.pfeiffer@tu-ilmenau.de \
    --cc=ruifeng.wang@arm.com \
    --cc=viktorin@rehivetech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git