From: Jerin Jacob <jerinjacobk@gmail.com>
To: Rahul Bhansali <rbhansali@marvell.com>
Cc: dpdk-dev <dev@dpdk.org>,
Bruce Richardson <bruce.richardson@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@xilinx.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>,
Andrew Boyer <aboyer@pensando.io>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Beilei Xing <beilei.xing@intel.com>,
Chas Williams <chas3@att.com>,
"Xia, Chenbo" <chenbo.xia@intel.com>,
Ciara Loftus <ciara.loftus@intel.com>,
Devendra Singh Rawat <dsinghrawat@marvell.com>,
Ed Czeck <ed.czeck@atomicrules.com>,
Evgeny Schemeilin <evgenys@amazon.com>,
Gaetan Rivet <grive@u256.net>, Gagandeep Singh <g.singh@nxp.com>,
Guoyang Zhou <zhouguoyang@huawei.com>,
Haiyue Wang <haiyue.wang@intel.com>,
Harman Kalra <hkalra@marvell.com>,
heinrich.kuhn@corigine.com,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Hyong Youb Kim <hyonkim@cisco.com>,
Igor Chauskin <igorch@amazon.com>,
Igor Russkikh <irusskikh@marvell.com>,
Jakub Grajciar <jgrajcia@cisco.com>,
Jasvinder Singh <jasvinder.singh@intel.com>,
Jian Wang <jianwang@trustnetic.com>,
Jiawen Wu <jiawenwu@trustnetic.com>,
Jingjing Wu <jingjing.wu@intel.com>,
John Daley <johndale@cisco.com>,
John Miller <john.miller@atomicrules.com>,
"John W. Linville" <linville@tuxdriver.com>,
"Wiles, Keith" <keith.wiles@intel.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Lijun Ou <oulijun@huawei.com>, Liron Himi <lironh@marvell.com>,
Long Li <longli@microsoft.com>, Marcin Wojtas <mw@semihalf.com>,
Martin Spinler <spinler@cesnet.cz>,
Matan Azrad <matan@nvidia.com>,
Matt Peters <matt.peters@windriver.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
Michal Krawczyk <mk@semihalf.com>,
"Min Hu (Connor" <humin29@huawei.com>,
Pradeep Kumar Nalla <pnalla@marvell.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
Qiming Yang <qiming.yang@intel.com>,
Qi Zhang <qi.z.zhang@intel.com>,
Radha Mohan Chintakuntla <radhac@marvell.com>,
Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
Rasesh Mody <rmody@marvell.com>, Rosen Xu <rosen.xu@intel.com>,
Sachin Saxena <sachin.saxena@oss.nxp.com>,
Satha Koteswara Rao Kottidi <skoteshwar@marvell.com>,
Shahed Shaikh <shshaikh@marvell.com>,
Shai Brandes <shaibran@amazon.com>,
Shepard Siegel <shepard.siegel@atomicrules.com>,
Somalapuram Amaranath <asomalap@amd.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Steven Webster <steven.webster@windriver.com>,
Sunil Kumar Kori <skori@marvell.com>,
Tetsuya Mukawa <mtetsuyah@gmail.com>,
Veerasenareddy Burru <vburru@marvell.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Xiao Wang <xiao.w.wang@intel.com>,
Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>,
Yisen Zhuang <yisen.zhuang@huawei.com>,
Yong Wang <yongwang@vmware.com>,
Ziyang Xuan <xuanziyang2@huawei.com>
Subject: Re: [PATCH] examples/l2fwd: add check of Rx packets count
Date: Thu, 2 Jun 2022 13:18:49 +0530 [thread overview]
Message-ID: <CALBAE1NaDm_cTkbch4CNPiarnFHKqPZyyCVxq59UadaSuaPOEQ@mail.gmail.com> (raw)
In-Reply-To: <20220525091327.4006824-1-rbhansali@marvell.com>
On Wed, May 25, 2022 at 2:44 PM Rahul Bhansali <rbhansali@marvell.com> wrote:
>
> An additional check is added to avoid extra processing if
> receive packets are 0.
>
> Performance impact: with Marvell OCTEON TX2 platform, observed an
> improvement by ~14%.
>
> Signed-off-by: Rahul Bhansali <rbhansali@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
> ---
> examples/l2fwd/main.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c
> index 281c6b7a3f..28c498712e 100644
> --- a/examples/l2fwd/main.c
> +++ b/examples/l2fwd/main.c
> @@ -286,6 +286,9 @@ l2fwd_main_loop(void)
> nb_rx = rte_eth_rx_burst(portid, 0,
> pkts_burst, MAX_PKT_BURST);
>
> + if (unlikely(nb_rx == 0))
> + continue;
> +
> port_statistics[portid].rx += nb_rx;
>
> for (j = 0; j < nb_rx; j++) {
> --
> 2.25.1
>
next prev parent reply other threads:[~2022-06-02 7:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 9:13 Rahul Bhansali
2022-06-02 7:48 ` Jerin Jacob [this message]
2022-06-23 11:09 ` [EXT] " Rahul Bhansali
2022-06-26 21:12 ` Thomas Monjalon
2022-07-20 16:52 ` [EXT] " Rahul Bhansali
2022-09-14 10:34 ` Rahul Bhansali
2022-11-02 13:47 ` Rahul Bhansali
2022-11-02 15:29 ` Thomas Monjalon
2022-07-20 17:32 ` Stephen Hemminger
2022-11-02 14:09 ` Hemant Agrawal
2022-11-02 15:47 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1NaDm_cTkbch4CNPiarnFHKqPZyyCVxq59UadaSuaPOEQ@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=aboyer@pensando.io \
--cc=ajit.khaparde@broadcom.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=asomalap@amd.com \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=chas3@att.com \
--cc=chenbo.xia@intel.com \
--cc=ciara.loftus@intel.com \
--cc=cloud.wangxiaoyun@huawei.com \
--cc=dev@dpdk.org \
--cc=dsinghrawat@marvell.com \
--cc=ed.czeck@atomicrules.com \
--cc=evgenys@amazon.com \
--cc=ferruh.yigit@xilinx.com \
--cc=g.singh@nxp.com \
--cc=grive@u256.net \
--cc=haiyue.wang@intel.com \
--cc=heinrich.kuhn@corigine.com \
--cc=hemant.agrawal@nxp.com \
--cc=hkalra@marvell.com \
--cc=humin29@huawei.com \
--cc=hyonkim@cisco.com \
--cc=igorch@amazon.com \
--cc=irusskikh@marvell.com \
--cc=jasvinder.singh@intel.com \
--cc=jgrajcia@cisco.com \
--cc=jianwang@trustnetic.com \
--cc=jiawenwu@trustnetic.com \
--cc=jingjing.wu@intel.com \
--cc=john.miller@atomicrules.com \
--cc=johndale@cisco.com \
--cc=keith.wiles@intel.com \
--cc=kirankumark@marvell.com \
--cc=linville@tuxdriver.com \
--cc=lironh@marvell.com \
--cc=longli@microsoft.com \
--cc=matan@nvidia.com \
--cc=matt.peters@windriver.com \
--cc=maxime.coquelin@redhat.com \
--cc=mk@semihalf.com \
--cc=mtetsuyah@gmail.com \
--cc=mw@semihalf.com \
--cc=ndabilpuram@marvell.com \
--cc=oulijun@huawei.com \
--cc=pnalla@marvell.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=radhac@marvell.com \
--cc=rahul.lakkireddy@chelsio.com \
--cc=rbhansali@marvell.com \
--cc=rmody@marvell.com \
--cc=rosen.xu@intel.com \
--cc=sachin.saxena@oss.nxp.com \
--cc=shaibran@amazon.com \
--cc=shepard.siegel@atomicrules.com \
--cc=shshaikh@marvell.com \
--cc=skori@marvell.com \
--cc=skoteshwar@marvell.com \
--cc=somnath.kotur@broadcom.com \
--cc=spinler@cesnet.cz \
--cc=steven.webster@windriver.com \
--cc=sthemmin@microsoft.com \
--cc=thomas@monjalon.net \
--cc=vburru@marvell.com \
--cc=viacheslavo@nvidia.com \
--cc=xiao.w.wang@intel.com \
--cc=xuanziyang2@huawei.com \
--cc=yisen.zhuang@huawei.com \
--cc=yongwang@vmware.com \
--cc=zhouguoyang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).