From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 049E141B8A; Tue, 31 Jan 2023 09:15:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9380B40E28; Tue, 31 Jan 2023 09:15:23 +0100 (CET) Received: from mail-vk1-f170.google.com (mail-vk1-f170.google.com [209.85.221.170]) by mails.dpdk.org (Postfix) with ESMTP id 75F9440DFB for ; Tue, 31 Jan 2023 09:15:22 +0100 (CET) Received: by mail-vk1-f170.google.com with SMTP id v81so7003458vkv.5 for ; Tue, 31 Jan 2023 00:15:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=i/Tmb2vJnZCE3Ji+dV81vmAHjsH288tScCFCc7Gu0AY=; b=pB17EXDh0DaceSlcyaXzW18ryOY76vYy4ViHUlfHbjjDjHG8aV6z5iNuWCEWgk2MPS YMdydF5VZUPL+wpvuCvpXNWeUjDhyzHZlTyEuQCioDfOJ+MsXD+sPKol3woU1mILIh38 swU2m3zEISeZmAhG4PGdtXNnqpKzIQTVQMdebT3jaKaPaD3B35V00ALL+iEQKyfAlEek SGXQpEGOhSAOKh2BTpM5bqCMxkXyCPPleUjtpmb/gtLL4dh6PgBzc0Ge1TO6AhsZLcVe eROH56EETVDjbc47mvFIwC5dIiHAzhZd5N+1AK5FvbVrAgx9sY39wQ9btn/sCIg1ksHS FPDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=i/Tmb2vJnZCE3Ji+dV81vmAHjsH288tScCFCc7Gu0AY=; b=XtpTVLk7myuUePFBeOIjju6NRmFKE4q3+ZHhBdZgjtQz1z5vj+vvOUUO+1SnQrx1pU qj+iUYQNjMt6kR1DDOfiDI0Qvssg0RCQMITasq9miodnGlvuXLk7H97m+lVbR+jPb3ts SdbW1wIpXSWmARUm+EWfyC5MnQ24pn9v8sipUv//jpmX1ecGbXgemXpgCXHQ/ro03KhA S9g8gilupo5c12f+GekG9SQ9BoAFoIIR1Xhd3ofRcUgld+Khz/qZyE9cOUEwSlciXWEg SilPQ0tjaQrjCNlakwPsUn/60KcRxQypaUECeIK3nZ1hnLSBYpDuHDEZmauj8KZ8aH7F lfQw== X-Gm-Message-State: AO0yUKV6TcA6+S9WgncW6j4x9FlEuHMfpn2tKvKhgm/igE5fQWuCAeL2 Y6DP64DW7JgtKlH16DxKpTdF9uX0iTLDKzEJkBo= X-Google-Smtp-Source: AK7set/eMarN6fxbzu3kBztQlsvKXekWbcWVPP5QvUMBRw8TuOxjyXGsRLkV/5GN2kzu3sB9h9TOgiLm0NY1Z0FiaA8= X-Received: by 2002:a1f:20ca:0:b0:3ea:4be1:4a72 with SMTP id g193-20020a1f20ca000000b003ea4be14a72mr786797vkg.20.1675152921732; Tue, 31 Jan 2023 00:15:21 -0800 (PST) MIME-Version: 1.0 References: <20230112100106.2180665-1-amitprakashs@marvell.com> <20230124112139.1426279-1-amitprakashs@marvell.com> <20230124112139.1426279-3-amitprakashs@marvell.com> In-Reply-To: <20230124112139.1426279-3-amitprakashs@marvell.com> From: Jerin Jacob Date: Tue, 31 Jan 2023 13:44:55 +0530 Message-ID: Subject: Re: [PATCH v4 3/3] l3fwd-graph: changes to configure pcap capture To: Amit Prakash Shukla Cc: Jerin Jacob , Kiran Kumar K , Nithin Dabilpuram , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jan 24, 2023 at 4:53 PM Amit Prakash Shukla wrote: > > Added support to configure pcap capture. > > Signed-off-by: Amit Prakash Shukla Change the subject as examples/l3fwd-graph: > --- > v2: > - Fixed code style issue > - Fixed CI compilation issue on github-robot > > v3: > - Code review suggestion from Stephen > - Fixed potential memory leak > > v4: > - Code review suggestion from Jerin > > doc/guides/sample_app_ug/l3_forward_graph.rst | 23 +++++++ > examples/l3fwd-graph/main.c | 62 ++++++++++++++++++- > 2 files changed, 83 insertions(+), 2 deletions(-) > > diff --git a/doc/guides/sample_app_ug/l3_forward_graph.rst b/doc/guides/sample_app_ug/l3_forward_graph.rst > index 0a3e0d44ec..3043dba8e2 100644 > --- a/doc/guides/sample_app_ug/l3_forward_graph.rst > +++ b/doc/guides/sample_app_ug/l3_forward_graph.rst > @@ -51,6 +51,9 @@ The application has a number of command line options similar to l3fwd:: > [--max-pkt-len PKTLEN] > [--no-numa] > [--per-port-pool] > + [--pcap-enable] > + [--pcap-num-cap] > + [--pcap-file-name] > > Where, > > @@ -69,6 +72,12 @@ Where, > > * ``--per-port-pool:`` Optional, set to use independent buffer pools per port. Without this option, single buffer pool is used for all ports. > > +* ``--pcap-enable:`` Optional, Enables packet capture in pcap format on each node with mbuf and node metadata. > + > +* ``--pcap-num-cap:`` Optional, Number of packets to be captured per core. > + > +* ``--pcap-file-name:`` Optional, Pcap filename to capture packets in. > + > For example, consider a dual processor socket platform with 8 physical cores, where cores 0-7 and 16-23 appear on socket 0, > while cores 8-15 and 24-31 appear on socket 1. > > @@ -99,6 +108,20 @@ In this command: > | | | | | > +----------+-----------+-----------+-------------------------------------+ > > +To enable pcap trace on each graph, use following command: > + > +.. code-block:: console > + > + .//examples/dpdk-l3fwd-graph -l 1,2 -n 4 -- -p 0x3 --config="(0,0,1),(1,0,2)" --pcap-enable --pcap-num-cap= --pcap-file-name "" can be changes as "/path/to/file"