* [PATCH v1] eventdev/eth_rx: fix null pointer dereference
@ 2023-08-24 8:23 Ganapati Kundapura
2023-08-25 7:04 ` Jerin Jacob
2023-08-25 13:46 ` Naga Harish K, S V
0 siblings, 2 replies; 4+ messages in thread
From: Ganapati Kundapura @ 2023-08-24 8:23 UTC (permalink / raw)
To: jerinj, s.v.naga.harish.k, dev; +Cc: jay.jayatheerthan, abhinandan.gujjar
On passing NULL as a last parameter to xxx_create_ext_with_params(),
rxa_config_params_validate() uses default values and dereferences
NULL pointer leading to segmentation fault.
Fixed by returning after using default values without dereferencing
NULL pointer.
Fixes: 8be6c94d6d90 ("eventdev/eth_rx: add new adapter create API")
Signed-off-by: Ganapati Kundapura <ganapati.kundapura@intel.com>
diff --git a/app/test/test_event_eth_rx_adapter.c b/app/test/test_event_eth_rx_adapter.c
index 2d5e197666..0233c87779 100644
--- a/app/test/test_event_eth_rx_adapter.c
+++ b/app/test/test_event_eth_rx_adapter.c
@@ -407,6 +407,12 @@ adapter_create(void)
return err;
}
+static void
+adapter_free(void)
+{
+ rte_event_eth_rx_adapter_free(TEST_INST_ID);
+}
+
static int
adapter_create_with_params(void)
{
@@ -427,6 +433,13 @@ adapter_create_with_params(void)
rxa_params.use_queue_event_buf = false;
rxa_params.event_buf_size = 0;
+ /* Pass rxa_params = NULL */
+ err = rte_event_eth_rx_adapter_create_with_params(TEST_INST_ID,
+ TEST_DEV_ID, &rx_p_conf, NULL);
+ TEST_ASSERT(err == 0, "Expected 0 got %d", err);
+ if (err == 0)
+ adapter_free();
+
err = rte_event_eth_rx_adapter_create_with_params(TEST_INST_ID,
TEST_DEV_ID, &rx_p_conf, &rxa_params);
TEST_ASSERT(err == -EINVAL, "Expected -EINVAL got %d", err);
@@ -512,6 +525,13 @@ adapter_create_ext_with_params(void)
rxa_params.use_queue_event_buf = false;
rxa_params.event_buf_size = 0;
+ /* Pass rxa_params = NULL */
+ err = rte_event_eth_rx_adapter_create_ext_with_params(TEST_INST_ID,
+ TEST_DEV_ID, test_port_conf_cb, NULL, NULL);
+ TEST_ASSERT(err == 0, "Expected 0 got %d", err);
+ if (err == 0)
+ adapter_free();
+
err = rte_event_eth_rx_adapter_create_ext_with_params(TEST_INST_ID,
TEST_DEV_ID, test_port_conf_cb, NULL, &rxa_params);
TEST_ASSERT(err == -EINVAL, "Expected -EINVAL got %d", err);
@@ -634,12 +654,6 @@ adapter_queue_stats_test(void)
return TEST_SUCCESS;
}
-static void
-adapter_free(void)
-{
- rte_event_eth_rx_adapter_free(TEST_INST_ID);
-}
-
static int
adapter_create_free(void)
{
diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c
index 93bed18e93..fe84471523 100644
--- a/lib/eventdev/rte_event_eth_rx_adapter.c
+++ b/lib/eventdev/rte_event_eth_rx_adapter.c
@@ -2493,6 +2493,7 @@ rxa_config_params_validate(struct rte_event_eth_rx_adapter_params *rxa_params,
/* use default values if rxa_params is NULL */
temp_params->event_buf_size = ETH_EVENT_BUFFER_SIZE;
temp_params->use_queue_event_buf = false;
+ return 0;
} else if (!rxa_params->use_queue_event_buf &&
rxa_params->event_buf_size == 0) {
RTE_EDEV_LOG_ERR("event buffer size can't be zero\n");
--
2.23.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v1] eventdev/eth_rx: fix null pointer dereference
2023-08-24 8:23 [PATCH v1] eventdev/eth_rx: fix null pointer dereference Ganapati Kundapura
@ 2023-08-25 7:04 ` Jerin Jacob
2023-08-25 13:46 ` Naga Harish K, S V
1 sibling, 0 replies; 4+ messages in thread
From: Jerin Jacob @ 2023-08-25 7:04 UTC (permalink / raw)
To: Ganapati Kundapura
Cc: jerinj, s.v.naga.harish.k, dev, jay.jayatheerthan, abhinandan.gujjar
On Thu, Aug 24, 2023 at 1:53 PM Ganapati Kundapura
<ganapati.kundapura@intel.com> wrote:
>
> On passing NULL as a last parameter to xxx_create_ext_with_params(),
> rxa_config_params_validate() uses default values and dereferences
> NULL pointer leading to segmentation fault.
>
> Fixed by returning after using default values without dereferencing
> NULL pointer.
>
> Fixes: 8be6c94d6d90 ("eventdev/eth_rx: add new adapter create API")
>
> Signed-off-by: Ganapati Kundapura <ganapati.kundapura@intel.com>
Waiting for Review/Ack from @Naga Harish K, S V to merge
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH v1] eventdev/eth_rx: fix null pointer dereference
2023-08-24 8:23 [PATCH v1] eventdev/eth_rx: fix null pointer dereference Ganapati Kundapura
2023-08-25 7:04 ` Jerin Jacob
@ 2023-08-25 13:46 ` Naga Harish K, S V
2023-08-28 15:49 ` Jerin Jacob
1 sibling, 1 reply; 4+ messages in thread
From: Naga Harish K, S V @ 2023-08-25 13:46 UTC (permalink / raw)
To: Kundapura, Ganapati, jerinj, dev; +Cc: Jayatheerthan, Jay, Gujjar, Abhinandan S
> -----Original Message-----
> From: Kundapura, Ganapati <ganapati.kundapura@intel.com>
> Sent: Thursday, August 24, 2023 1:54 PM
> To: jerinj@marvell.com; Naga Harish K, S V <s.v.naga.harish.k@intel.com>;
> dev@dpdk.org
> Cc: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>; Gujjar, Abhinandan S
> <abhinandan.gujjar@intel.com>
> Subject: [PATCH v1] eventdev/eth_rx: fix null pointer dereference
>
> On passing NULL as a last parameter to xxx_create_ext_with_params(),
> rxa_config_params_validate() uses default values and dereferences NULL
> pointer leading to segmentation fault.
>
> Fixed by returning after using default values without dereferencing NULL
> pointer.
>
> Fixes: 8be6c94d6d90 ("eventdev/eth_rx: add new adapter create API")
>
> Signed-off-by: Ganapati Kundapura <ganapati.kundapura@intel.com>
>
Acked-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>
> diff --git a/app/test/test_event_eth_rx_adapter.c
> b/app/test/test_event_eth_rx_adapter.c
> index 2d5e197666..0233c87779 100644
> --- a/app/test/test_event_eth_rx_adapter.c
> +++ b/app/test/test_event_eth_rx_adapter.c
> @@ -407,6 +407,12 @@ adapter_create(void)
> return err;
> }
>
> +static void
> +adapter_free(void)
> +{
> + rte_event_eth_rx_adapter_free(TEST_INST_ID);
> +}
> +
> static int
> adapter_create_with_params(void)
> {
> @@ -427,6 +433,13 @@ adapter_create_with_params(void)
> rxa_params.use_queue_event_buf = false;
> rxa_params.event_buf_size = 0;
>
> + /* Pass rxa_params = NULL */
> + err = rte_event_eth_rx_adapter_create_with_params(TEST_INST_ID,
> + TEST_DEV_ID, &rx_p_conf, NULL);
> + TEST_ASSERT(err == 0, "Expected 0 got %d", err);
> + if (err == 0)
> + adapter_free();
> +
> err = rte_event_eth_rx_adapter_create_with_params(TEST_INST_ID,
> TEST_DEV_ID, &rx_p_conf, &rxa_params);
> TEST_ASSERT(err == -EINVAL, "Expected -EINVAL got %d", err); @@ -
> 512,6 +525,13 @@ adapter_create_ext_with_params(void)
> rxa_params.use_queue_event_buf = false;
> rxa_params.event_buf_size = 0;
>
> + /* Pass rxa_params = NULL */
> + err =
> rte_event_eth_rx_adapter_create_ext_with_params(TEST_INST_ID,
> + TEST_DEV_ID, test_port_conf_cb, NULL, NULL);
> + TEST_ASSERT(err == 0, "Expected 0 got %d", err);
> + if (err == 0)
> + adapter_free();
> +
> err =
> rte_event_eth_rx_adapter_create_ext_with_params(TEST_INST_ID,
> TEST_DEV_ID, test_port_conf_cb, NULL,
> &rxa_params);
> TEST_ASSERT(err == -EINVAL, "Expected -EINVAL got %d", err); @@ -
> 634,12 +654,6 @@ adapter_queue_stats_test(void)
> return TEST_SUCCESS;
> }
>
> -static void
> -adapter_free(void)
> -{
> - rte_event_eth_rx_adapter_free(TEST_INST_ID);
> -}
> -
> static int
> adapter_create_free(void)
> {
> diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c
> b/lib/eventdev/rte_event_eth_rx_adapter.c
> index 93bed18e93..fe84471523 100644
> --- a/lib/eventdev/rte_event_eth_rx_adapter.c
> +++ b/lib/eventdev/rte_event_eth_rx_adapter.c
> @@ -2493,6 +2493,7 @@ rxa_config_params_validate(struct
> rte_event_eth_rx_adapter_params *rxa_params,
> /* use default values if rxa_params is NULL */
> temp_params->event_buf_size = ETH_EVENT_BUFFER_SIZE;
> temp_params->use_queue_event_buf = false;
> + return 0;
> } else if (!rxa_params->use_queue_event_buf &&
> rxa_params->event_buf_size == 0) {
> RTE_EDEV_LOG_ERR("event buffer size can't be zero\n");
> --
> 2.23.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v1] eventdev/eth_rx: fix null pointer dereference
2023-08-25 13:46 ` Naga Harish K, S V
@ 2023-08-28 15:49 ` Jerin Jacob
0 siblings, 0 replies; 4+ messages in thread
From: Jerin Jacob @ 2023-08-28 15:49 UTC (permalink / raw)
To: Naga Harish K, S V
Cc: Kundapura, Ganapati, jerinj, dev, Jayatheerthan, Jay, Gujjar,
Abhinandan S
On Fri, Aug 25, 2023 at 7:17 PM Naga Harish K, S V
<s.v.naga.harish.k@intel.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Kundapura, Ganapati <ganapati.kundapura@intel.com>
> > Sent: Thursday, August 24, 2023 1:54 PM
> > To: jerinj@marvell.com; Naga Harish K, S V <s.v.naga.harish.k@intel.com>;
> > dev@dpdk.org
> > Cc: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>; Gujjar, Abhinandan S
> > <abhinandan.gujjar@intel.com>
> > Subject: [PATCH v1] eventdev/eth_rx: fix null pointer dereference
> >
> > On passing NULL as a last parameter to xxx_create_ext_with_params(),
> > rxa_config_params_validate() uses default values and dereferences NULL
> > pointer leading to segmentation fault.
> >
> > Fixed by returning after using default values without dereferencing NULL
> > pointer.
> >
> > Fixes: 8be6c94d6d90 ("eventdev/eth_rx: add new adapter create API")
Squashed to this patch to "8be6c94d6d90 ("eventdev/eth_rx: add new
adapter create API")" and rebase the tree to latest main.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-28 15:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-24 8:23 [PATCH v1] eventdev/eth_rx: fix null pointer dereference Ganapati Kundapura
2023-08-25 7:04 ` Jerin Jacob
2023-08-25 13:46 ` Naga Harish K, S V
2023-08-28 15:49 ` Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).