From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 81395A04F3; Fri, 3 Jan 2020 10:10:16 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 39A281C2DA; Fri, 3 Jan 2020 10:10:16 +0100 (CET) Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by dpdk.org (Postfix) with ESMTP id D1F5B1C205 for ; Fri, 3 Jan 2020 10:10:14 +0100 (CET) Received: by mail-io1-f65.google.com with SMTP id z193so40748877iof.1 for ; Fri, 03 Jan 2020 01:10:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=30K72t43AU54XoQC8iUhiqKos56SfMPY2rBZCWaEUGM=; b=vJT11YTS5pJSiMbbRbZWgQconRfu0e8AUnV+dIm0IhKj6YWBzyC18Ff8H8EjdO45rk LRGJdRggQ5ab8R2wKr5NbRs/yI3WAV8yifDEs8zUAGZX4Mhce12BVThzGQsh2l97E6lO UcbdnNJ/PanLlrMNkaqAgnMSbXGbDIafWim88RKiPbyq6CzF1Fjv3LAZvCuixTAhY9Z/ bGsLUi7DIaHyueB0jzfpHH33d22qRx/EQ4P229T1RkXyPl/T/hie7uIcswX2n6uszAtK DiJrkMKQcejKze14Pl271Kmf0pF8qCqDj2Lf5VkWfwY/m/g4fFvBFoCZ6cp12o7tQxK5 l38g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=30K72t43AU54XoQC8iUhiqKos56SfMPY2rBZCWaEUGM=; b=BeaElZkhNpT4TYjIGT3SMOLzEHvvST3xBr81KvChqdeOZXEKyFdtSrDJO1bIJtoJ4t pLP55axDUfs5zkgSko1/x6qCofEDag83gRsFNAeIL3NkXI6Xku3Gw2BQBY+VYB9qsbg/ 9cST+dNIf6vcUSVQtZYddRKxcuLKG5lh3honifO3b4Nsb9U2rDScSubpmVLjrYcxIc31 SfQpUJPiso9hz4/JZMeW/oxdHvWsZz7sF1MAe9aPkUyTYCKe4JECE2DdjQ/ZQQTEVviu C3HTBNi3L2uAlpyyv1XylkGNzBvo2KFTMjhfdmFFYgvxheVcC4c2IUxyWir/LMVWhQ1Z R2ag== X-Gm-Message-State: APjAAAVj/Qrerg2V7ZE37h+uQWaWqKEDMp3X1+ICgi1qS/zmdXbyaMBh o6TCzO0Pd+gclVlLwP+IjleTHO/gqUe2OMjCPB8= X-Google-Smtp-Source: APXvYqwvyAoLko7Q8FjobFeOk5nzT9QaGzXTpKjtjTd07ptF2aahwsGK+Aiaoidi6DeF6Uv7s9Ftut7YvmgdLQzH/lQ= X-Received: by 2002:a5e:8516:: with SMTP id i22mr59775818ioj.130.1578042613919; Fri, 03 Jan 2020 01:10:13 -0800 (PST) MIME-Version: 1.0 References: <20191204144345.5736-1-pbhagavatula@marvell.com> <20191204144345.5736-5-pbhagavatula@marvell.com> In-Reply-To: From: Jerin Jacob Date: Fri, 3 Jan 2020 14:39:57 +0530 Message-ID: To: Nipun Gupta Cc: Pavan Nikhilesh Bhagavatula , Jerin Jacob Kollanukkaran , Marko Kovacevic , Ori Kam , Bruce Richardson , Radu Nicolau , Akhil Goyal , Tomasz Kantecki , Sunil Kumar Kori , Hemant Agrawal , "dev@dpdk.org" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 04/11] examples/l3fwd: add ethdev setup based on eventdev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jan 3, 2020 at 2:36 PM Nipun Gupta wrote: > > > > > -----Original Message----- > > From: Jerin Jacob > > Sent: Thursday, January 2, 2020 3:04 PM > > To: Nipun Gupta > > Cc: Pavan Nikhilesh Bhagavatula ; Jerin Jacob > > Kollanukkaran ; Marko Kovacevic > > ; Ori Kam ; Bruce > > Richardson ; Radu Nicolau > > ; Akhil Goyal ; Tomasz > > Kantecki ; Sunil Kumar Kori ; > > Hemant Agrawal ; dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v2 04/11] examples/l3fwd: add ethdev setup > > based on eventdev > > > > On Thu, Jan 2, 2020 at 2:20 PM Nipun Gupta wrote: > > > > > > > > > > > > > -----Original Message----- > > > > From: Pavan Nikhilesh Bhagavatula > > > > Sent: Thursday, January 2, 2020 11:52 AM > > > > To: Nipun Gupta ; Jerin Jacob Kollanukkaran > > > > ; Marko Kovacevic ; Ori > > > > Kam ; Bruce Richardson > > > > ; Radu Nicolau ; > > > > Akhil Goyal ; Tomasz Kantecki > > > > ; Sunil Kumar Kori ; > > > > Hemant Agrawal > > > > Cc: dev@dpdk.org > > > > Subject: RE: [dpdk-dev] [PATCH v2 04/11] examples/l3fwd: add ethdev setup > > > > based on eventdev > > > > > > > > >> >&local_port_conf); > > > > >> >> + if (ret < 0) > > > > >> >> + rte_exit(EXIT_FAILURE, > > > > >> >> + "Cannot configure device: err=%d, > > > > >> >> port=%d\n", > > > > >> >> + ret, port_id); > > > > >> >> + > > > > >> > > > > > >> >We should be using number of RX queues as per the config option > > > > >> >provided in the arguments. > > > > >> >L3fwd is supposed to support multiple queue. Right? > > > > >> > > > > >> The entire premise of using event device is to showcase packet > > > > >scheduling to > > > > >> cores > > > > >> without the need for splitting packets across multiple queues. > > > > >> > > > > >> Queue config is ignored when event mode is selected. > > > > > > > > > >For atomic queues, we have single queue providing packets to a single > > > > >core at a time till processing on that core is completed, irrespective of > > > > >the flows on that hardware queue. > > > > >And multiple queues are required to distribute separate packets on > > > > >separate cores, with these atomic queues maintaining the ordering and > > > > >not scheduling on other core, until processing core has completed its > > > > >job. > > > > >To have this solution generic, we should also take config parameter - > > > > >(port, number of queues) to enable multiple ethernet RX queues. > > > > > > > > > > > > > Not sure I follow we connect Rx queue to an event queue which is then > > > > linked to multiple event ports which are polled on > > > > by respective cores. > > > > > > This is what we too support, but with atomic queue case the scenario gets > > little complex. > > > Each atomic queue can be scheduled only to one event port at a time, until all > > the events from > > > that event port are processed. Then only it can move to other event port. > > > > This would make it a poll mode. We might as well use normal PMD + RSS > > for the same instead. > > i.e use l3fwd in poll mode. It will be the same in terms of performance. Right? > > We do not need to have a complete config, but can have a parameter as number of RX > queues per port. We will send a patch on top of this to support the same. Looks good to me. > > Thanks, > Nipun > > > > > > > > > To have separate event ports process packets at same time in atomic scenario, > > multiple queues > > > are required. As l3fwd supports multiple queues, it seems legitimate to add the > > support. > > > > > > Thanks, > > > Nipun > > > > > > > How would increasing Rx queues help? Distributing flows from single event > > > > queue to multiple event ports is the responsibility > > > > of Event device as per spec. > > > > Does DPAA/2 function differently? > > > > > > > > Regards, > > > > Pavan. > > > > > > > > >Regards, > > > > >Nipun > > > > > > > > > >> > > > > >> > > > > > >> >Regards, > > > > >> >Nipun > > > > >> > > > > > >> > > > > >> Regards, > > > > >> Pavan.