From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 69FB2A0350; Sun, 28 Jun 2020 14:30:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2958E1C21F; Sun, 28 Jun 2020 14:30:08 +0200 (CEST) Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by dpdk.org (Postfix) with ESMTP id BA0AF1C21C for ; Sun, 28 Jun 2020 14:30:06 +0200 (CEST) Received: by mail-io1-f65.google.com with SMTP id h4so14322632ior.5 for ; Sun, 28 Jun 2020 05:30:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SZH+WH9k/4ugEZbAhlFFRFEcL3AMA4Ak49f2/tLSUYc=; b=HNzlK2nl0V3VAjvhk4gfdPmSfyzCM8KLRXZEeORW6yevAdPZhklbNyOiTdK+mWfJmw drZuSbH+pLp2sbcABa5M21ILOaNWVYOET73GQzf7Riad/Bmx0YCJefMGOoMqVzOnCl+2 3YafuhoOh52zLSIzRewse6UayU1NiqNm5FXkNuhIDyVrnRQbwl1epDiO9D0vpVTncq32 xSO87MbF3x1v5i409v+j/1kDpJAo201jUtqjXqXN7q33a7qmpuzhWwN6VSCpsYLr7YtO xC52f43HIa/ymtNUU5/EzoLT6yRMK2EvZVolBPEMeph6gUERGZATsox4P816QtohATJN DTaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SZH+WH9k/4ugEZbAhlFFRFEcL3AMA4Ak49f2/tLSUYc=; b=a1CkPZO5G1ESjrQGEDjQH6UkTxYdnDLNftdeatcBXRWGelnhjyNtjQ1a2FoOzERznl lXOnru3pdKptjxMhfo1ZhAfQs0oBLkaB0wf+VCdaw0v7rdjEDsGbBDwki3uLOnG/INcj TwnAkCHYo7ChWC//RsinP58C2eKaToXxF442AQODdEA1WHQUoLnVeoG0qnbdnhoP9AAv Ob8ZPSQGlV7FV1KKtDtQ2Cskfqi+VLTINQ8soP5l7O4I0SLVaA64Go8UIWCLoNnBZ7wv Vg7DWAiRwffod6qgYhRteR2yd8Wl9Jgz38FWzoA5uAwWwgZ5WeEdlOklwaqb+j0qHl0U hlsA== X-Gm-Message-State: AOAM533lEu67mMrLuShoqP4MfOgU3eU9RRtFBm9dnK6G/irliglfzHcm HxKjB4rTV1MjuiujrXChzCsbrNwnu8catXZWd+Y= X-Google-Smtp-Source: ABdhPJzCl6LuUycFYvgK2/9ZnjmLOtE3lKEoH/LAB9/td2OEzwFovBwoXJDhU8KCNDDfWG0q2EmZcYjDQU65ltUPnZA= X-Received: by 2002:a6b:b344:: with SMTP id c65mr12732679iof.123.1593347405996; Sun, 28 Jun 2020 05:30:05 -0700 (PDT) MIME-Version: 1.0 References: <20200628055850.5275-1-rmody@marvell.com> <20200628055850.5275-4-rmody@marvell.com> In-Reply-To: <20200628055850.5275-4-rmody@marvell.com> From: Jerin Jacob Date: Sun, 28 Jun 2020 17:59:50 +0530 Message-ID: To: Rasesh Mody Cc: Jerin Jacob , Ferruh Yigit , dpdk-dev , GR-Everest-DPDK-Dev , Igor Russkikh Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 3/4] net/qede: add infrastructure for debug data collection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, Jun 28, 2020 at 11:29 AM Rasesh Mody wrote: > > The patch adds QEDE PMD ops and APIs to calculate the size and collect > the debug dump for various firmware components. The patch adds new files > qede_debug.[ch] that has all the firmware debug data collection > infrastructure changes. > > Signed-off-by: Rasesh Mody > Signed-off-by: Igor Russkikh > --- > drivers/net/qede/Makefile | 4 +- > drivers/net/qede/base/bcm_osal.h | 5 +- > drivers/net/qede/qede_debug.c | 8119 ++++++++++++++++++++++++++++++ > drivers/net/qede/qede_debug.h | 759 +++ > drivers/net/qede/qede_if.h | 45 + > drivers/net/qede/qede_main.c | 39 +- > 6 files changed, 8967 insertions(+), 4 deletions(-) > create mode 100644 drivers/net/qede/qede_debug.c > create mode 100644 drivers/net/qede/qede_debug.h Please fix the following checkpatch issues. CHECK:MACRO_ARG_REUSE: Macro argument reuse 'field' - possible side-effects? #494: FILE: drivers/net/qede/qede_debug.c:339: +#define FIELD_BIT_MASK(type, field) \ + (((1 << FIELD_BIT_SIZE(type, field)) - 1) << \ + FIELD_DWORD_SHIFT(type, field)) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'var' - possible side-effects? #498: FILE: drivers/net/qede/qede_debug.c:343: +#define SET_VAR_FIELD(var, type, field, val) \ + do { \ + var[FIELD_DWORD_OFFSET(type, field)] &= \ + (~FIELD_BIT_MASK(type, field)); \ + var[FIELD_DWORD_OFFSET(type, field)] |= \ + (val) << FIELD_DWORD_SHIFT(type, field); \ + } while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'field' - possible side-effects? #498: FILE: drivers/net/qede/qede_debug.c:343: +#define SET_VAR_FIELD(var, type, field, val) \ + do { \ + var[FIELD_DWORD_OFFSET(type, field)] &= \ + (~FIELD_BIT_MASK(type, field)); \ + var[FIELD_DWORD_OFFSET(type, field)] |= \ + (val) << FIELD_DWORD_SHIFT(type, field); \ + } while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'block' - possible side-effects? #518: FILE: drivers/net/qede/qede_debug.c:363: +#define NUM_DBG_LINES(block) \ + ((block)->num_of_dbg_bus_lines + NUM_EXTRA_DBG_LINES(block)) WARNING:TYPO_SPELLING: 'DIDNT' may be misspelled - perhaps 'DIDN'T'? #5814: FILE: drivers/net/qede/qede_debug.c:5659: + /* DBG_STATUS_DATA_DIDNT_TRIGGER */ ERROR:TRAILING_STATEMENTS: trailing statements should be on next line #6344: FILE: drivers/net/qede/qede_debug.c:6189: + for (; reg_id > curr_reg_id; [...] + 1);