DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerinjacobk@gmail.com>
To: Harman Kalra <hkalra@marvell.com>
Cc: Jerin Jacob <jerinj@marvell.com>,
	Nithin Dabilpuram <ndabilpuram@marvell.com>,
	dpdk-dev <dev@dpdk.org>,  dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/octeontx2: fix seg fault on running procinfo
Date: Fri, 26 Jun 2020 20:11:20 +0530
Message-ID: <CALBAE1NdonLhQ2DRBBGHp5PsvLMT=34VF3FV8UDfqCELshY+zg@mail.gmail.com> (raw)
In-Reply-To: <1590396667-25632-1-git-send-email-hkalra@marvell.com>

On Mon, May 25, 2020 at 2:21 PM Harman Kalra <hkalra@marvell.com> wrote:
>
> Segmentation fault has been observed while running procinfo
> with reset options i.e. --stats-reset and --xstats-reset.
> Reason is procinfo runs as a secondary process and tries to
> hold a lock which is part of struct mdev, which was not
> allocated as part of shared mememory.

s/mememory/memory

please change the subject to "common/octeontx2"

>
> Fixes: 5ca59711f771 ("common/octeontx2: add mailbox base support infra")
> Cc: stable@dpdk.org
>
> Signed-off-by: Harman Kalra <hkalra@marvell.com>
> ---
>  drivers/common/octeontx2/otx2_mbox.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/common/octeontx2/otx2_mbox.c b/drivers/common/octeontx2/otx2_mbox.c
> index 2b7810929..6df1e8ea6 100644
> --- a/drivers/common/octeontx2/otx2_mbox.c
> +++ b/drivers/common/octeontx2/otx2_mbox.c
> @@ -9,6 +9,7 @@
>
>  #include <rte_atomic.h>
>  #include <rte_cycles.h>
> +#include <rte_malloc.h>
>
>  #include "otx2_mbox.h"
>  #include "otx2_dev.h"
> @@ -36,7 +37,7 @@ otx2_mbox_fini(struct otx2_mbox *mbox)
>  {
>         mbox->reg_base = 0;
>         mbox->hwbase = 0;
> -       free(mbox->dev);
> +       rte_free(mbox->dev);
>         mbox->dev = NULL;
>  }
>
> @@ -128,7 +129,9 @@ otx2_mbox_init(struct otx2_mbox *mbox, uintptr_t hwbase, uintptr_t reg_base,
>                 return -ENODEV;
>         }
>
> -       mbox->dev = malloc(ndevs * sizeof(struct otx2_mbox_dev));
> +       mbox->dev = rte_zmalloc("mbox dev",
> +                               ndevs * sizeof(struct otx2_mbox_dev),
> +                               OTX2_ALIGN);
>         if (!mbox->dev) {
>                 otx2_mbox_fini(mbox);
>                 return -ENOMEM;
> --
> 2.18.0
>

  reply	other threads:[~2020-06-26 14:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-25  8:51 Harman Kalra
2020-06-26 14:41 ` Jerin Jacob [this message]
2020-06-29 13:26   ` [dpdk-dev] [PATCH v2] common/octeontx2: " Harman Kalra
2020-06-30 10:44     ` Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALBAE1NdonLhQ2DRBBGHp5PsvLMT=34VF3FV8UDfqCELshY+zg@mail.gmail.com' \
    --to=jerinjacobk@gmail.com \
    --cc=dev@dpdk.org \
    --cc=hkalra@marvell.com \
    --cc=jerinj@marvell.com \
    --cc=ndabilpuram@marvell.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git