From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EA023A04B5; Tue, 12 Jan 2021 05:50:49 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D47C0140D21; Tue, 12 Jan 2021 05:50:49 +0100 (CET) Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) by mails.dpdk.org (Postfix) with ESMTP id 5676C140D1C for ; Tue, 12 Jan 2021 05:50:49 +0100 (CET) Received: by mail-io1-f52.google.com with SMTP id r9so1430466ioo.7 for ; Mon, 11 Jan 2021 20:50:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cG2M0+NU2cXVc+JvEPV77pitZPZ1HKu7z2YnEpyvJIc=; b=mmsGDC3XtyCc0LSawWJlGuptxNdc5s7AFg8MZzuOYw5SgEeFo0awV05A6slZJ+smia SyK7QJiOBfimFneFtm3lTVSXKqYxS0gmxFJd0CiIEyXDZEfVX4MMQJB8TpFJ4sIU7Nkc TJLFVpIXpEPx+6FvU4nHTSAAT3Ok9j3l+UibECVBuy/uOffCgP18yyvTdFTUbtGCDAKh g9nhWiEfOuw+VwSdoCoQ+1K+PFq+XF+MFMbCFyRI9Srae4jx5MVJEG/WgBr+deszOgY2 JtSB703JbzElhWhf4GvUOIdmOBVcCXpIChQg3U1f0F1X/KT2yblWNSFNnALDAAi5y/8P bPiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cG2M0+NU2cXVc+JvEPV77pitZPZ1HKu7z2YnEpyvJIc=; b=S/KYKO/VvVVb1BgKTOYKTjNKA2y5HKFbj69mPkNlBkleb2lXo2z7x3LU5DZKJjrQkG LNTRRBDm46U8FpNk3v7KWjdIeJaDv8fbRiNtZRWJtFX0xKkzzWB7vNUWcZAAlxA/nQgz JgYrVVCc+lg3JDSCvjCQ0yg6G6QKXneJCfDB/1VUnBa/Z9nDd1cGv5yj35dL4m95I/mZ aU6zukqynDlFpkQNaV1b0qwQWdDQ9qaHFbXU16xLHTmpJaYVia3KvkD+OT2bkf6ukNc3 Rcoz6uzXZJzNk48KsRLZFKEoZDjiaoxJwZC2MeAvCYf/kkOUc31H71CiTotkRL7z++06 gpwQ== X-Gm-Message-State: AOAM532lEFC98xXIl3UkCfUO13uE5GZhnLOMPAys+hjsVZYHqDj0kBy+ JLKLrml5dB7r9PCxXdWcTk2BKNhV1tYyXshRYlw= X-Google-Smtp-Source: ABdhPJyv2G1tBhbAb7Mir0xEJ2djZ2jY7lR5RP84Vp09PYQpcjKULzykPX75kIqHpXiLXjHXRDHufLoEQCFYYoQd5Gg= X-Received: by 2002:a5d:8ac8:: with SMTP id e8mr1945646iot.163.1610427048731; Mon, 11 Jan 2021 20:50:48 -0800 (PST) MIME-Version: 1.0 References: <2a4ca79e-8051-c0c2-8bea-a0f972a69d8e@marvell.com> In-Reply-To: From: Jerin Jacob Date: Tue, 12 Jan 2021 10:20:32 +0530 Message-ID: To: Rasesh Mody Cc: Igor Russkikh , Balazs Nemeth , "dev@dpdk.org" , Devendra Singh Rawat Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2] net/qede: fix regression introduced by b10231aed1ed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jan 4, 2021 at 7:47 PM Rasesh Mody wrote: > > > From: dev On Behalf Of Igor Russkikh > > Sent: Monday, January 4, 2021 6:15 PM > > > > > When calling rte_eth_promiscuous_enable(port_id) followed by > > > rte_eth_allmulticast_enable(port_id), the port is not in promisc mode > > > anymore. This patch ensures that promisc mode takes precedence over > > > allmulticast mode fixing the regression introduced by b10231aed1ed. Please add Fixes: > > > > > > Signed-off-by: Balazs Nemeth Rasesh, Devendra, Waiting for your ack to merge this. > > > --- > > > drivers/net/qede/qede_ethdev.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/net/qede/qede_ethdev.c > > > b/drivers/net/qede/qede_ethdev.c index 549013557..3bec62d82 100644 > > > --- a/drivers/net/qede/qede_ethdev.c > > > +++ b/drivers/net/qede/qede_ethdev.c > > > @@ -1885,6 +1885,8 @@ static int qede_allmulticast_enable(struct > > > rte_eth_dev *eth_dev) > > > QED_FILTER_RX_MODE_TYPE_MULTI_PROMISC; > > > enum _ecore_status_t ecore_status; > > > > > > + if (rte_eth_promiscuous_get(eth_dev->data->port_id) == 1) > > > + type = QED_FILTER_RX_MODE_TYPE_PROMISC; > > > ecore_status = qed_configure_filter_rx_mode(eth_dev, type); > > > > > > return ecore_status >= ECORE_SUCCESS ? 0 : -EAGAIN; > > > > Hi Balazs, thanks for posting! > > > > I think we need Fixes tag here. > > Please Cc: stable@dpdk.org so that all the stable releases also integrate this change. > > Thanks, > Rasesh > > > > > Devendra, could you please check if thats enough? May be we should > > consider more of internal states here? What if we'll do promisc_disable() > > after that? > > Will allmulti state persist? > > > > Igor