From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B484A329E for <public@inbox.dpdk.org>; Wed, 23 Oct 2019 19:29:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4A9A41C440; Wed, 23 Oct 2019 19:29:11 +0200 (CEST) Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by dpdk.org (Postfix) with ESMTP id CCC171C1F4 for <dev@dpdk.org>; Wed, 23 Oct 2019 19:29:09 +0200 (CEST) Received: by mail-io1-f65.google.com with SMTP id 1so14586941iou.4 for <dev@dpdk.org>; Wed, 23 Oct 2019 10:29:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=wTAe8bwWQi40k+H7bLtuEjmeAyctGG1+8euYfzjsBSg=; b=pY61Va3LlXWFARUVxGVPHvhEiFpufczpGVFW7RpeUeC55cHBMw03PDwhelY5viZtO9 0GGS8TtEtHO/Hj946U3M9m/fOxFg3sx7CWHX3NB77Pw2nbvBSeeS3lbgc89yHHc7aaI9 bGsqhMYSqtjbKQH3/xjbq7QpfXHbQSJkR/pF+BhRFt8pw4f0ibxbZuyVrRlzt5g6ae++ ayEp/FI050vd9Auc2Umg/cJ+YZVOalKs1y+J8ymAg5mvxYpuCan+pY86lVFvmxWUubT5 wvMbSVO7czHhVvI5uPZhvatv1dYY7uQVfZTwKlmdfbdjOOt8JdrHC16VsPTTKLxXV+sb Tfqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=wTAe8bwWQi40k+H7bLtuEjmeAyctGG1+8euYfzjsBSg=; b=oxk4mNGfYoZKpnShh1xQNswP8IH0NrNXRAJh65nmKaywP801QVhBSh0mscgQf4OR1I 2h0pEehhKAqbvakRtWf+5qVD+NFZccRdxMecKW1ca5g4vhQLMvBYRXw8FeaAILHJp44N YL/bA6yFj1O2r7roCO7R1C5qniBBBObCWMzka4a+FPd1oJnJjX0KElLcOkW4VcksrJbH 8b2DvZGH92cQThsuIhIqoMM9+6BDwj8dPtdIoRa4/SwgbzL3zZQSsxBaPBzedmAcQ9ax HeryuuQKW8Nta6PHkU7oDwiKNpehvfSSDYyL1CMnqeNtIdXr/bhRGiVX/mfzdH66/zkS M+sw== X-Gm-Message-State: APjAAAWCDoOM8t+v1l1ySJ7ISg7AG/F8PW1bPCLnWjS+KghgoMX++xYL F0gxXCXakji80PmbDnOo8L8SBRm76PYT1tFlO8rS4aBuWT4= X-Google-Smtp-Source: APXvYqz6zJHyAqCi7f2HGwiKHvf1YCvUe+7TvwE5IKd5ekFQ5L8136D4U6LaK2nrClW/qZ+LETUokLELI3JmxpZvSeM= X-Received: by 2002:a6b:740b:: with SMTP id s11mr4673386iog.294.1571851748900; Wed, 23 Oct 2019 10:29:08 -0700 (PDT) MIME-Version: 1.0 References: <20191012073421.44748-1-jerinj@marvell.com> <VE1PR08MB5149EDA5C5FD3A513B815BEC98680@VE1PR08MB5149.eurprd08.prod.outlook.com> <CALBAE1P5XUyLn-1gDqLsgjFSLVCpgwtO7BM9ZZUCxPMBicAqhw@mail.gmail.com> <VE1PR08MB5149C627B65CB87202BCF29C986B0@VE1PR08MB5149.eurprd08.prod.outlook.com> In-Reply-To: <VE1PR08MB5149C627B65CB87202BCF29C986B0@VE1PR08MB5149.eurprd08.prod.outlook.com> From: Jerin Jacob <jerinjacobk@gmail.com> Date: Wed, 23 Oct 2019 22:58:52 +0530 Message-ID: <CALBAE1Nh2eA907MZgorsD9XnNqC4BEcimE0mXKD_CcWkWD_RHA@mail.gmail.com> To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com> Cc: dpdk-dev <dev@dpdk.org>, "Akhil.goyal@nxp.com" <akhil.goyal@nxp.com>, "thomas@monjalon.net" <thomas@monjalon.net>, "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>, "anoobj@marvell.com" <anoobj@marvell.com>, "pathreya@marvell.com" <pathreya@marvell.com>, "pkapoor@marvell.com" <pkapoor@marvell.com>, "jerinj@marvell.com" <jerinj@marvell.com>, nd <nd@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] maintainers: update for armv8 crypto library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Wed, Oct 23, 2019 at 10:42 PM Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com> wrote: > > On Wed, 23 Oct, 2019, 2:02 am Honnappa Nagarahalli, <Honnappa.Nagarahalli= @arm.com> wrote: > > <snip> > > > > > From: Jerin Jacob <jerinj@marvell.com> > > > > Update the armv8 crypto PMD maintainership. > > > > https://github.com/caviumnetworks/armv8_crypto external crypto the libr= ary > > will not be maintained and probably removed soon therefor updating the = PMD > > documentation to reflect the same. > > > > Signed-off-by: Jerin Jacob <jerinj@marvell.com> > > --- > > > > This patch is based on the discussion of the following thread > > http://mails.dpdk.org/archives/dev/2019-October/146005.html > > > > In summary, > > # ARMv8 crypto PMD depends on an external library owned by Marvell, > > specifically crafted to the DPDK performance use case. > > # There is no upstream path to this library and it will not be maintain= ed due to > > that fact that it > > a) Creates fragmentation of the SW > > b) Contribution policy concerning external Github Repos > > c) None other than Marvell can contribute to this library and this make= s > > difficult for other stakeholder to use it. > > > > # As the maintainer, I would like to make forward progress by providing= the > > following options. None of the options are converging as the result I w= ould like > > to step down from the maintainership of the incomplete PMD as I don't s= ee > > any options for collaboration, improvement in the library nor follows t= he open > > source philosophy in the way it is structured out now. > > > > option 1) Move external library(BSD-3 license) to dpdk.org so that ever= y armv8 > > vendors can contribute, improve and avoid SW fragmentation and therefor= e > > better quality. > I do not see any issues with this approach. This patch should be changed = to reflect this option? > > > > > > In past, there was a concern with this approach about maintaining the ass= embly code in dpdk.org. Is this concern still valid? > > > > > > > > option 2) If option 1 is not possible, remove the incomplete PMD from > > dpdk.org and maintain the existing PMD as the external one by each vend= or. > > This won't change much in the existing situation as this PMD is not sta= ndalone > > and anyway depended on an external code base. > IMHO, DPDK defines an interface to integrate an external crypto library. = This might be under use by applications. Removing the PMD will break those = applications. > > > > DPDK does not define any such interface. It was pushed to external librar= y for the reason mentioned above. > > [Honnappa] So, what should an application which has its own crypto librar= y do when the PMD is removed? > > > > If no one is ready to host the actual code, how is even possible to have = floating PMD which can not even build by community. > > [Honnappa] I am trying to understand your comment. Are you saying without= the actual crypto library how do we build/test the PMD? Yes. > Is it ok to introduce a stub library which is used if =E2=80=98ARMV8_CRYP= TO_LIB_PATH=E2=80=99 is not set. Such stub should not be subjected to expor= t license issues. It won't be even functional. Right? and we really don't know, do we really have an export license issue or not? Having said that, I have no issues if we choose to go with stub model provided this document patch is accepted. > > > > I propose to take this to TB to reach to consensus as we are going in cir= cles in mailing list. > > > > > > > > > > I am glad/help to execute option 1 or 2 or help to a new maintainer if = he/she > > would like to step up and take ownership. > > > > --- > > MAINTAINERS | 1 - > > doc/guides/cryptodevs/armv8.rst | 3 +-- > > 2 files changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index b02066270..8096d93c4 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -918,7 +918,6 @@ F: doc/guides/cryptodevs/ccp.rst > > F: doc/guides/cryptodevs/features/ccp.ini > > > > ARMv8 Crypto > > -M: Jerin Jacob <jerinj@marvell.com> > > F: drivers/crypto/armv8/ > > F: doc/guides/cryptodevs/armv8.rst > > F: doc/guides/cryptodevs/features/armv8.ini > > diff --git a/doc/guides/cryptodevs/armv8.rst > > b/doc/guides/cryptodevs/armv8.rst index 1ab40096e..ada2a774d 100644 > > --- a/doc/guides/cryptodevs/armv8.rst > > +++ b/doc/guides/cryptodevs/armv8.rst > > @@ -28,8 +28,7 @@ Installation > > > > In order to enable this virtual crypto PMD, user must: > > > > -* Download ARMv8 crypto library source code from > > - `here <https://github.com/caviumnetworks/armv8_crypto>`_ > > +* Use ARMv8 crypto library source code from vendor SDK > > > > * Export the environmental variable ARMV8_CRYPTO_LIB_PATH with > > the path where the ``armv8_crypto`` library was downloaded > > -- > > 2.23.0