From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E00842468; Mon, 23 Jan 2023 14:14:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D89B8400EF; Mon, 23 Jan 2023 14:14:05 +0100 (CET) Received: from mail-vs1-f47.google.com (mail-vs1-f47.google.com [209.85.217.47]) by mails.dpdk.org (Postfix) with ESMTP id 41122400D4 for ; Mon, 23 Jan 2023 14:14:05 +0100 (CET) Received: by mail-vs1-f47.google.com with SMTP id d66so12746820vsd.9 for ; Mon, 23 Jan 2023 05:14:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=+DZga5rIEYqfu55x/7b7xgyrSsZ65lP3rUSxlA9y1Pc=; b=g/nVh1R4Gc25E9i3fa+IT1VcnrIiUe+urUeTNdYdT+s5IV/L7Ca/SdbZqtKL6o3eV1 0NlP90PVZBJ/AcXc2Uv6k1j8HGAxgn1pVJihjug64yCp3ug7WlCipjYAo1R419HWOh+y Vdx5+vHwVgKUpw544xmcPITFWXwgSbT7OhKgDuRZ0/Of1tdDvrjA2p2ZwLzwXgNuy70l nZIAZQn+h43PBw+9cFPlgCm5L/5rybfD8X/YLvemnVG+fPRw9c5DE+reWqnMgxy3euIt A/UTdhKK9PWhpPMVRMOrZszN7rl1Jnoig8XX+39jOXBZ264BN9VwemVEXgCLAcGG3ymw xMnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+DZga5rIEYqfu55x/7b7xgyrSsZ65lP3rUSxlA9y1Pc=; b=cBG5FIYwUoffg+p8YflpJqQYTXh9T5bACbJct9KPijuopzfVpRcxHNJVT+0bCkOr8j 4tiqHGi5kpT3Maem77PZhpBa07CcYt+qvaRLQxHZ2f1PrEyx8SkM22EAncGKTD3KTvIj EVK/fytFKbUkQBtG2bOa6ySZTstqssJ/tVyWVoIg0UDi17ccRD2kESc1k4b5ltIkhRnD koXgPELywb1MsOod9JynATiayoAG/VyJiZOOVfHRPrIk+LkTebUQPj312vJKvlsh1feq EWOpAIWL2HaaXndAIS1FeABc79qMU2w4wobd2AnNYIMKwlvgJusArGqep0iIPy8t2Dpj XCuw== X-Gm-Message-State: AFqh2kohjq0t4yPzYe+2yMhE0rF5ZPmmc42hd6G5dhJj0ze3xeIA4BvQ gQHRa2tH9h6KHrNt5nKxa/NYKOdk/bwLhWFy/X0= X-Google-Smtp-Source: AMrXdXsElli+/9wlCWom0+l4fzhUy2PzooiLY7yBMsxn5AWH1puNBIXogVcHAkSW4X+0K2UK9ulJetfbvgU3XNy4nHM= X-Received: by 2002:a05:6102:2828:b0:3b1:40eb:5957 with SMTP id ba8-20020a056102282800b003b140eb5957mr3636493vsb.66.1674479644452; Mon, 23 Jan 2023 05:14:04 -0800 (PST) MIME-Version: 1.0 References: <20221222013904.692922-1-rkudurumalla@marvell.com> <20221221190140.399996e0@hermes.local> In-Reply-To: From: Jerin Jacob Date: Mon, 23 Jan 2023 18:43:38 +0530 Message-ID: Subject: Re: [PATCH 1/3] lib: dpdk spec to skip red for ingress policer To: Rakesh Kudurumalla Cc: Ori Kam , Stephen Hemminger , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Ferruh Yigit , Andrew Rybchenko , "dev@dpdk.org" , "NBU-Contact-Adrien Mazarguil (EXTERNAL)" Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jan 18, 2023 at 1:39 PM Rakesh Kudurumalla wrote: > > > > > -----Original Message----- > > From: Rakesh Kudurumalla > > Sent: Tuesday, January 10, 2023 12:12 PM > > To: Ori Kam ; Jerin Jacob ; > > Stephen Hemminger > > Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) ; > > Ferruh Yigit ; Andrew Rybchenko > > ; dev@dpdk.org; NBU-Contact-Adrien > > Mazarguil (EXTERNAL) > > Subject: RE: [PATCH 1/3] lib: dpdk spec to skip red for ingress policer > > > > > > > > > -----Original Message----- > > > From: Ori Kam > > > Sent: Monday, December 26, 2022 10:30 PM > > > To: Jerin Jacob ; Stephen Hemminger > > > > > > Cc: Rakesh Kudurumalla ; NBU-Contact- > > Thomas > > > Monjalon (EXTERNAL) ; Ferruh Yigit > > > ; Andrew Rybchenko > > > ; dev@dpdk.org; NBU-Contact-Adrien > > > Mazarguil (EXTERNAL) > > > Subject: [EXT] RE: [PATCH 1/3] lib: dpdk spec to skip red for ingress > > > policer > > > > > > External Email > > > > > > ---------------------------------------------------------------------- > > > Hi All, > > > > > > > -----Original Message----- > > > > From: Jerin Jacob > > > > Sent: Thursday, 22 December 2022 7:27 > > > > > > > > On Thu, Dec 22, 2022 at 8:32 AM Stephen Hemminger > > > > wrote: > > > > > > > > > > On Thu, 22 Dec 2022 07:09:02 +0530 Rakesh Kudurumalla > > > > > wrote: > > > > > > > > > > > Dropping of packets based on RED can be skipped with meter > > > > > > action, when RED is configured using > > > > > > rte_eth_cman_config_set() > > > > > > > > > > > > Signed-off-by: Rakesh Kudurumalla > > > > > > > > > > Should this be more general and apply to all congestion management > > > > > options. Assuming the hardware can do something better than RED. > > > > > > > > Yes. We can use "enum rte_cman_mode mode" in the descriptor to > > > > future- proof. > > > > > > I'm missing the idea of this new action, I understand that is related > > > to Jerin congestion patches. > > > But I fail to see why we need it? Is it to mark some metadata that > > > will have some effect on the congestion result? (I assume the system > > > is implemented in the HW) > > > > Yes. It is implemented in HW. Congestion management is applied on ethdev > > Rx queue using rte_eth_cman_config() API. Once it is configured, it applies to > > all the packets that steer towards that particular ethdev Rx queue. This > > feature help to skip the congestion management processing based on the > > packet color identified by the rte_flow meter object. For example, If one Rx > > queue configured as RED congestion and application wants to bypass the > > RED congestion processing for all GREEN color packet can be expressed > > though this API proposal. > > Hi Ori Kam, > > Let me know if above information would give clear idea on skip RED action Rakesh, Adding extra rewording to make it clear. git comment: ethdev: introduce flow action to skip congestion management configuration Using rte_eth_cman_config_set() API the application can configure ethdev Rx queue's congestion mechanism. Introducing RTE_FLOW_ACTION_TYPE_SKIP_CMAN flow action to skip the congestion configuration applied to the given ethdev Rx queue. This feature helps to skip the congestion management processing based on per flow or the packet color identified by the rte_flow meter object. For example, If one Rx queue configured as RED congestion and application wants to bypass the RED congestion processing for all GREEN color packet can be expressed though RTE_FLOW_ACTION_TYPE_SKIP_CMAN flow action. code: /** * Skip congestion management configuration * * Skip the congestion management configuration applied using rte_eth_cman_config_set() * API on the given ethdev Rx queue. */ RTE_FLOW_ACTION_TYPE_SKIP_CMAN