From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E3720A04A8; Fri, 1 May 2020 10:01:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 710A21D9E9; Fri, 1 May 2020 10:01:21 +0200 (CEST) Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by dpdk.org (Postfix) with ESMTP id D6AE21D952; Fri, 1 May 2020 10:01:19 +0200 (CEST) Received: by mail-io1-f66.google.com with SMTP id k23so4200225ios.5; Fri, 01 May 2020 01:01:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=AbJ4cgCrpsgie/QO9uunEJhE1IXg+wcSRHqe0mH5HLo=; b=oH0eQtkIfPnYJu9aZa6+cye/HNKQyMlrLnlA6zZUfDb1Oz8txBSSMiRyyYlmGEGYpQ xZ0NKC7pwuOKgqHk2vCexa23mbK8oOWuANkRdBRYZjhFWo9gukwFna5bnQv9vaTKenDD +ojFfwFsssouRxgbmQPA/bthQtaS7GgLvOBYre1KLQkGBA3uCVRLbjKb/i7F+bsMutEG fSew0Fnnl2xTbIPMoO56+GCZkwn7Vpu09cRUUd2TkMV9bhaZWfzFVQn/WLbMFfs038c/ WdbHGxtimUpKvWQN//TVA6kYEJJd85qbWuLCFgF13XWsqMR4v6k3ZkeTJEVxcCoWroWS GOcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=AbJ4cgCrpsgie/QO9uunEJhE1IXg+wcSRHqe0mH5HLo=; b=gJ5NNvlhb8Mh+HwBbLMmmQ84dvo09tT7iVI9t+cQJtLZK6M2y7+X3K5NkRguoybc8m pdqNEJQJnMespF1VBTUT6NJ0j1bqOTAliZHmHuRqzxVwHH3Mhdfe7ZHqVYQQ4GpeW5Y+ aDDd9Y3ObRDPhZ+8bQNGfdCX58viW9phuLME5dMBx8mKrlPrBU7IsAz/p4q9oAmplSGZ 1Zh6JzZD+niGoHWpGmVA1Vv34pb9RT/+7KpHWWkTiAa3eRq+Cs8DqoOR2Dni5xYZioBc nGNMq9dIzsXz1SNi3eMNJ4ifjKUGDJFtzbL2Yy0ZFOEYAhfoBC76l7sci8YM1SvGQfl+ 7GaQ== X-Gm-Message-State: AGi0PuaP7cVaOKN1wDcNsRIvByp2P1u1n/nQi1KVAs/KWlYGhS2BSOOs 1rw6UGX0q8dcNrtUF7UzE9tKRM6Buf9JrnBoeI8= X-Google-Smtp-Source: APiQypLfhJr7PJcsnxtIVV0hFnhat7ymrDoVP6V27GJMpvXuvKi+nDO6i95DPuiUMMD2WwE24hUjss5YvBO95r5RJ9U= X-Received: by 2002:a5e:9806:: with SMTP id s6mr2737855ioj.59.1588320079004; Fri, 01 May 2020 01:01:19 -0700 (PDT) MIME-Version: 1.0 References: <20200305104651.25456-1-mattias.ronnblom@ericsson.com> In-Reply-To: From: Jerin Jacob Date: Fri, 1 May 2020 13:31:03 +0530 Message-ID: To: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= Cc: Venky Venkatesh , Jerin Jacob , dpdk-dev , dpdk stable Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] event/dsw: avoid reusing previously recorded events X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Apr 14, 2020 at 7:02 PM Jerin Jacob wrote: > > On Tue, Apr 14, 2020 at 6:41 PM Mattias R=C3=B6nnblom > wrote: > > > > On 2020-04-14 14:45, Jerin Jacob wrote: > > > On Sat, Apr 4, 2020 at 6:05 PM Jerin Jacob wr= ote: > > >> On Fri, Mar 6, 2020 at 11:35 AM Venky Venkatesh > > >> wrote: > > >>> Hi Mattias, > > >>> Have a question on this fix. I understand you wanting a certain num= ber of > > >>> events before making a decision to migrate (in the above fix). > > >>> However, suppose there are fewer events over a few flows (even if n= ot many) > > >>> and yet your core is heavily loaded -- indicating may be they are o= ne or > > >>> more very CPU intensive flows. Often in DPI situations depending on= the > > >>> complexity of the policy you can get delayed longer. It might still= be > > >>> worthwhile to migrate if the other cores are really lightly loaded.= I think > > >>> that case will be missed out in this approach. > > >>> > > >>> Fundamentally, the number of packets being a proxy-metric for the l= oad of > > >>> that flow on the cpu is simplistic at times. Very CPU intensive > > >>> medium/lower bandwidth flows can be picked up in this heuristic. If= there > > >>> is a way that at the time of DSW init we can have a way of tuning i= t > > >>> depending on the application scenario it might be more flexible. > > >> Hi Venky and Mattias, > > >> > > >> Is this patch to good to merge? > > > Please mark the patch as "Not applicable" if the patch is not require= d. > > > > > > > This patch should be merged. Thanks. > > Sure. I will wait for couple of days on any comments on this patch. If > none, I will merge this. Could you rebase this patch to next-eventdev master and send the next version so that I can merge it? [master][dpdk-next-eventdev] $ git am -3 /tmp/to_merge/event-dsw-avoid-reusing-previously-recorded-events Applying: event/dsw: avoid reusing previously recorded events Using index info to reconstruct a base tree... M drivers/event/dsw/dsw_event.c Falling back to patching base and 3-way merge... Auto-merging drivers/event/dsw/dsw_event.c CONFLICT (content): Merge conflict in drivers/event/dsw/dsw_event.c Recorded preimage for 'drivers/event/dsw/dsw_event.c' error: Failed to merge in the changes. Patch failed at 0001 event/dsw: avoid reusing previously recorded events hint: Use 'git am --show-current-patch=3Ddiff' to see the failed patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". [master][dpdk-next-eventdev] $