DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] event/dsw: avoid reusing previously recorded events
@ 2020-03-05 10:46 Mattias Rönnblom
  2020-03-06  6:05 ` Venky Venkatesh
  0 siblings, 1 reply; 8+ messages in thread
From: Mattias Rönnblom @ 2020-03-05 10:46 UTC (permalink / raw)
  To: jerinj; +Cc: dev, stable, vvenkatesh, Mattias Rönnblom

Avoid reusing recorded events when performing a migration, since this
may make the migration selection logic pick an already-moved flow.

Fixes: f6257b22e767 ("event/dsw: add load balancing")
Cc: stable@dpdk.org

Reported-by: Venky Venkatesh <vvenkatesh@paloaltonetworks.com>
Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
---
 drivers/event/dsw/dsw_event.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/event/dsw/dsw_event.c b/drivers/event/dsw/dsw_event.c
index d68b71b98..296adea18 100644
--- a/drivers/event/dsw/dsw_event.c
+++ b/drivers/event/dsw/dsw_event.c
@@ -646,6 +646,9 @@ dsw_port_consider_migration(struct dsw_evdev *dsw,
 	if (dsw->num_ports == 1)
 		return;
 
+	if (seen_events_len < DSW_MAX_EVENTS_RECORDED)
+		return;
+
 	DSW_LOG_DP_PORT(DEBUG, source_port->id, "Considering migration.\n");
 
 	/* Randomize interval to avoid having all threads considering
-- 
2.17.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2020-05-01  8:01 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-05 10:46 [dpdk-dev] [PATCH] event/dsw: avoid reusing previously recorded events Mattias Rönnblom
2020-03-06  6:05 ` Venky Venkatesh
2020-03-06  7:48   ` Mattias Rönnblom
2020-04-04 12:35   ` Jerin Jacob
2020-04-14 12:45     ` Jerin Jacob
2020-04-14 13:11       ` Mattias Rönnblom
2020-04-14 13:32         ` Jerin Jacob
2020-05-01  8:01           ` Jerin Jacob

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).