From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2415D43192; Wed, 18 Oct 2023 03:56:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 11C5240261; Wed, 18 Oct 2023 03:56:34 +0200 (CEST) Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) by mails.dpdk.org (Postfix) with ESMTP id 6590B4003C for ; Wed, 18 Oct 2023 03:56:32 +0200 (CEST) Received: by mail-qt1-f174.google.com with SMTP id d75a77b69052e-41cb615c6fbso5164181cf.1 for ; Tue, 17 Oct 2023 18:56:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697594192; x=1698198992; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ysCSp/pJ81A3OTvHcV/LiRhQj8VIcx+IT/Praa7WUdM=; b=GfijqQmK52s9U4TQkpIz5NvKKzkuMNMsEMDaao7xTDzneLJS4y1yYAiZF/Wzh5ie77 W6V6DlSg0EAvUemBDQ4EElTYJkSPhauyeSW5rZc/InoLVqWHcP00TtivO+wHRCWU0wqR bkep23ekoKk9tfEIG5Dbp0wjPvry6iYGL/iwCsb8Lt4bTAnWkUoyArr4Ggz4rh8zLXV9 FZHkS2p3/A5PMWKdyrQskElUcG7BOitWwQNXZ6J5gOq9oNYngl9zMIuOI42F2wdF/iGD Rzr6MjOtSsICVch1iAWdfcyviaFSwgceaYwv4q0rx/QYQmQSlLvk42zR8D+Sjd+do7Ro anDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697594192; x=1698198992; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ysCSp/pJ81A3OTvHcV/LiRhQj8VIcx+IT/Praa7WUdM=; b=AZWNaHUoxEsfvs8M2lEowLeBnzl+HIG5GmM5yif+dvU94XwK+m4ZKGbJMvbrXw7Ywr 0JTKVtzUx+YX/vi00sJSVFlB1sJyBN/pYRUL91sufDsjZDO4Tcg68/vGneQRSVokpEKL 9XIGYZVAh/chMnE08ckDO3G1NtA/K+DUBu9RrgtwtI7HQ52CnlYQb7MsYHnOUNgqoEcn A91iSA2ZYNFFQjbml/INAbMoGSFvhD0Ek8+mZVz6EDtFXfek085gyVEWu8kQGyu/Hw4D Cmg8NWpQsHniD/4HOYy7tq3IJ319YNKiBppjPl1j6kLpbaF3jpjAXal3Q4/MR0VS32NI PAhQ== X-Gm-Message-State: AOJu0YzieNs3wfFr/cU8psV0H/pv/8e9MwvZHKPLSx7HcEmhy6ghNSrC 9UUw0yNMiGv0MPi9wE7srteEek9ndN5hYhMKtXJrIaLHhCA= X-Google-Smtp-Source: AGHT+IH7tk6QJKu3qQrDSdvsHpnnPYce5haWvvuqitse81Wd9HXGzsiy+0Z+tg4sGSmg4dIbtWo7Sk80VKZt7RPg37o= X-Received: by 2002:a05:622a:1a26:b0:419:5763:975 with SMTP id f38-20020a05622a1a2600b0041957630975mr5385147qtb.46.1697594191647; Tue, 17 Oct 2023 18:56:31 -0700 (PDT) MIME-Version: 1.0 References: <20230830155927.3566-1-syalavarthi@marvell.com> <20231017165951.27299-1-syalavarthi@marvell.com> In-Reply-To: <20231017165951.27299-1-syalavarthi@marvell.com> From: Jerin Jacob Date: Wed, 18 Oct 2023 07:26:05 +0530 Message-ID: Subject: Re: [PATCH v4 00/34] Implementation of revised ml/cnxk driver To: Srikanth Yalavarthi Cc: dev@dpdk.org, sshankarnara@marvell.com, aprabhu@marvell.com, ptakkar@marvell.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 17, 2023 at 10:30=E2=80=AFPM Srikanth Yalavarthi wrote: > > This patch series is an implementation of revised ml/cnxk driver > to support models compiled with TVM compiler framework. TVM models > use a hybrid mode for execution, with regions of the model executing > on the ML accelerator and the rest executing on CPU cores. > > This series of commits reorganizes the ml/cnxk driver and adds support > to execute multiple regions with-in a TVM model. > Found following build error (may be due to gcc13) ml/cnxk: enable OCM check for multilayer TVM model [2389/2660] Compiling C object drivers/libtmp_rte_ml_cnxk.a.p/ml_cnxk_cnxk_ml_ops.c.o FAILED: drivers/libtmp_rte_ml_cnxk.a.p/ml_cnxk_cnxk_ml_ops.c.o ccache gcc -Idrivers/libtmp_rte_ml_cnxk.a.p -Idrivers -I../drivers -Idrivers/ml/cnxk -I../drivers/ml/cnxk -Ilib/mldev -I../lib/mldev -I. -I.. -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/l inux/include -Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/log -I../lib/log -Ilib/metrics -I../lib/metrics -Ilib/telemetry -I../lib/telemetry -I lib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/mbuf -I../lib/mbuf -Idrivers/common/cnxk -I../drivers/common/cnxk -Idrivers/bus/pci -I../drivers/bus/pci -Ilib/net -I../lib/net -Ilib/ethdev -I../lib/ethdev -Ilib/meter -I../lib/me ter -Ilib/pci -I../lib/pci -I../drivers/bus/pci/linux -Ilib/security -I../lib/security -Ilib/cryptodev -I../lib/cryptodev -Ilib/rcu -I../lib/rcu -Ilib/hash -I../lib/hash -fdiagnostics-color=3Dalways -D_FILE_OFFSET_BITS=3D64 -Wall -Winvalid-pch -Wextra -Werror -std=3Dc11 -O2 -g -include rte_config.h -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-address-of-packed-member -Wno-packed-not-aligned -Wno-missing-field-initializers -Wno-zero-length-bounds -D_GNU_SOURCE -fPIC -march=3Dnative -mrtm -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format-truncation -DCNXK_ML_DEV_DEBUG -DRTE_LOG_DEFAULT_LOGTYPE=3Dpmd.ml.cnxk -MD -MQ drivers/libtmp_rte_ml_cnxk.a.p/ml_cnxk_cnxk_ml_ops.c.o -MF drivers/libtmp_rte_ml_cnxk.a.p/ml_cnxk_cnxk_ml_ops.c.o.d -o drivers/libtmp_rte_ml_cnxk.a.p/ ml_cnxk_cnxk_ml_ops.c.o -c ../drivers/ml/cnxk/cnxk_ml_ops.c ../drivers/ml/cnxk/cnxk_ml_ops.c: In function =E2=80=98cnxk_ml_model_load= =E2=80=99: ../drivers/ml/cnxk/cnxk_ml_ops.c:527:18: error: =E2=80=98struct cnxk_ml_mod= el=E2=80=99 has no member named =E2=80=98type=E2=80=99 527 | if (model->type =3D=3D ML_CNXK_MODEL_TYPE_GLOW) { | ^~ ../drivers/ml/cnxk/cnxk_ml_ops.c:527:28: error: =E2=80=98ML_CNXK_MODEL_TYPE_GLOW=E2=80=99 undeclared (first use in this fun= ction); did you mean =E2=80=98ML_CNXK_MODEL_STATE_LOADED=E2=80=99? 527 | if (model->type =3D=3D ML_CNXK_MODEL_TYPE_GLOW) { | ^~~~~~~~~~~~~~~~~~~~~~~ | ML_CNXK_MODEL_STATE_LOADED ../drivers/ml/cnxk/cnxk_ml_ops.c:527:28: note: each undeclared identifier is reported only once for each function it appears in ../drivers/ml/cnxk/cnxk_ml_ops.c:549:26: error: =E2=80=98struct cnxk_ml_mod= el=E2=80=99 has no member named =E2=80=98type=E2=80=99 549 | if (model->type =3D=3D ML_CNXK_MODEL_TYPE_GLOW) { | ^~ ../drivers/ml/cnxk/cnxk_ml_ops.c:568:26: error: =E2=80=98struct cnxk_ml_mod= el=E2=80=99 has no member named =E2=80=98type=E2=80=99 568 | if (model->type =3D=3D ML_CNXK_MODEL_TYPE_GLOW) | ^~ [2390/2660] Generating drivers/rte_bus_dpaa.sym_chk with a custom command (wrapped by meson to capture output) [2391/2660] Generating drivers/rte_bus_fslmc.sym_chk with a custom command (wrapped by meson to capture output) [2392/2660] Generating lib/pipeline.sym_chk with a custom command (wrapped by meson to capture output) [2393/2660] Generating lib/ethdev.sym_chk with a custom command (wrapped by meson to capture output) [2394/2660] Generating lib/eal.sym_chk with a custom command (wrapped by meson to capture output) [2395/2660] Generating drivers/rte_common_sfc_efx.sym_chk with a custom command (wrapped by meson to capture output) [2396/2660] Generating drivers/rte_common_cnxk.sym_chk with a custom command (wrapped by meson to capture output) ninja: build stopped: subcommand failed.