From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1F6D41E99; Wed, 15 Mar 2023 06:53:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B25BB410DD; Wed, 15 Mar 2023 06:53:23 +0100 (CET) Received: from mail-vs1-f50.google.com (mail-vs1-f50.google.com [209.85.217.50]) by mails.dpdk.org (Postfix) with ESMTP id 04C4C400EF for ; Wed, 15 Mar 2023 06:53:23 +0100 (CET) Received: by mail-vs1-f50.google.com with SMTP id x25so7960185vsj.2 for ; Tue, 14 Mar 2023 22:53:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678859602; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ueciPl5hmwI/xaXU9R1a62uyJy0EytGo2u77wYYD6yw=; b=p+hwjnS2BbTLJ0oIIl2SI6SJUvbhWXKkXR4dKhayROZGm82hoMWTbnnF1y9oCFVeim uPwPC3qWfSry9Fj3mNZkobA6xcUIUyfM9WnVeuEPaE5p/ZiMyQ5NebS4qECnWXKE0LeX CZ1/Vx5/NItfYbq2nehsJFZqHBiJ4BEJnGkiPVWn5SP06YVRrEKHkUOu+RMEJuPZ2QC9 ECY2FSnHtrWejKOf/uZo+ov4kVTTNN2Pzpyy/viypnFb458J3YwhnwGgIP/GaTsKMwAv La6zcfK4VzzKnQH/7J5X2wW33U320MgYZOBqdAA9jInwhq6hNFsVhqPLiPcRzNFyINeS MUZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678859602; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ueciPl5hmwI/xaXU9R1a62uyJy0EytGo2u77wYYD6yw=; b=LmF23n3yBovifuesrHIx5fBIOtrkaMsY2nAtlXE3G+1ChcPV9/SeDeFRNtnG/RDffo bWMoMVq8anLM1yDfKIAXA1tpWyG6w+uFpDa9++RzEUbBhnvcpDtipeOGJrcBCm4pg2kQ 1DCpRM2Tp8ZM6jLxYMCMZWJE7q2qrNAJ1gJlYJnhC+qOHfsb4wum4S4BcNbrB8w/Pq66 +2/yS2g75+0g6aIzQHWZUvJ+1XSuZf/anVNWrG/qe5/wh1FYAblx1PUXxpwLuDNKcQMg qYb+eRflryFp+68WjTY1tU+A7gnSfuuXTkolIOxH2CNa4T6nbKhtZYyI1zgdYtFVzm4y eXjg== X-Gm-Message-State: AO0yUKXPwcgbjO6WJfJAQEZjepOy21M6zNgMj6bvnFDKaHyainshsamT 281VBYDrWSwnzNQlbpPUeN/sAsGmm8jeiBlyzeQ= X-Google-Smtp-Source: AK7set/w3wyVHq7ddXMzNJpebmvrXIen6Cnn81RbZozJSdPP2A7hbKhzsvNE8SZ8CW9wdqqzxaKFF1ZxWqXI22jt9K4= X-Received: by 2002:a67:e089:0:b0:411:f6d4:1be9 with SMTP id f9-20020a67e089000000b00411f6d41be9mr25531086vsl.5.1678859602398; Tue, 14 Mar 2023 22:53:22 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jerin Jacob Date: Wed, 15 Mar 2023 11:22:56 +0530 Message-ID: Subject: Re: [PATCH v1] common/cnxk: fix initialization of timer LF count To: Pavan Nikhilesh Bhagavatula Cc: Shijith Thotton , Jerin Jacob Kollanukkaran , "dev@dpdk.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Mar 14, 2023 at 11:29=E2=80=AFAM Pavan Nikhilesh Bhagavatula wrote: > > > > > -----Original Message----- > > From: Shijith Thotton > > Sent: Tuesday, March 14, 2023 9:17 AM > > To: Jerin Jacob Kollanukkaran > > Cc: Shijith Thotton ; dev@dpdk.org; Pavan > > Nikhilesh Bhagavatula > > Subject: [PATCH v1] common/cnxk: fix initialization of timer LF count > > > > Assignment of nb_lfs variable with the available number of timer LFs wa= s > > not happening in the success case after the addition of the new label > > "done". This patch fixes the same by moving the assignment under the > > label. > > > > Fixes: 44a9307c0908 ("common/cnxk: support mailbox locking") > > > > Signed-off-by: Shijith Thotton > > Acked-by: Pavan Nikhilesh Applied to dpdk-next-net-mrvl/for-next-net. Thanks > > > --- > > drivers/common/cnxk/roc_tim.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/common/cnxk/roc_tim.c > > b/drivers/common/cnxk/roc_tim.c > > index 6f256c60fa..f8607b2852 100644 > > --- a/drivers/common/cnxk/roc_tim.c > > +++ b/drivers/common/cnxk/roc_tim.c > > @@ -394,11 +394,11 @@ roc_tim_init(struct roc_tim *roc_tim) > > } else { > > goto done; > > } > > - roc_tim->nb_lfs =3D nb_lfs; > > > > fail: > > mbox_put(dev->mbox); > > done: > > + roc_tim->nb_lfs =3D nb_lfs; > > return nb_lfs; > > } > > > > -- > > 2.25.1 >