From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1DFFAA0032; Fri, 18 Feb 2022 09:37:50 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A17E040395; Fri, 18 Feb 2022 09:37:49 +0100 (CET) Received: from mail-io1-f49.google.com (mail-io1-f49.google.com [209.85.166.49]) by mails.dpdk.org (Postfix) with ESMTP id 8841F40150 for ; Fri, 18 Feb 2022 09:37:48 +0100 (CET) Received: by mail-io1-f49.google.com with SMTP id r7so1284794iot.3 for ; Fri, 18 Feb 2022 00:37:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=On73IZHzg1QLRjLMzNwcFdf/QQG6oVZYO66l7GLkGfc=; b=m7lJ8FjuOkPMHXhr3mM1IBvp7qkcuwpNQpggp+T4lZbPYEMM1qwt2a9i8gm7x3ejrH SXkR3e59SHeTThkLrA+Yucp4Ov73VZ83v30ehq56I2CvECi40PtY7yuUkzM0XcvB683w S/S8DES9E8bIotLB2+c/OfFTc7hXrAqNRtknRpog0KiOyz1CTQC5/m3IK/0+P0wFHtsK 6XWh0cTP7y2FCK1y9xPDss10Rl9kwFU2X56mQrg5DKOX6ATzJunVNb/uH54c6DWMR3dz KkPFkhovMoBBt1ax6BgPjOXy58+ZOLDC4IJs+FaaiIg7IqypvxWNyW23IFx8T+2hK6KN I7+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=On73IZHzg1QLRjLMzNwcFdf/QQG6oVZYO66l7GLkGfc=; b=LXyLBEjJypxL6VgajJbl9qMcXn/FlbPkR/uxaTo+mmKYSWwKagAEnzbVDA+gWOBJR6 hxDvE8GWM/LP9aIR/by5QBTseGEyi0Efy77omwbrtwwoQ9cs1m2lE1nMU0Q7EEI7IDlQ 6Oys322Rtk2ASc8es51kmbdVGG8yWQFripnVwG/TKHUedSf01jSQ35ASOvYMjOOSJdha 1LTj/PoHWObRzfH5OI6/MnmQvvPJhspIKXw/NKMwDCte1J4DAP5XNKEh4/nchYdFwspI n+mKnvLkw6kyQBv8gu0bcLyeKd92naYLVELuFdFoQqVOJcpJ5IaJqFx2+0l9mydYjQjB 0GQw== X-Gm-Message-State: AOAM532mZzQQYbxPcojaJj4QwpUirJMZmhXg1SvA1ZKk5Cd1llbfiXNv 7XEkFJ5naiW6eIlUmW4Y3XgSOWy1NqovB58wQIU= X-Google-Smtp-Source: ABdhPJwoPKpeFzmWrc7o1kMbweu21mpTdSjFt1/IUqCEgEanzJQ9roxw1gYkwTY918SUALviOGioXEoYKtDSBYaJeI0= X-Received: by 2002:a05:6602:210c:b0:640:7616:d93a with SMTP id x12-20020a056602210c00b006407616d93amr1529957iox.154.1645173467867; Fri, 18 Feb 2022 00:37:47 -0800 (PST) MIME-Version: 1.0 References: <20220210115256.2744447-1-asekhar@marvell.com> <20220218072712.2946331-1-asekhar@marvell.com> In-Reply-To: <20220218072712.2946331-1-asekhar@marvell.com> From: Jerin Jacob Date: Fri, 18 Feb 2022 14:07:21 +0530 Message-ID: Subject: Re: [PATCH v3] mempool/cnxk: fix bug in batch alloc issue failure path To: Ashwin Sekhar T K , Ferruh Yigit Cc: dpdk-dev , Jerin Jacob , Sunil Kumar Kori , Satha Koteswara Rao Kottidi , Pavan Nikhilesh , Kiran Kumar K , Satheesh Paul , Anoob Joseph , Akhil Goyal Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Feb 18, 2022 at 12:54 PM Ashwin Sekhar T K wrote: > > Fix bug in batch alloc issue failure path where it was > enqueuing invalid pointers back to the pool. The code > should rightly be falling back to default dequeue path > in such cases. > > Fixes: 91531e63f4 ("mempool/cnxk: add cn10k batch dequeue") Cc: stable@dpdk.org > > Signed-off-by: Ashwin Sekhar T K > --- Acked-by: Jerin Jacob Applied to dpdk-next-net-mrvl/for-next-net. Thanks > drivers/mempool/cnxk/cn10k_mempool_ops.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mempool/cnxk/cn10k_mempool_ops.c b/drivers/mempool/cnxk/cn10k_mempool_ops.c > index 4c669b878f..6ebbf91de5 100644 > --- a/drivers/mempool/cnxk/cn10k_mempool_ops.c > +++ b/drivers/mempool/cnxk/cn10k_mempool_ops.c > @@ -202,7 +202,7 @@ cn10k_mempool_deq(struct rte_mempool *mp, void **obj_table, unsigned int n) > BATCH_ALLOC_SZ, 0, 1); > /* If issue fails, try falling back to default alloc */ > if (unlikely(rc)) > - return cn10k_mempool_enq(mp, obj_table, n); > + return cnxk_mempool_deq(mp, obj_table, n); > mem->status = BATCH_ALLOC_OP_ISSUED; > } > > -- > 2.32.0 >