From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D237BA00BE; Tue, 14 Jun 2022 11:27:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B119B40DDD; Tue, 14 Jun 2022 11:27:12 +0200 (CEST) Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) by mails.dpdk.org (Postfix) with ESMTP id DA1014068E; Tue, 14 Jun 2022 11:27:11 +0200 (CEST) Received: by mail-qk1-f177.google.com with SMTP id g15so4538197qke.4; Tue, 14 Jun 2022 02:27:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GEmFx4yMWs1dE0gOd+ow6KHpTvQY6BxLjIspDVdizLk=; b=hL8vzygKanL1NV4mhjhYQSRgkhg6CNDYFm6wtCfHT5FMZ/7VAR4Nn17PZVu12Kf2s1 l2kZlfKje271jvfVC33f5V/XinH9R5oBdoMEu+8jAjvqeEakCeQUmfgsHH+gU1hIJIRG SZz/zn35iNFq1YRZJXOT2W25Mor7GAyDsnzxQj+rnr+v+UFdkXy8rz9Li153kI9lTmtE rD9HHMKaqks50ZFTdUjOVDfkey+Gmmwua+Z5WicOOh0MlGfXAsQ3p7kw7PSbZUvP00vn 24V1WRxRo9RArov2lHh4x2cYjNByHyp2fHhvEjCQnpmEgDuVOGRCtRptPtgaxpwBdwpZ 2xEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GEmFx4yMWs1dE0gOd+ow6KHpTvQY6BxLjIspDVdizLk=; b=Fa3drnQDIryhhsVbF/E6uuzDTzcQ1UWrGCnW8oCp3XKIQEDaNTcF7vG5zUhomtPoZt QnQgQzH3SAf9U5VuV/jQPiPpG//2QO35e9UEPoE9V+ravzpLHqGywqx7QiFo3uVvP78C 97+4Y4v44vin2EIU3zfkKnsMSVnZuiCAavJQPDgVnvT8bB9cMb7Z2xSU4K1fy2pYJIzt EJQVuHFBBHbINLiWW78IH51zBn7ZV60zNuTp+IzagOkawUToW+Vjm/HsP0atdOfSLYHq /yks1pQEr8OgqyrtxhuAnv8nGHVb70OwAP0xDeYfif2ihGDlBaaf4vNY7cf6pmKUCg8F M+1g== X-Gm-Message-State: AOAM533oHZ/hWKYD48tNUtIbEcqclJmBHsc6I5uKakg0eXBSTeBnB9uc FAZr1/MZFw5+2PJ5RTDoRjBuspvUXEPuiqkxlayHTiuxi+I= X-Google-Smtp-Source: ABdhPJwXFDtT27kXzkXhl/8JqtymLWq41uxFsJ+K3Xs6efZ/WncCu/qbBR0bP5BhsEYKx0MG2aFSBZuW4MmqMyMyhPw= X-Received: by 2002:ae9:e851:0:b0:6a7:5a0f:f7b9 with SMTP id a78-20020ae9e851000000b006a75a0ff7b9mr3241521qkg.316.1655198831234; Tue, 14 Jun 2022 02:27:11 -0700 (PDT) MIME-Version: 1.0 References: <20220606154044.1225683-1-timothy.mcdaniel@intel.com> <20220613181914.3212778-1-timothy.mcdaniel@intel.com> In-Reply-To: <20220613181914.3212778-1-timothy.mcdaniel@intel.com> From: Jerin Jacob Date: Tue, 14 Jun 2022 14:56:45 +0530 Message-ID: Subject: Re: [PATCH v3] event/dlb2: fix advertized capabilities To: Timothy McDaniel Cc: Jerin Jacob , dpdk-dev , dpdk stable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jun 13, 2022 at 11:49 PM Timothy McDaniel wrote: > > This commit corrects the advertized capabilities reported by the DLB2 PMD. > > Previously DLB2 reported supporting RTE_EVENT_DEV_CAP_QUEUE_QOS, but the > DLB2 hardware does not support such capability. This commit removes that > feature from the reported capabilities feature set. > > Additionally, two capabilities that DLB2 does support were not being > reported in the capabilities feature set. This commit adds those. > > RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT = Event device is capable of > setting up the link between multiple queues and a single port. If the > flag is not set, the eventdev can only map a single queue to each > port or map a single queue to many port > > RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK = Event device is capable of > configuring the queue/port link at runtime. If the flag is not set, > the eventdev queue/port link is only can be configured during > initialization > > Finally, the file doc/guides/eventdevs/features/dlb2.ini has been updated > to match the capabilities actually reported by the PMD. > > Fixes: e7c9971a857a ("event/dlb2: add probe-time hardware init") > Cc: stable@dpdk.org > > Signed-off-by: Timothy McDaniel > For here to [2] content, needs to be moved to [1] to avoid polluting the commit message. Fixed and Applied to dpdk-next-net-eventdev/for-main. Thanks > === > > Changes since V2: > Added "fixes" line that was present in original, but missing in V2. > > Changes since V1; > 1) reorder capabilities flags to match the order that they appear in > in the default.ini file > 2) update the dlb2.ini file with the new set of features supported by DLB2 > 3) expanded the commit message to provide additional details [2] > --- [1] > doc/guides/eventdevs/features/dlb2.ini | 3 ++-