From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 13783A04DF; Tue, 11 Aug 2020 19:48:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BD6251C022; Tue, 11 Aug 2020 19:48:56 +0200 (CEST) Received: from mail-il1-f194.google.com (mail-il1-f194.google.com [209.85.166.194]) by dpdk.org (Postfix) with ESMTP id DC5161C01F for ; Tue, 11 Aug 2020 19:48:54 +0200 (CEST) Received: by mail-il1-f194.google.com with SMTP id y18so11461125ilp.10 for ; Tue, 11 Aug 2020 10:48:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pUvRTNV4X6LTZSvG37XtCkRI72qTIVFmPCAddwJzqxI=; b=C7leN0EkJ1l7wiFjrbU0pbu0yaahW65I0vI4YVujOYXaw4rdbE2DUtBmvH+KIpNZNm aljRb9tY0koKJfFprwAs2UkYpjEti9VbMxB2nsfpRbviiKW/FuhpDoHmeqezpF7cUvry u1gpUVcoJiOlvO0HwOfoBYlfgbLRd7vvUAjNguueYbjtz7vUiqjNNhf0bTDNxs2/hikG bPqQlkyutXX0WY04I5wLK02uvPUr3HoXqbG93LVyH+bynEmc5gnW5yOZdloD2yF82oKl fkdj+EHv2Ks6DlaWL4Ixk49wQlVH7/p4bsuShJSqmyWg9sDRKUbU4lUDISJ8TM5pXFiO 9/Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pUvRTNV4X6LTZSvG37XtCkRI72qTIVFmPCAddwJzqxI=; b=gziUy4POgvHrH1fyA0QiU76W5k30ZnHSfbETtQTOoGEYg5h6GVlRoZ+wcLV50jHiIM L4cyC7HluyJmyHu0JBAD19O8e3h9l7/Fr8opSOyORTwMXaKga42oKAUEFR40g82XyFRM +K3cmW4JJmhlnk8W7/NTxGwx0qb8bX/3rqQzgWyEi+yrzvLxMQMx9Q9TB8QQoywQSbut 9bpSpkTYRadIMm35KEQHzq3roVWwLhWnnu2fx5NI28RSVwgHAmgGBdhy54FD6KGEVxFm mXyskkp/CLFY3op2M+5j72M+d+AsibJ5mxKgL4NQo3g6Waj7Cn4QRLFYVz4y0Z07AYxD rVrw== X-Gm-Message-State: AOAM533v65fJ4dVoXe+0T11gqeMYSn9UFEyT8k6MMDMPGIH64qLSsd3X IR8Hpv+tI72x4PoTQQOK6Db7vk1b/AVhT9HQmLc= X-Google-Smtp-Source: ABdhPJxobDn80Sf7xwPLmL6zkuYIRs8jyfSX5ydK0C9USL6EXt6IIpFZhWi9hpDddIA9Kx4qcYFX0oxsjnOFMDV1IGI= X-Received: by 2002:a92:cd0d:: with SMTP id z13mr851014iln.294.1597168134279; Tue, 11 Aug 2020 10:48:54 -0700 (PDT) MIME-Version: 1.0 References: <1593232671-5690-0-git-send-email-timothy.mcdaniel@intel.com> <1596138614-17409-1-git-send-email-timothy.mcdaniel@intel.com> <1596138614-17409-3-git-send-email-timothy.mcdaniel@intel.com> In-Reply-To: <1596138614-17409-3-git-send-email-timothy.mcdaniel@intel.com> From: Jerin Jacob Date: Tue, 11 Aug 2020 23:18:37 +0530 Message-ID: To: "McDaniel, Timothy" Cc: Jerin Jacob , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , dpdk-dev , Gage Eads , "Van Haaren, Harry" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 02/27] eventdev: do not pass disable_implicit_release bit to trace macro X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jul 31, 2020 at 1:23 AM McDaniel, Timothy wrote: > > From: "McDaniel, Timothy" > > Previous implementation traced u8 disable_impl_release, which > is now a bit field contained in the new u32 event_port_cfg > field. > > Signed-off-by: McDaniel, Timothy > --- > lib/librte_eventdev/rte_event_crypto_adapter.c | 2 +- > lib/librte_eventdev/rte_event_eth_tx_adapter.c | 5 +++-- > lib/librte_eventdev/rte_eventdev.c | 3 +-- > lib/librte_eventdev/rte_eventdev_trace.h | 9 +++++---- > 4 files changed, 10 insertions(+), 9 deletions(-) > > diff --git a/lib/librte_eventdev/rte_event_crypto_adapter.c b/lib/librte_eventdev/rte_event_crypto_adapter.c > index 8f25933..2717857 100644 > --- a/lib/librte_eventdev/rte_event_crypto_adapter.c > +++ b/lib/librte_eventdev/rte_event_crypto_adapter.c > @@ -269,7 +269,7 @@ struct crypto_queue_pair_info { > event_crypto_adapter[id] = adapter; > > rte_eventdev_trace_crypto_adapter_create(id, dev_id, adapter, conf_arg, > - mode); > + mode); # Be careful about, unwanted line changes in the series. If you would like to fix some coding standard stuff send a separate patch. Please don't make unnecessary line changes in the patch. # Please make sure all patches pass check-git-log.sh and checkpatch.sh sanity. > return 0; > } > > diff --git a/lib/librte_eventdev/rte_event_eth_tx_adapter.c b/lib/librte_eventdev/rte_event_eth_tx_adapter.c > index 8a72256..a8a010e 100644 > --- a/lib/librte_eventdev/rte_event_eth_tx_adapter.c > +++ b/lib/librte_eventdev/rte_event_eth_tx_adapter.c > @@ -943,8 +943,9 @@ static int txa_service_queue_del(uint8_t id, > txa_dev_id_array[id] = TXA_INVALID_DEV_ID; > return ret; > } > + > rte_eventdev_trace_eth_tx_adapter_create(id, dev_id, NULL, port_conf, > - ret); > + ret); > txa_dev_id_array[id] = dev_id; > return 0; > } > @@ -987,7 +988,7 @@ static int txa_service_queue_del(uint8_t id, > } > > rte_eventdev_trace_eth_tx_adapter_create(id, dev_id, conf_cb, conf_arg, > - ret); > + ret); > txa_dev_id_array[id] = dev_id; > return 0; > } > diff --git a/lib/librte_eventdev/rte_eventdev.c b/lib/librte_eventdev/rte_eventdev.c > index db2f9b7..550de73 100644 > --- a/lib/librte_eventdev/rte_eventdev.c > +++ b/lib/librte_eventdev/rte_eventdev.c > @@ -816,6 +816,7 @@ > diag = rte_event_port_unlink(dev_id, port_id, NULL, 0); > > rte_eventdev_trace_port_setup(dev_id, port_id, port_conf, diag); > + > if (diag < 0) > return diag; > > @@ -1425,10 +1426,8 @@ struct rte_eventdev * > eventdev->data = eventdev_data; > > if (rte_eal_process_type() == RTE_PROC_PRIMARY) { > - > strlcpy(eventdev->data->name, name, > RTE_EVENTDEV_NAME_MAX_LEN); > - > eventdev->data->dev_id = dev_id; > eventdev->data->socket_id = socket_id; > eventdev->data->dev_started = 0; > diff --git a/lib/librte_eventdev/rte_eventdev_trace.h b/lib/librte_eventdev/rte_eventdev_trace.h > index 4de6341..5dd72d9 100644 > --- a/lib/librte_eventdev/rte_eventdev_trace.h > +++ b/lib/librte_eventdev/rte_eventdev_trace.h > @@ -53,13 +53,14 @@ > RTE_TRACE_POINT( > rte_eventdev_trace_port_setup, > RTE_TRACE_POINT_ARGS(uint8_t dev_id, uint8_t port_id, > - const struct rte_event_port_conf *port_conf, int rc), > + const struct rte_event_port_conf *port_conf, > + int rc), > rte_trace_point_emit_u8(dev_id); > rte_trace_point_emit_u8(port_id); > rte_trace_point_emit_i32(port_conf->new_event_threshold); > rte_trace_point_emit_u16(port_conf->dequeue_depth); > rte_trace_point_emit_u16(port_conf->enqueue_depth); > - rte_trace_point_emit_u8(port_conf->disable_implicit_release); > + rte_trace_point_emit_u32(port_conf->event_port_cfg); > rte_trace_point_emit_int(rc); > ) > > @@ -165,7 +166,7 @@ > rte_trace_point_emit_i32(port_conf->new_event_threshold); > rte_trace_point_emit_u16(port_conf->dequeue_depth); > rte_trace_point_emit_u16(port_conf->enqueue_depth); > - rte_trace_point_emit_u8(port_conf->disable_implicit_release); > + rte_trace_point_emit_u32(port_conf->event_port_cfg); > rte_trace_point_emit_ptr(conf_cb); > rte_trace_point_emit_int(rc); > ) > @@ -257,7 +258,7 @@ > rte_trace_point_emit_i32(port_conf->new_event_threshold); > rte_trace_point_emit_u16(port_conf->dequeue_depth); > rte_trace_point_emit_u16(port_conf->enqueue_depth); > - rte_trace_point_emit_u8(port_conf->disable_implicit_release); > + rte_trace_point_emit_u32(port_conf->event_port_cfg); > ) > > RTE_TRACE_POINT( > -- > 1.7.10 >