From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A9B12A0548; Fri, 23 Apr 2021 11:05:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 666DA4067E; Fri, 23 Apr 2021 11:05:45 +0200 (CEST) Received: from mail-il1-f176.google.com (mail-il1-f176.google.com [209.85.166.176]) by mails.dpdk.org (Postfix) with ESMTP id 6C4584014F for ; Fri, 23 Apr 2021 11:05:43 +0200 (CEST) Received: by mail-il1-f176.google.com with SMTP id c3so34013087ils.5 for ; Fri, 23 Apr 2021 02:05:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5MG/9Dk9ZXAusD0LXvfS8UCz/ihmPqw2PTCNKKwyyDE=; b=BHLTzWt01JtFuHrpuUzcGGyYetbh6JIQuz2/ByOgkm0N88e+O3Cpeu32LX1fKNJ52d ePyD43pRcsK4QEu6pmBsYYC8o1z9/dWz1eb8A+Rm5KhNfwUrxJJJLWKcRRYgxqUiuQ0O yCkaEAoiFi4lAlxPB3EH716Kd4/pq2DSoUV5ej7iUpun3xqzcH5L77JoDHmivT4LrcEo CUA6/QdsOmiAz3t4keRjc2io6CbIbN/NWj/3NEb9FdgVsqdph1bx6kRgpgFbtx1Aq+Eb lGYBpVZK5VvrYbMHRztHN2d0EPGOn3XpbJewYf1c/e2m9c6scN9aly7Cvh5i64poZOAk ZggA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5MG/9Dk9ZXAusD0LXvfS8UCz/ihmPqw2PTCNKKwyyDE=; b=WDHGllm2MbAv/eJHQ1X6e69+Gb96hyyf4rbpCweUFL9ajbVujHWVl++GTTTiuOF1od Emx41yuDXFFsc43bFANQNRmRdqiQIbW0pvZEAT64LOm28fAVXcfqD0CsQ1I/EqjZfOu1 ZXtzXG1GOWvI3znvd3daTyuu+3MF7qlaepZDKTEHBMUVvx9sFjURh5I8vsri2jj+Yw0F tXjgriWb1eO1sj23Qedl3uiJ4X5y5vh1QMn7Heap3ZkMqYq3gXnASYX0s9ElTL9VYNNp Wb2t+9vJWmlX2rTLKO3eZrjHkqwaHYNJQdZstESXziMllNQM8uwALUwlI7wJZ+ZqVFFE 3m2g== X-Gm-Message-State: AOAM530w0kBqlA6W2s29hdcE4r9rgIIcT9vekRot6r47y20SRZHti/54 yfy4XvcxjSRP/Y+1xSbNWbxEUhWtqKaF9ZdAols= X-Google-Smtp-Source: ABdhPJzlLQOVXkdAEz8hrIR32GohE1s4QljSnlTjl0VhASSZE7ENE0R6F+Y1k1oBFe81CwicezWJhdWdHQt1bJbd1rk= X-Received: by 2002:a92:c26a:: with SMTP id h10mr2106506ild.294.1619168742813; Fri, 23 Apr 2021 02:05:42 -0700 (PDT) MIME-Version: 1.0 References: <1619092340-4047-1-git-send-email-humin29@huawei.com> <1619092340-4047-3-git-send-email-humin29@huawei.com> In-Reply-To: <1619092340-4047-3-git-send-email-humin29@huawei.com> From: Jerin Jacob Date: Fri, 23 Apr 2021 14:35:26 +0530 Message-ID: To: "Min Hu (Connor)" Cc: dpdk-dev , Ferruh Yigit , Jerin Jacob , Kiran Kumar K Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 2/2] graph: fix dereferencing null pointer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Apr 22, 2021 at 5:22 PM Min Hu (Connor) wrote: > > From: HongBo Zheng > > In function 'stats_mem_init', pointer 'stats' should > be confirmed not null before memset it. > > Fixes: af1ae8b6a32c ("graph: implement stats") > Cc: stable@dpdk.org > > Signed-off-by: HongBo Zheng > Signed-off-by: Min Hu (Connor) > --- > lib/librte_graph/graph_stats.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_graph/graph_stats.c b/lib/librte_graph/graph_stats.c The directory name is changed in upstream. Please rebase. Acked-by: Jerin Jacob > index f698bb3..bdc8652 100644 > --- a/lib/librte_graph/graph_stats.c > +++ b/lib/librte_graph/graph_stats.c > @@ -119,8 +119,8 @@ stats_mem_init(struct cluster *cluster, > cluster_node_size = RTE_ALIGN(cluster_node_size, RTE_CACHE_LINE_SIZE); > > stats = realloc(NULL, sz); > - memset(stats, 0, sz); > if (stats) { > + memset(stats, 0, sz); > stats->fn = fn; > stats->cluster_node_size = cluster_node_size; > stats->max_nodes = 0; > -- > 2.7.4 >