From: Jerin Jacob <jerinjacobk@gmail.com>
To: Shijith Thotton <sthotton@marvell.com>
Cc: dpdk-dev <dev@dpdk.org>,
Abhinandan Gujjar <abhinandan.gujjar@intel.com>,
Jerin Jacob <jerinj@marvell.com>,
Akhil Goyal <gakhil@marvell.com>,
Anoob Joseph <anoobj@marvell.com>
Subject: Re: [dpdk-dev] [PATCH v1] eventdev: fix case to initiate crypto adapter service
Date: Mon, 12 Apr 2021 13:00:03 +0530 [thread overview]
Message-ID: <CALBAE1NwY29k=CQ7ez=c0fjT-f=a4+cuYe2kcNwhjOrPv0wP9Q@mail.gmail.com> (raw)
In-Reply-To: <20210409070809.456444-1-sthotton@marvell.com>
On Fri, Apr 9, 2021 at 12:38 PM Shijith Thotton <sthotton@marvell.com> wrote:
>
> Initiate software crypto adapter service, only if hardware capabilities
> are not reported.
>
> Case 1.a. OP_FORWARD mode -> HW Dequeue + SW enqueue, should also check
Case 1.a is required in the commit message?
> OP_FORWARD capability is not supported by the PMD to initiate service.
>
> Fixes: 7901eac3409a ("eventdev: add crypto adapter implementation")
>
> Signed-off-by: Shijith Thotton <sthotton@marvell.com>
@Gujjar, Abhinandan S
Any comments on this?
> ---
> lib/librte_eventdev/rte_event_crypto_adapter.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/librte_eventdev/rte_event_crypto_adapter.c b/lib/librte_eventdev/rte_event_crypto_adapter.c
> index d903cdd48..e1d38d383 100644
> --- a/lib/librte_eventdev/rte_event_crypto_adapter.c
> +++ b/lib/librte_eventdev/rte_event_crypto_adapter.c
> @@ -861,6 +861,7 @@ rte_event_crypto_adapter_queue_pair_add(uint8_t id,
> * b. OP_NEW mode -> SW Dequeue
> */
> if ((cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW &&
> + !(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) &&
> adapter->mode == RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD) ||
> (!(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW) &&
> !(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) &&
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-04-12 7:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 7:08 Shijith Thotton
2021-04-12 7:30 ` Jerin Jacob [this message]
2021-04-12 8:53 ` [dpdk-dev] [PATCH v2] " Shijith Thotton
2021-04-13 4:08 ` Gujjar, Abhinandan S
2021-04-13 7:51 ` Shijith Thotton
2021-04-14 7:06 ` Gujjar, Abhinandan S
2021-04-17 17:24 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1NwY29k=CQ7ez=c0fjT-f=a4+cuYe2kcNwhjOrPv0wP9Q@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=abhinandan.gujjar@intel.com \
--cc=anoobj@marvell.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=jerinj@marvell.com \
--cc=sthotton@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).