From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB15DA0C44; Mon, 12 Apr 2021 09:30:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8DB0A140F4C; Mon, 12 Apr 2021 09:30:20 +0200 (CEST) Received: from mail-io1-f50.google.com (mail-io1-f50.google.com [209.85.166.50]) by mails.dpdk.org (Postfix) with ESMTP id DC4AF40698 for ; Mon, 12 Apr 2021 09:30:19 +0200 (CEST) Received: by mail-io1-f50.google.com with SMTP id e186so12433349iof.7 for ; Mon, 12 Apr 2021 00:30:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DcwzqwC/Mlix9VU26mMv2+7OA/8zx6PTqkfJ87HRZ24=; b=uirCihmAfZAukmVWA22Av/dTJG7pdNtEwqDkCL8yeE+ZoO90iAmrC8sk7X3k4iSFfm H8D6MQ8c0L+TUP1iKlOi9dBLoEEzNi5ih7B0gCIApAudG3q/Ge6l3Aj1QbrgQrvKk8QA zZnOvWY45PdN8w7PYbRwvfHz3NPyZeHK0/naBth4t4oPwJIDM6LV42/Y9sNqk/JUJXeP 67op2gG4DRWCBUTElTLZ69UTF6BLldVbc4Y81bI+4dCZz6FVRhGJY/qRfldq7Z1LES4P UP5ALIefB2i+ZHlGK3OhMOCD6oKlRC0wn07TlWB02Ml1A3c8E1qZh7COSneJym9UiQaF mhIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DcwzqwC/Mlix9VU26mMv2+7OA/8zx6PTqkfJ87HRZ24=; b=nSoA0Bonc5QfGBYXzbNuKyOi7+ePVLbB70eNGKOExKXf1DapefgX6VUYwiYedOLqj1 2nSayC4TW3C6xurM44QhCT0B69BVFptB6o9UrHhuIxt6fu5cYNw8wYJiSgctnLAhTztG 2ztBgsHwpU8Hy48zMWiGWG15Gnm4wiXU5fPdBJv8YJuuyYqvRdWaCLz9X8tDWAAW6fIQ lkAka3k9sZDr+vDKFhnItkF5QGsOaaapxSnLi0KO+UIkxPWwR3sZXiidfaBeC42XC5BN G4ohiml4g5FzE6pdvbLg841DlgRM+erNEP2Do15ga7g9aGrQoYUXP4IfjSU0c/bcCjn9 XVBQ== X-Gm-Message-State: AOAM533CaaAvtfV/vhTt+O/03YUh+be57qWhvEI1qdtPufyUuhkpkOfI 9QvVx83ewen2+ZNFOVvaFLT0gcEm1gF1iQITBeU= X-Google-Smtp-Source: ABdhPJxebK2Fj+gxZb7Um1cWfjVIUPaIzZfQtQTgTAAxPl16UYZlmfnbr9SZW0dhOdmielS2m5KZl+SkpREmyr62ewg= X-Received: by 2002:a6b:b7cd:: with SMTP id h196mr21304894iof.59.1618212619328; Mon, 12 Apr 2021 00:30:19 -0700 (PDT) MIME-Version: 1.0 References: <20210409070809.456444-1-sthotton@marvell.com> In-Reply-To: <20210409070809.456444-1-sthotton@marvell.com> From: Jerin Jacob Date: Mon, 12 Apr 2021 13:00:03 +0530 Message-ID: To: Shijith Thotton Cc: dpdk-dev , Abhinandan Gujjar , Jerin Jacob , Akhil Goyal , Anoob Joseph Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v1] eventdev: fix case to initiate crypto adapter service X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Apr 9, 2021 at 12:38 PM Shijith Thotton wrote: > > Initiate software crypto adapter service, only if hardware capabilities > are not reported. > > Case 1.a. OP_FORWARD mode -> HW Dequeue + SW enqueue, should also check Case 1.a is required in the commit message? > OP_FORWARD capability is not supported by the PMD to initiate service. > > Fixes: 7901eac3409a ("eventdev: add crypto adapter implementation") > > Signed-off-by: Shijith Thotton @Gujjar, Abhinandan S Any comments on this? > --- > lib/librte_eventdev/rte_event_crypto_adapter.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/librte_eventdev/rte_event_crypto_adapter.c b/lib/librte_eventdev/rte_event_crypto_adapter.c > index d903cdd48..e1d38d383 100644 > --- a/lib/librte_eventdev/rte_event_crypto_adapter.c > +++ b/lib/librte_eventdev/rte_event_crypto_adapter.c > @@ -861,6 +861,7 @@ rte_event_crypto_adapter_queue_pair_add(uint8_t id, > * b. OP_NEW mode -> SW Dequeue > */ > if ((cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW && > + !(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) && > adapter->mode == RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD) || > (!(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW) && > !(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) && > -- > 2.25.1 >