From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1B9D0A00C5; Thu, 14 Jul 2022 12:37:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AB79942B73; Thu, 14 Jul 2022 12:37:18 +0200 (CEST) Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by mails.dpdk.org (Postfix) with ESMTP id 0E9F642B6D for ; Thu, 14 Jul 2022 12:37:18 +0200 (CEST) Received: by mail-qt1-f169.google.com with SMTP id c20so1049862qtw.8 for ; Thu, 14 Jul 2022 03:37:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KtKntSzFkA0GGg8cQe+eBBAAKirGnvceiHLl9PCZUl0=; b=VoM2fUeTV63SSZLqul3fHNnoOmoP5qsN9LKgem1O72sim770a8UYLxE9Lq6NQiw4Bx uQ/wIov1MUEW1t9GuiCY05IkMMvYWBABm7Slqf7varinKGPqErL373ptl+EGHGZS0+NS ov0NmJ2Wo169yk/xHj/g4U7bkqm+1t6gvmVqoRQL4zV8WikuRZn8uoUBsy81PQcrr4Qs 0GHQiQynhcoXP0Rn1bbjBFYTpZbS5JuC4e1nR35LP5pTVJURFonFEbhEEtdDIS0PwqLY 553HsuBAA9qqhVGrqgmUVJdQPecYoG0ZaeYGi52JuH36UhLDzu0ToJq6jwKh6f98yo/Q blSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KtKntSzFkA0GGg8cQe+eBBAAKirGnvceiHLl9PCZUl0=; b=4kHvIMTceGRiKZVEE/NZqHDXTcyKXJmEuCRRLLd2GDMJSowviTgdzt8EXFtPi3nrcN cJ4pOB37iLqk1xDIN//d9Ad3hs5JMysqTYPxhXvcyxtQ4mXolwSREXogV8i4bmPZLqPS OX7e/aMa7AXl65Ss8C6kcqjCeZ+rGxNGXOwwHkMojuix1dqFcG+zJvywbIBcYMSxmNOA VkvvB+2w+eKlkbdj0QMVJpqYV1bIdVFitMv2mA11tbyZmGDnWsMmUj9DIEhti0F3EK5R AUGOAzFdpTGxFOT9Cl2bMHiL9dqfNbD05gRGhMHrorto3pEZd4JWvY8NoLjjYviB3iXE HasA== X-Gm-Message-State: AJIora/EH4o3e7RNhQXXvKyEDq8b9N7D894Zp0Sic32ThNqqnO1xRVGL CRjhFKW5M2CJAYNnB8znCig17BAyIlPkpsymw6E= X-Google-Smtp-Source: AGRyM1uiFkBaDrTgG44b42YSIWXn6KGrS+q4YQ45IvMfJ7ZmrgeWdVxV4ZWaWJGJlQPzju/0u9psRha1t3ttWtJuUSg= X-Received: by 2002:a05:622a:1803:b0:31e:d40c:9cc8 with SMTP id t3-20020a05622a180300b0031ed40c9cc8mr526500qtc.74.1657795037338; Thu, 14 Jul 2022 03:37:17 -0700 (PDT) MIME-Version: 1.0 References: <20220713155043.11490-1-olivier.matz@6wind.com> In-Reply-To: From: Jerin Jacob Date: Thu, 14 Jul 2022 16:06:51 +0530 Message-ID: Subject: Re: [PATCH] doc: announce behavior change for device NUMA node field To: Bruce Richardson Cc: Olivier Matz , dpdk-dev , Ray Kinsella , David Marchand Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jul 14, 2022 at 3:40 PM Bruce Richardson wrote: > > On Wed, Jul 13, 2022 at 05:50:43PM +0200, Olivier Matz wrote: > > The dev->device.numa_node field is set by the bus driver for each device > > it manages to indicate on which NUMA node this device lies. > > > > When this information is unknown, the assigned value is not consistent > > across the bus drivers. In v22.11, the value will be set to -1 in > > this case. > > > > Link: https://patches.dpdk.org/project/dpdk/patch/20211026090610.10823-1-houssem.bouhlel@6wind.com/ > > > > Signed-off-by: Olivier Matz > > --- > > doc/guides/rel_notes/deprecation.rst | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > > index 4e5b23c53d..5f269bf527 100644 > > --- a/doc/guides/rel_notes/deprecation.rst > > +++ b/doc/guides/rel_notes/deprecation.rst > > @@ -125,3 +125,9 @@ Deprecation Notices > > applications should be updated to use the ``dmadev`` library instead, > > with the underlying HW-functionality being provided by the ``ioat`` or > > ``idxd`` dma drivers > > + > > +* bus: The ``dev->device.numa_node`` field is set by the bus driver for > > + each device it manages to indicate on which NUMA node this device > > + lies. When this information is unknown, the assigned value is not > > + consistent across the bus drivers. In v22.11, the value will be set > > + to -1 in this case. > > Acked-by: Bruce Richardson Acked-by: Jerin Jacob > > Couple of minor rewording suggestions: > * "the bus driver" seems wrong in the first line as we haven't referred to > one in particular. How about "...set by each bus driver for every device..." > > * "the assigned value is not consistent across the bus drivers" - this > reads a little strange to me and I find it unclear. Not sure how to > reword it, maybe something like: "each bus driver selects its own value to > set. To resolve this inconsistency, in v22.11, the device numa_node value > will be set to -1 by all bus drivers when the actual NUMA information is > unavailable." > > > > -- > > 2.30.2 > >