From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0DA18A00D7; Thu, 31 Oct 2019 11:50:45 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 759951C216; Thu, 31 Oct 2019 11:50:43 +0100 (CET) Received: from mail-il1-f196.google.com (mail-il1-f196.google.com [209.85.166.196]) by dpdk.org (Postfix) with ESMTP id 181C81C06B for ; Thu, 31 Oct 2019 11:50:42 +0100 (CET) Received: by mail-il1-f196.google.com with SMTP id i12so4949935ils.6 for ; Thu, 31 Oct 2019 03:50:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZFMHC5Hbo2T5T4mpR9y1ILiVPoXA5cKGozmqLUXnhFo=; b=MMyBALwd9nKmALuKpNku76fgmWxb96JjbXXFbNFVMkAMdDh3z/0j+bNa7QYYG+f0TU EzNcTi1LweEKqJ2BJroLdPN4dw3seh8imORkTLLv9SJEPV8cllEm2p8Um3l8G8Oa366V /Gx9n7QQBDnpmue+eWTdcUMTaS8d+2rp/Pmt0dXkuMzDkBVOhafvSk1zKSJ1C3+59dV4 OzLdbcxcyq1i8G9C2uOAl7+yr+Wt157k41RoV1LiDIgxCGwp1U1dMPVIBPV4MOWFyJF0 F7aUdS2ZqSNTx8M89MhXjoN/DSRmfMvekR7of7c7LjxNz06/QZDOC+kNH09w0M6NP0do PXLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZFMHC5Hbo2T5T4mpR9y1ILiVPoXA5cKGozmqLUXnhFo=; b=dg/7LXZTrlIYrvcFLXnbpDW8yXdP9NO4kb6a8uAuMFv+COOZT9KsAOChl7Gb3pbCcv 3Et1jdGpDwo1n0+1qh3BWlq/vDFt+l/qiq3JND2Qk4A3h/0YLj9CdHYV10UFURLMj39/ wF9muMEI+UfXlGhOYqJoynoJe6kaxJipOb4SlXuQAsh8NRDB0U3ETTWpzDRDfrMtlygg oIiUoA+wI1rl20GEzBo2EEAJSbQ79yt7WtsLkjuurF+j2TEHDvqOgGOWXktKtcTHnFa7 jN1cjDRZwrj9IO7UU5ZGNq4JxKLWdy9bP8iOEeudgkwtSIrhrrCXnGN4vBqn1C8ujUWP Q13g== X-Gm-Message-State: APjAAAXtMCDDfw7SJTdCxXnk3rIWT7rInLXiIi3IEUZPouzw2Ku1cbDM wfev5jD8bfBrn5OCYXNdo7qdRDGkUhEcpCXcohc= X-Google-Smtp-Source: APXvYqwzjzjYq9T85xVB8slJrQM1qiv0D1FwExl0IsPLZghK7usOcbCHWCdlvdjnvf2Hkr0PXZ0No4Roci49MI6XuQg= X-Received: by 2002:a92:1612:: with SMTP id r18mr5217857ill.60.1572519041071; Thu, 31 Oct 2019 03:50:41 -0700 (PDT) MIME-Version: 1.0 References: <20191023160707.2329-1-pbhagavatula@marvell.com> In-Reply-To: <20191023160707.2329-1-pbhagavatula@marvell.com> From: Jerin Jacob Date: Thu, 31 Oct 2019 16:20:25 +0530 Message-ID: To: Pavan Nikhilesh Cc: Jerin Jacob , dpdk-dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] event/octeontx2: remove hotspots by prefetching data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 23, 2019 at 9:37 PM wrote: > > From: Pavan Nikhilesh > > Recent profiling revealed few hotspots in octeontx2 event device > driver add prefetch hints to reduce stalls. > > Signed-off-by: Pavan Nikhilesh Applied to dpdk-next-eventdev/master. Thanks. > --- > drivers/event/octeontx2/otx2_worker.h | 1 + > drivers/event/octeontx2/otx2_worker_dual.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/event/octeontx2/otx2_worker.h b/drivers/event/octeontx2/otx2_worker.h > index 6f7842199..092ba71f7 100644 > --- a/drivers/event/octeontx2/otx2_worker.h > +++ b/drivers/event/octeontx2/otx2_worker.h > @@ -280,6 +280,7 @@ otx2_ssogws_event_tx(struct otx2_ssogws *ws, struct rte_event ev[], > struct rte_mbuf *m = ev[0].mbuf; > const struct otx2_eth_txq *txq = otx2_ssogws_xtract_meta(m); > > + rte_prefetch_non_temporal(txq); > /* Perform header writes before barrier for TSO */ > otx2_nix_xmit_prepare_tso(m, flags); > otx2_ssogws_order(ws, !ev->sched_type); > diff --git a/drivers/event/octeontx2/otx2_worker_dual.c b/drivers/event/octeontx2/otx2_worker_dual.c > index ff68472ef..7016eee4a 100644 > --- a/drivers/event/octeontx2/otx2_worker_dual.c > +++ b/drivers/event/octeontx2/otx2_worker_dual.c > @@ -148,6 +148,7 @@ otx2_ssogws_dual_deq_ ##name(void *port, struct rte_event *ev, \ > struct otx2_ssogws_dual *ws = port; \ > uint8_t gw; \ > \ > + rte_prefetch_non_temporal(ws); \ > RTE_SET_USED(timeout_ticks); \ > if (ws->swtag_req) { \ > otx2_ssogws_swtag_wait((struct otx2_ssogws *) \ > -- > 2.17.1 >