From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 59387A0547; Sun, 28 Mar 2021 11:15:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EAC2240042; Sun, 28 Mar 2021 11:15:48 +0200 (CEST) Received: from mail-io1-f41.google.com (mail-io1-f41.google.com [209.85.166.41]) by mails.dpdk.org (Postfix) with ESMTP id 3433440040 for ; Sun, 28 Mar 2021 11:15:48 +0200 (CEST) Received: by mail-io1-f41.google.com with SMTP id k25so9749679iob.6 for ; Sun, 28 Mar 2021 02:15:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oO55elQi8YjCCZgelSrb7ks/ZZh27eNwuB95fINXK0g=; b=mSsvj8+D8X4IJ4XGLwJbWd2IDZtkLWsn6LvgepmVHLZ1EOnD2gu0zBUwRyqII+CrZl +6bkJoN7Q5jxmJJZWy2P4Zd6Cqc3xDGWT78qzAAmVKF+8oMy/N7sOhplCS5mI6BBsZEY z50MLSErX9tqhXsDOtB938GnFMaO3Nr208nsZjTXsna0C7e2HJb87ZlBPLOOoFn7eCO2 KJ+q6f+p1mgEYSQC5MUWI4zk2sf5TSsEk0OdfPvZhY+pCpPjoOQtZzPPuyYwa6HjjMHI jdtCx3YBzxU+SYmn7PeiNm2m2vgIfzRouxYqjD9b1x2Ps5usinckj9luyOyqscW9xPT5 Tymw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oO55elQi8YjCCZgelSrb7ks/ZZh27eNwuB95fINXK0g=; b=WkPE61IzYN2Hv74d8pdv5EA7G7qKm8NeSxHXhW54FtJ8JgP3LDpzfSWxXwIopZLdCb g1NoAc8DYXcRItk3xP/HCV1CGvLzS6tkaR4JFGQjjrCrivWXHL71gpiS4pZXHqm2SNaz fopq1pN+heVAFaPw8mlypEHdX8nMPYhp4MgLXJsI7z2TDZ81fPcZTlplt040Y5nf5phH OWyA0EjSdj0eqMMRJZCF9UJuxi0Z/Nmrc/G19dEcYXu6sYG/Q7bRXSneFjA9or1NsGNx UI/D6P3zC3aYfRkODtpyEPSGUrA0mSGV8QVdoO/+KRUegP/mSoQMDIpIHAsiMZflC6lA 5DQA== X-Gm-Message-State: AOAM533nX3LpF08BqsTOJm8pmrnUnj0+dhwtexmvBL6wgjiLYhE51XO3 iJIAmhQyNPkkZS6y6izsYs4JaQpvsKz3TNeQptY= X-Google-Smtp-Source: ABdhPJz36fmuH7BTUmgEusFRuqsZ6GiQAoEd0jFp8JVw3MMmyfASUjaHmAWnDZS3c5gLVTF29MIuvt/LPW2Lfa5boZ8= X-Received: by 2002:a02:7f0e:: with SMTP id r14mr18690637jac.112.1616922947640; Sun, 28 Mar 2021 02:15:47 -0700 (PDT) MIME-Version: 1.0 References: <20210305162149.2196166-1-asekhar@marvell.com> <20210305162149.2196166-3-asekhar@marvell.com> In-Reply-To: <20210305162149.2196166-3-asekhar@marvell.com> From: Jerin Jacob Date: Sun, 28 Mar 2021 14:45:31 +0530 Message-ID: To: Ashwin Sekhar T K Cc: dpdk-dev , Jerin Jacob , Sunil Kumar Kori , Satha Koteswara Rao Kottidi , Pavan Nikhilesh , Kiran Kumar K , Satheesh Paul Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 2/6] mempool/cnxk: add generic ops X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Mar 5, 2021 at 11:43 PM Ashwin Sekhar T K wrote: > > Add generic cnxk mempool ops. > > Signed-off-by: Ashwin Sekhar T K > --- > +int > +cnxk_mempool_alloc(struct rte_mempool *mp) > +{ > + uint64_t aura_handle = 0; > + struct npa_aura_s aura; > + struct npa_pool_s pool; > + uint32_t block_count; > + size_t block_size; > + int rc = -ERANGE; > + > + block_size = mp->elt_size + mp->header_size + mp->trailer_size; > + block_count = mp->size; > + if (mp->header_size % ROC_ALIGN != 0) { > + plt_err("Header size should be multiple of %dB", ROC_ALIGN); > + goto error; > + } > + > + if (block_size % ROC_ALIGN != 0) { > + plt_err("Block size should be multiple of %dB", ROC_ALIGN); > + goto error; > + } > + > + memset(&aura, 0, sizeof(struct npa_aura_s)); > + memset(&pool, 0, sizeof(struct npa_pool_s)); > + pool.nat_align = 1; > + /* TODO: Check whether to allow buf_offset > 1 ?? */ Please fix up this TODO. > + pool.buf_offset = mp->header_size / ROC_ALIGN; > +