* [PATCH] net/cnxk: add threshold validation for RED config
@ 2023-01-02 16:43 skori
2023-01-17 12:05 ` Jerin Jacob
0 siblings, 1 reply; 2+ messages in thread
From: skori @ 2023-01-02 16:43 UTC (permalink / raw)
To: Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao; +Cc: dev
From: Sunil Kumar Kori <skori@marvell.com>
Validation is added to check minimum and maximum RED
threshold values, passed by user.
Fixes: b7d3a0fe71eb ("net/cnxk: support congestion management operations")
Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
---
drivers/net/cnxk/cnxk_ethdev_cman.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/cnxk/cnxk_ethdev_cman.c b/drivers/net/cnxk/cnxk_ethdev_cman.c
index d5e647c64d..a7ccdfb756 100644
--- a/drivers/net/cnxk/cnxk_ethdev_cman.c
+++ b/drivers/net/cnxk/cnxk_ethdev_cman.c
@@ -68,6 +68,11 @@ nix_cman_config_validate(struct rte_eth_dev *eth_dev, const struct rte_eth_cman_
return -EINVAL;
}
+ if (config->mode_param.red.min_th > config->mode_param.red.max_th) {
+ plt_err("RED minimum threshold must be less or equal to maximum threshold");
+ return -EINVAL;
+ }
+
return 0;
}
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] net/cnxk: add threshold validation for RED config
2023-01-02 16:43 [PATCH] net/cnxk: add threshold validation for RED config skori
@ 2023-01-17 12:05 ` Jerin Jacob
0 siblings, 0 replies; 2+ messages in thread
From: Jerin Jacob @ 2023-01-17 12:05 UTC (permalink / raw)
To: skori; +Cc: Nithin Dabilpuram, Kiran Kumar K, Satha Rao, dev
On Mon, Jan 2, 2023 at 10:14 PM <skori@marvell.com> wrote:
>
> From: Sunil Kumar Kori <skori@marvell.com>
>
> Validation is added to check minimum and maximum RED
> threshold values, passed by user.
>
> Fixes: b7d3a0fe71eb ("net/cnxk: support congestion management operations")
>
> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
Updated the git commit as follows and applied to
dpdk-next-net-mrvl/for-next-net. Thanks
net/cnxk: validate RED threshold config
Added vaalidation to check minimum and maximum RED threshold
values, passed by user.
Fixes: b7d3a0fe71eb ("net/cnxk: support congestion management operations")
CC: stable@dpdk.org
Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
> ---
> drivers/net/cnxk/cnxk_ethdev_cman.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/cnxk/cnxk_ethdev_cman.c b/drivers/net/cnxk/cnxk_ethdev_cman.c
> index d5e647c64d..a7ccdfb756 100644
> --- a/drivers/net/cnxk/cnxk_ethdev_cman.c
> +++ b/drivers/net/cnxk/cnxk_ethdev_cman.c
> @@ -68,6 +68,11 @@ nix_cman_config_validate(struct rte_eth_dev *eth_dev, const struct rte_eth_cman_
> return -EINVAL;
> }
>
> + if (config->mode_param.red.min_th > config->mode_param.red.max_th) {
> + plt_err("RED minimum threshold must be less or equal to maximum threshold");
> + return -EINVAL;
> + }
> +
> return 0;
> }
>
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-17 12:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-02 16:43 [PATCH] net/cnxk: add threshold validation for RED config skori
2023-01-17 12:05 ` Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).