From: Jerin Jacob <jerinjacobk@gmail.com>
To: Kiran Kumar K <kirankumark@marvell.com>,
Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Jerin Jacob <jerinj@marvell.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
dpdk-dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/octeontx2: move ESP parsing to LE layer
Date: Tue, 29 Sep 2020 23:26:32 +0530 [thread overview]
Message-ID: <CALBAE1O+xX750wV9PhiSyoN1tVpz2UpncZP3YNnUE11jA4L5NA@mail.gmail.com> (raw)
In-Reply-To: <20200827114042.475771-1-kirankumark@marvell.com>
On Thu, Aug 27, 2020 at 5:11 PM <kirankumark@marvell.com> wrote:
>
> From: Kiran Kumar K <kirankumark@marvell.com>
>
> Add support to parse NAT-T-ESP by moving the ESP parsing
> to LE.
>
> Signed-off-by: Kiran Kumar K <kirankumark@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
Applied to dpdk-next-net-mrvl/main. Thanks
> ---
> drivers/common/octeontx2/hw/otx2_npc.h | 2 +-
> drivers/net/octeontx2/otx2_flow_parse.c | 10 +++++-----
> drivers/net/octeontx2/otx2_lookup.c | 6 +++---
> 3 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/common/octeontx2/hw/otx2_npc.h b/drivers/common/octeontx2/hw/otx2_npc.h
> index efde1e214..45e60dfd5 100644
> --- a/drivers/common/octeontx2/hw/otx2_npc.h
> +++ b/drivers/common/octeontx2/hw/otx2_npc.h
> @@ -225,7 +225,6 @@ enum npc_kpu_ld_ltype {
> NPC_LT_LD_SCTP,
> NPC_LT_LD_ICMP6,
> NPC_LT_LD_IGMP = 8,
> - NPC_LT_LD_ESP,
> NPC_LT_LD_AH,
> NPC_LT_LD_GRE,
> NPC_LT_LD_NVGRE,
> @@ -237,6 +236,7 @@ enum npc_kpu_ld_ltype {
> enum npc_kpu_le_ltype {
> NPC_LT_LE_VXLAN = 1,
> NPC_LT_LE_GENEVE,
> + NPC_LT_LE_ESP,
> NPC_LT_LE_GTPU = 4,
> NPC_LT_LE_VXLANGPE,
> NPC_LT_LE_GTPC,
> diff --git a/drivers/net/octeontx2/otx2_flow_parse.c b/drivers/net/octeontx2/otx2_flow_parse.c
> index 2d9a5857c..e918574df 100644
> --- a/drivers/net/octeontx2/otx2_flow_parse.c
> +++ b/drivers/net/octeontx2/otx2_flow_parse.c
> @@ -245,6 +245,11 @@ otx2_flow_parse_le(struct otx2_parse_state *pst)
> info.len = sizeof(struct rte_flow_item_vxlan);
> lt = NPC_LT_LE_VXLAN;
> break;
> + case RTE_FLOW_ITEM_TYPE_ESP:
> + lt = NPC_LT_LE_ESP;
> + info.def_mask = &rte_flow_item_esp_mask;
> + info.len = sizeof(struct rte_flow_item_esp);
> + break;
> case RTE_FLOW_ITEM_TYPE_GTPC:
> lflags = NPC_F_UDP_GTP_GTPC;
> info.def_mask = &rte_flow_item_gtp_mask;
> @@ -441,11 +446,6 @@ otx2_flow_parse_ld(struct otx2_parse_state *pst)
> info.def_mask = &rte_flow_item_sctp_mask;
> info.len = sizeof(struct rte_flow_item_sctp);
> break;
> - case RTE_FLOW_ITEM_TYPE_ESP:
> - lt = NPC_LT_LD_ESP;
> - info.def_mask = &rte_flow_item_esp_mask;
> - info.len = sizeof(struct rte_flow_item_esp);
> - break;
> case RTE_FLOW_ITEM_TYPE_GRE:
> lt = NPC_LT_LD_GRE;
> info.def_mask = &rte_flow_item_gre_mask;
> diff --git a/drivers/net/octeontx2/otx2_lookup.c b/drivers/net/octeontx2/otx2_lookup.c
> index 10944bc17..14ea1cf79 100644
> --- a/drivers/net/octeontx2/otx2_lookup.c
> +++ b/drivers/net/octeontx2/otx2_lookup.c
> @@ -169,15 +169,15 @@ nix_create_non_tunnel_ptype_array(uint16_t *ptype)
> case NPC_LT_LD_NVGRE:
> val |= RTE_PTYPE_TUNNEL_NVGRE;
> break;
> - case NPC_LT_LD_ESP:
> - val |= RTE_PTYPE_TUNNEL_ESP;
> - break;
> }
>
> switch (le) {
> case NPC_LT_LE_VXLAN:
> val |= RTE_PTYPE_TUNNEL_VXLAN;
> break;
> + case NPC_LT_LE_ESP:
> + val |= RTE_PTYPE_TUNNEL_ESP;
> + break;
> case NPC_LT_LE_VXLANGPE:
> val |= RTE_PTYPE_TUNNEL_VXLAN_GPE;
> break;
> --
> 2.25.1
>
prev parent reply other threads:[~2020-09-29 17:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 11:40 kirankumark
2020-09-29 17:56 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1O+xX750wV9PhiSyoN1tVpz2UpncZP3YNnUE11jA4L5NA@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).