From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C9057A0C4A; Wed, 7 Jul 2021 12:43:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7D70D406FF; Wed, 7 Jul 2021 12:43:04 +0200 (CEST) Received: from mail-io1-f42.google.com (mail-io1-f42.google.com [209.85.166.42]) by mails.dpdk.org (Postfix) with ESMTP id 150C8406B4 for ; Wed, 7 Jul 2021 12:43:03 +0200 (CEST) Received: by mail-io1-f42.google.com with SMTP id a6so2653569ioe.0 for ; Wed, 07 Jul 2021 03:43:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/gPXQHu75SL+Sz/Vyf9mRPhqiPg4brgP0N/nKf72xXE=; b=lptlT6iiXnfmpSUwHNgmaRjmqEChUjh5HTDov66ImtSehJ8Kmv9D2SyvGeZa6jWuED 6idRtZYJ4c7vcDjKs0lgzqZHxNDyHPeXFWRrZDLwtfomftQvMmJIzxSfEXL/IhhggaFa 6t80+gk3HO57PjN6aOKPg6yZ2aaRKo2dnfddWbSyk3LRid8V7JwpvrCcvgUwe580oELP f3a7O9BgdNuDS2+Ok8vhUiOkAtg8y4OfnllFaogskUteXLOzF6dtUZoa4hJBn0ghHc0N 0IMnOllKyLk2Itxg3SAa2le2kuWi8Qsa4CO4jVrZ4Wufm4O9nAaj7RnSHOZkOIMbmPr5 hCjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/gPXQHu75SL+Sz/Vyf9mRPhqiPg4brgP0N/nKf72xXE=; b=ILxQgAsiXdVw4XoTb9ZRXmIsnxaxbQMBbOEcqDMW/0H+EZ3AytSKeyNMsc66Lj7nv1 xv2UtV830oLFtFS2OmOqEIhXocbOu/ln7SXHNLmExg/HODPVcC2WSehNg0jBCLrHxOMF I71/NKWVfRk28Wd6TSJa/BBumCgujKLNL1K8tOu5PkIEUrlfTQ1Bd5xCX31oLw12XFEa ypdGRmSLVHHAo7Uu25RuE4cAZ3rA1hLZIH/uePnRETJX387kJN1IoRUkS49FhllQL4Km dCXnMQUBxn+B2991+YF69xGQpIrahN98ojxsuBJWaQt03N3M9Yqf/2zQK4f9uN5JTLK9 Nh9w== X-Gm-Message-State: AOAM530lPfpt09oYRA66uKjhJKC6twj4qmPaFqlQ10KpEPhxoRjgpTY5 BhchF60DI1NrpfPhZI5KT/0NlPdcKuBUKLaiGpo= X-Google-Smtp-Source: ABdhPJwzab9PwacPJ+V24dosIZEmtll/d2npS4szWk+MmS1xbEUakDY5WClpJtVZfqRIAKVCj2O1FLddZAaixygTD0c= X-Received: by 2002:a02:a114:: with SMTP id f20mr21167878jag.60.1625654582441; Wed, 07 Jul 2021 03:43:02 -0700 (PDT) MIME-Version: 1.0 References: <1625231891-2963-1-git-send-email-fengchengwen@huawei.com> <20210706202841.661302-1-bruce.richardson@intel.com> <32b9fa47-918b-cb16-d4c1-729ee92ba6f4@huawei.com> In-Reply-To: <32b9fa47-918b-cb16-d4c1-729ee92ba6f4@huawei.com> From: Jerin Jacob Date: Wed, 7 Jul 2021 16:12:36 +0530 Message-ID: To: fengchengwen Cc: Bruce Richardson , dpdk-dev , Jerin Jacob , =?UTF-8?Q?Morten_Br=C3=B8rup?= Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [RFC UPDATE PATCH 0/9] dmadev rfc suggested updates X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jul 7, 2021 at 8:46 AM fengchengwen wrote: > > LGTM, thanks > > And I'am prepare dmadev V2, include: > a) Fix code review comments (e.g. multiple-process support, doxygen, comments, typo) > b) Flatten device abstraction to two layer: dmadev <> vchan I think we should not have "virtual" in API specification. it can be virtual or real based on real HW/SW/Driver implementation. I think, just chan enough. > c) Public API use dev_id and vchan_id to locate one vchan > d) Using the flags parameter instead of the fence API > e) Rename rte_dmadev_perform to rte_dmadev_submit so it corresponds to the stats variable. > > PS: Some code (lib/dmadev) will rebase this patchset > > > On 2021/7/7 4:28, Bruce Richardson wrote: > > This patchset contains a series of changes to dmadev based on work being done to > > port over our drivers to test this new infrastructure. Some of these are bug > > fixes to enable compilation e.g. missing exports or meson.build files, while > > others are suggested changes to enhance the API. All these patches are to be > > applied on top of [1] as they are mostly suggested changes to that RFC i.e. > > patches to the patch! > > > > The final patch includes some basic sanity tests for copy operations that we > > have ported over from the ioat self-tests to use the dmadev APIs. The basic > > dataplane part of those tests is probably ok for now, but the initialization of > > queues in that test code may need some enhancement. Feedback welcome. > > > > A tree with all these patches applied can be got at [2] if anyone wants to use > > that as a basis for working on drivers, or for other discussion. > > > > [1] http://patches.dpdk.org/project/dpdk/patch/1625231891-2963-1-git-send-email-fengchengwen@huawei.com/ > > [2] https://github.com/bruce-richardson/dpdk/tree/dmadev-rfcs > > > > Bruce Richardson (9): > > dmadev: add missing exports > > dmadev: change virtual addresses to IOVA > > dmadev: add dump function > > dmadev: remove xstats functions > > dmadev: drop cookie typedef > > dmadev: allow NULL parameters to completed ops call > > dmadev: stats structure updates > > drivers: add dma driver category > > app/test: add basic dmadev unit test > > > > app/test/meson.build | 2 + > > app/test/test_dmadev.c | 320 +++++++++++++++++++++++++++++++++++ > > drivers/dma/meson.build | 11 ++ > > drivers/meson.build | 1 + > > lib/dmadev/rte_dmadev.c | 66 ++------ > > lib/dmadev/rte_dmadev.h | 204 +++++++--------------- > > lib/dmadev/rte_dmadev_core.h | 16 +- > > lib/dmadev/rte_dmadev_pmd.h | 24 +-- > > lib/dmadev/version.map | 7 +- > > 9 files changed, 425 insertions(+), 226 deletions(-) > > create mode 100644 app/test/test_dmadev.c > > create mode 100644 drivers/dma/meson.build > > > > -- > > 2.30.2 > > > > > > . > > >